| Message ID | 20220517092518.93159-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | scsi: qedf: remove redundant variable op | expand |
Colin, > The variable op is assigned a value and is never read. The variable > is not used and is redundant, remove it. Applied to 5.19/scsi-staging, thanks!
On Tue, 17 May 2022 10:25:18 +0100, Colin Ian King wrote: > The variable op is assigned a value and is never read. The variable > is not used and is redundant, remove it. > > Applied to 5.19/scsi-queue, thanks! [1/1] scsi: qedf: remove redundant variable op https://git.kernel.org/mkp/scsi/c/fc65df48c88e
diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index 2ec1f710fd1d..e57cc22453d0 100644 --- a/drivers/scsi/qedf/qedf_io.c +++ b/drivers/scsi/qedf/qedf_io.c @@ -804,7 +804,6 @@ static void qedf_trace_io(struct qedf_rport *fcport, struct qedf_ioreq *io_req, struct qedf_io_log *io_log; struct scsi_cmnd *sc_cmd = io_req->sc_cmd; unsigned long flags; - uint8_t op; spin_lock_irqsave(&qedf->io_trace_lock, flags); @@ -813,7 +812,7 @@ static void qedf_trace_io(struct qedf_rport *fcport, struct qedf_ioreq *io_req, io_log->task_id = io_req->xid; io_log->port_id = fcport->rdata->ids.port_id; io_log->lun = sc_cmd->device->lun; - io_log->op = op = sc_cmd->cmnd[0]; + io_log->op = sc_cmd->cmnd[0]; io_log->lba[0] = sc_cmd->cmnd[2]; io_log->lba[1] = sc_cmd->cmnd[3]; io_log->lba[2] = sc_cmd->cmnd[4];
The variable op is assigned a value and is never read. The variable is not used and is redundant, remove it. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/scsi/qedf/qedf_io.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)