[v2,0/3] QOM improvements for rtc/mc146818rtc

Message

Bernhard Beschow May 22, 2022, 8:43 p.m. UTC

v2:
* Explicitly fail with &error_abort rather than NULL (Mark)
* Explicitly fail with &error_abort rather than NULL in existing code (me)
* Unexport rather than remove RTC_ISA_BASE (Mark)
* Use object_property_get_*u*int() also for "iobase" (me)

v1:
This little series enhances QOM support for mc146818rtc:
* makes microvm-dt respect mc146818rtc's IRQ number set by QOM property and
* adds an io_base QOM property similar to other ISA devices

Bernhard Beschow (3):
  hw/i386/microvm-dt: Force explicit failure if retrieving QOM property
    fails
  hw/i386/microvm-dt: Determine mc146818rtc's IRQ number from QOM
    property
  rtc/mc146818rtc: QOM'ify io_base offset

 hw/i386/microvm-dt.c         | 9 +++++----
 hw/rtc/mc146818rtc.c         | 9 ++++++---
 include/hw/rtc/mc146818rtc.h | 2 +-
 3 files changed, 12 insertions(+), 8 deletions(-)

Comments

Philippe Mathieu-Daudé May 22, 2022, 9:57 p.m. UTC | #1

On 22/5/22 22:43, Bernhard Beschow wrote:
> v2:
> * Explicitly fail with &error_abort rather than NULL (Mark)
> * Explicitly fail with &error_abort rather than NULL in existing code (me)
> * Unexport rather than remove RTC_ISA_BASE (Mark)
> * Use object_property_get_*u*int() also for "iobase" (me)
> 
> v1:
> This little series enhances QOM support for mc146818rtc:
> * makes microvm-dt respect mc146818rtc's IRQ number set by QOM property and
> * adds an io_base QOM property similar to other ISA devices
> 
> Bernhard Beschow (3):
>    hw/i386/microvm-dt: Force explicit failure if retrieving QOM property
>      fails
>    hw/i386/microvm-dt: Determine mc146818rtc's IRQ number from QOM
>      property
>    rtc/mc146818rtc: QOM'ify io_base offset

In patch 3 "iobase" could be u16. Otherwise,

Reviewed-by: Philippe Mathieu-Daudé <[e-mail]>