| Message ID | 20220510031056.1657-2-ctcchien@nuvoton.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | EDAC: nuvoton: Add nuvoton NPCM memory controller driver | expand |
On Tue, May 10, 2022 at 11:10:54AM +0800, Medad CChien wrote: > ECC must be configured in the BootBlock header. > Then, you can read error counts via the EDAC kernel framework. > > Signed-off-by: Medad CChien <ctcchien@nuvoton.com> > --- > arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi > index 3696980a3da1..ba542b26941e 100644 > --- a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi > +++ b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi > @@ -106,6 +106,13 @@ > interrupt-parent = <&gic>; > ranges; > > + mc: memory-controller@f0824000 { > + compatible = "nuvoton,npcm750-memory-controller"; > + reg = <0x0 0xf0824000 0x0 0x1000>; > + interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>; > + status = "disabled"; > + }; > + > rstc: rstc@f0801000 { > compatible = "nuvoton,npcm750-reset"; > reg = <0xf0801000 0x70>; > -- Please integrate scripts/checkpatch.pl into your patch creation workflow. Some of the warnings/errors *actually* make sense. In this case: WARNING: DT compatible string "nuvoton,npcm750-memory-controller" appears un-documented -- check ./Documentation/devicetree/bindings/ #35: FILE: arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi:110: + compatible = "nuvoton,npcm750-memory-controller"; For that I'm guessing patch 2 needs to go first in the series. In any case, the first two need an ACK from devicetree folks. WARNING: From:/Signed-off-by: email address mismatch: 'From: Medad CChien <medadyoung@gmail.com>' != 'Signed-off-by: Medad CChien <ctcchien@nuvoton.com>' For this one I wasn't sure so I had to ask: I guess it kinda makes sense to have the From: be the same as your SOB email. I.e., make sure the right authorship and SOB is maintained even when sending from machines with broken email setups. And that you can fix very easily: just add in your .git/config: [user] name = Medad CChien email = ctcchien@nuvoton.com and git would use that as the author and also slap a From: at the beginning of the patch with the correct name and email address. HTH.
Dear Borislav, Borislav Petkov <bp@alien8.de> 於 2022年5月19日 週四 上午1:44寫道： > > On Tue, May 10, 2022 at 11:10:54AM +0800, Medad CChien wrote: > > ECC must be configured in the BootBlock header. > > Then, you can read error counts via the EDAC kernel framework. > > > > Signed-off-by: Medad CChien <ctcchien@nuvoton.com> > > --- > > arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi > > index 3696980a3da1..ba542b26941e 100644 > > --- a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi > > +++ b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi > > @@ -106,6 +106,13 @@ > > interrupt-parent = <&gic>; > > ranges; > > > > + mc: memory-controller@f0824000 { > > + compatible = "nuvoton,npcm750-memory-controller"; > > + reg = <0x0 0xf0824000 0x0 0x1000>; > > + interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>; > > + status = "disabled"; > > + }; > > + > > rstc: rstc@f0801000 { > > compatible = "nuvoton,npcm750-reset"; > > reg = <0xf0801000 0x70>; > > -- > > Please integrate scripts/checkpatch.pl into your patch creation > workflow. Some of the warnings/errors *actually* make sense. > > In this case: > > WARNING: DT compatible string "nuvoton,npcm750-memory-controller" appears un-documented -- check ./Documentation/devicetree/bindings/ > #35: FILE: arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi:110: > + compatible = "nuvoton,npcm750-memory-controller"; > > For that I'm guessing patch 2 needs to go first in the series. > > In any case, the first two need an ACK from devicetree folks. > > WARNING: From:/Signed-off-by: email address mismatch: 'From: Medad CChien <medadyoung@gmail.com>' != 'Signed-off-by: Medad CChien <ctcchien@nuvoton.com>' > > For this one I wasn't sure so I had to ask: I guess it kinda makes sense > to have the From: be the same as your SOB email. I.e., make sure the > right authorship and SOB is maintained even when sending from machines > with broken email setups. > > And that you can fix very easily: just add in your .git/config: > > [user] > name = Medad CChien > email = ctcchien@nuvoton.com > > and git would use that as the author and also slap a From: at the > beginning of the patch with the correct name and email address. > OK, I got it. > HTH. > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette
On Thu, May 19, 2022 at 08:55:53AM +0800, Medad Young wrote:
> OK, I got it.
Are you sure you did get it?
$ ./scripts/checkpatch.pl /tmp/medad-v10-1-3.patch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29:
new file mode 100644
WARNING: From:/Signed-off-by: email address mismatch: 'From: Medad CChien <medadyoung@gmail.com>' != 'Signed-off-by: Medad CChien <ctcchien@nuvoton.com>'
total: 0 errors, 2 warnings, 62 lines checked
Before sending, you should really run checkpatch on your patches.
Dear Borislav, Borislav Petkov <bp@alien8.de> 於 2022年5月19日 週四 下午5:34寫道： > > On Thu, May 19, 2022 at 08:55:53AM +0800, Medad Young wrote: > > OK, I got it. > > Are you sure you did get it? > for the second warning, I did upadate my .git/config according to your advise. but I thought I met orthe problem, I will try to fix it for the first warning, did I really need to fix it? > $ ./scripts/checkpatch.pl /tmp/medad-v10-1-3.patch > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #29: > new file mode 100644 > > WARNING: From:/Signed-off-by: email address mismatch: 'From: Medad CChien <medadyoung@gmail.com>' != 'Signed-off-by: Medad CChien <ctcchien@nuvoton.com>' > > total: 0 errors, 2 warnings, 62 lines checked > > Before sending, you should really run checkpatch on your patches. > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette thanks B.R. Medad
On Fri, May 20, 2022 at 10:31:05AM +0800, Medad Young wrote: > for the second warning, I did upadate my .git/config according to your > advise. but I thought I met orthe problem, I will try to fix it You need to do "git commit --amend" on the patch so that it updates the author. > for the first warning, did I really need to fix it? Yes, you need to fix both. Again, before you send, run checkpatch on your patches, one by one.
Dear Borislav, thanks for your comments. Borislav Petkov <bp@alien8.de> 於 2022年5月20日 週五 下午8:09寫道： > > On Fri, May 20, 2022 at 10:31:05AM +0800, Medad Young wrote: > > for the second warning, I did upadate my .git/config according to your > > advise. but I thought I met orthe problem, I will try to fix it > > You need to do "git commit --amend" on the patch so that it updates the > author. I did do "git commit --amend", I beleve the issue is about the mail server I used, I use gmail to send the mail due to the mail server of my company does't support smtp so now I should sign the commit with my gmail account. > > > for the first warning, did I really need to fix it? > > Yes, you need to fix both. > > Again, before you send, run checkpatch on your patches, one by one. OK > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette B.R. Medad
On Mon, May 23, 2022 at 05:06:07PM +0800, Medad Young wrote: > I did do "git commit --amend", > I beleve the issue is about the mail server I used, > I use gmail to send the mail due to the mail server of my company > does't support smtp > so now I should sign the commit with my gmail account. No, you should supply --author too - I had forgotten about that. commit 0876b99e4aa2bf7113070c9c0f5d0ade7ad91697 (HEAD -> refs/heads/test) Author: Medad CChien <medadyoung@gmail.com> Date: Tue May 10 11:10:54 2022 +0800 ARM: dts: nuvoton: Add memory controller node ECC must be configured in the BootBlock header. Then, you can read error counts via the EDAC kernel framework. Signed-off-by: Medad CChien <ctcchien@nuvoton.com> $ git commit --amend --author="Medad CChien <ctcchien@nuvoton.com>" [test 5d6cd85171d1] ARM: dts: nuvoton: Add memory controller node Author: Medad CChien <ctcchien@nuvoton.com> Date: Tue May 10 11:10:54 2022 +0800 1 file changed, 7 insertions(+) $ git log -p -1 commit 5d6cd85171d14e67840e672e2f96a16981243424 (HEAD -> refs/heads/test) Author: Medad CChien <ctcchien@nuvoton.com> Date: Tue May 10 11:10:54 2022 +0800 ARM: dts: nuvoton: Add memory controller node ECC must be configured in the BootBlock header. Then, you can read error counts via the EDAC kernel framework. Signed-off-by: Medad CChien <ctcchien@nuvoton.com> $ git format-patch -1 -o /tmp/ /tmp/0001-ARM-dts-nuvoton-Add-memory-controller-node.patch $ head /tmp/0001-ARM-dts-nuvoton-Add-memory-controller-node.patch From 5d6cd85171d14e67840e672e2f96a16981243424 Mon Sep 17 00:00:00 2001 From: Medad CChien <ctcchien@nuvoton.com> ^^^^^^^^^^^^^^^^^^^^^^ Don't hesitate to look at the manpages if a tool doesn't do what you expect it to do. HTH.
Dear Borislav, thanks for your help. Borislav Petkov <bp@alien8.de> 於 2022年5月23日 週一 下午5:34寫道： > > On Mon, May 23, 2022 at 05:06:07PM +0800, Medad Young wrote: > > I did do "git commit --amend", > > I beleve the issue is about the mail server I used, > > I use gmail to send the mail due to the mail server of my company > > does't support smtp > > so now I should sign the commit with my gmail account. > > No, you should supply --author too - I had forgotten about that. > > commit 0876b99e4aa2bf7113070c9c0f5d0ade7ad91697 (HEAD -> refs/heads/test) > Author: Medad CChien <medadyoung@gmail.com> > Date: Tue May 10 11:10:54 2022 +0800 > > ARM: dts: nuvoton: Add memory controller node > > ECC must be configured in the BootBlock header. > Then, you can read error counts via the EDAC kernel framework. > > Signed-off-by: Medad CChien <ctcchien@nuvoton.com> > > $ git commit --amend --author="Medad CChien <ctcchien@nuvoton.com>" > [test 5d6cd85171d1] ARM: dts: nuvoton: Add memory controller node > Author: Medad CChien <ctcchien@nuvoton.com> > Date: Tue May 10 11:10:54 2022 +0800 > 1 file changed, 7 insertions(+) > $ git log -p -1 > commit 5d6cd85171d14e67840e672e2f96a16981243424 (HEAD -> refs/heads/test) > Author: Medad CChien <ctcchien@nuvoton.com> > Date: Tue May 10 11:10:54 2022 +0800 > > ARM: dts: nuvoton: Add memory controller node > > ECC must be configured in the BootBlock header. > Then, you can read error counts via the EDAC kernel framework. > > Signed-off-by: Medad CChien <ctcchien@nuvoton.com> > > $ git format-patch -1 -o /tmp/ > /tmp/0001-ARM-dts-nuvoton-Add-memory-controller-node.patch > > $ head /tmp/0001-ARM-dts-nuvoton-Add-memory-controller-node.patch > From 5d6cd85171d14e67840e672e2f96a16981243424 Mon Sep 17 00:00:00 2001 > From: Medad CChien <ctcchien@nuvoton.com> > ^^^^^^^^^^^^^^^^^^^^^^ > > > Don't hesitate to look at the manpages if a tool doesn't do what you > expect it to do. OK, I will try to supply --author with my original mail server > > HTH. > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette B.R. Medad
diff --git a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi index 3696980a3da1..ba542b26941e 100644 --- a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi +++ b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi @@ -106,6 +106,13 @@ interrupt-parent = <&gic>; ranges; + mc: memory-controller@f0824000 { + compatible = "nuvoton,npcm750-memory-controller"; + reg = <0x0 0xf0824000 0x0 0x1000>; + interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + }; + rstc: rstc@f0801000 { compatible = "nuvoton,npcm750-reset"; reg = <0xf0801000 0x70>;
ECC must be configured in the BootBlock header. Then, you can read error counts via the EDAC kernel framework. Signed-off-by: Medad CChien <ctcchien@nuvoton.com> --- arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)