| Message ID | 20220510200543.13482-1-laurent.pinchart@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: soc: imx8mp-media-blk-ctrl: Fix DT example | expand |
On 2022/5/11 4:05, Laurent Pinchart wrote: > The DT example incorrectly names the ISP power domain "isp1" instead of > "isp". This causes a validation failure: > > Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.example.dtb: blk-ctl@32ec0000: power-domain-names:7: 'isp' was expected > From schema: Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml > > Fix it. > > Fixes: 584d6dd668e2 ("dt-bindings: soc: Add i.MX8MP media block control DT bindings") > Reported-by: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Peng Fan <peng.fan@nxp.com> > --- > Shawn, this fixes an issue in linux-next, could you please apply the > patch to your imx/bindings branch for v5.19 ? > --- > .../devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml > index 21d3ee486295..b246d8386ba4 100644 > --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml > @@ -88,7 +88,7 @@ examples: > <&mediamix_pd>, <&ispdwp_pd>, <&ispdwp_pd>, > <&mipi_phy2_pd>; > power-domain-names = "bus", "mipi-dsi1", "mipi-csi1", "lcdif1", "isi", > - "mipi-csi2", "lcdif2", "isp1", "dwe", "mipi-dsi2"; > + "mipi-csi2", "lcdif2", "isp", "dwe", "mipi-dsi2"; > clocks = <&clk IMX8MP_CLK_MEDIA_APB_ROOT>, > <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>, > <&clk IMX8MP_CLK_MEDIA_CAM1_PIX_ROOT>, >
On 10/05/2022 22:05, Laurent Pinchart wrote: > The DT example incorrectly names the ISP power domain "isp1" instead of > "isp". This causes a validation failure: > > Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.example.dtb: blk-ctl@32ec0000: power-domain-names:7: 'isp' was expected > From schema: Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml > > Fix it. > > Fixes: 584d6dd668e2 ("dt-bindings: soc: Add i.MX8MP media block control DT bindings") > Reported-by: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi Laurent, On Tue, May 10, 2022 at 11:05:43PM +0300, Laurent Pinchart wrote: > The DT example incorrectly names the ISP power domain "isp1" instead of > "isp". This causes a validation failure: > > Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.example.dtb: blk-ctl@32ec0000: power-domain-names:7: 'isp' was expected > From schema: Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml > > Fix it. > > Fixes: 584d6dd668e2 ("dt-bindings: soc: Add i.MX8MP media block control DT bindings") > Reported-by: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> > --- > Shawn, this fixes an issue in linux-next, could you please apply the > patch to your imx/bindings branch for v5.19 ? > --- > .../devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml > index 21d3ee486295..b246d8386ba4 100644 > --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml > @@ -88,7 +88,7 @@ examples: > <&mediamix_pd>, <&ispdwp_pd>, <&ispdwp_pd>, > <&mipi_phy2_pd>; > power-domain-names = "bus", "mipi-dsi1", "mipi-csi1", "lcdif1", "isi", > - "mipi-csi2", "lcdif2", "isp1", "dwe", "mipi-dsi2"; > + "mipi-csi2", "lcdif2", "isp", "dwe", "mipi-dsi2"; > clocks = <&clk IMX8MP_CLK_MEDIA_APB_ROOT>, > <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>, > <&clk IMX8MP_CLK_MEDIA_CAM1_PIX_ROOT>,
On Tue, 10 May 2022 23:05:43 +0300, Laurent Pinchart wrote: > The DT example incorrectly names the ISP power domain "isp1" instead of > "isp". This causes a validation failure: > > Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.example.dtb: blk-ctl@32ec0000: power-domain-names:7: 'isp' was expected > From schema: Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml > > Fix it. > > Fixes: 584d6dd668e2 ("dt-bindings: soc: Add i.MX8MP media block control DT bindings") > Reported-by: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > Shawn, this fixes an issue in linux-next, could you please apply the > patch to your imx/bindings branch for v5.19 ? > --- > .../devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Rob Herring <robh@kernel.org>
On Tue, May 10, 2022 at 3:05 PM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > The DT example incorrectly names the ISP power domain "isp1" instead of > "isp". This causes a validation failure: > > Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.example.dtb: blk-ctl@32ec0000: power-domain-names:7: 'isp' was expected > From schema: Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml > > Fix it. > > Fixes: 584d6dd668e2 ("dt-bindings: soc: Add i.MX8MP media block control DT bindings") > Reported-by: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > Shawn, this fixes an issue in linux-next, could you please apply the > patch to your imx/bindings branch for v5.19 ? Ping! Still failing in linux-next. Rob > --- > .../devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml > index 21d3ee486295..b246d8386ba4 100644 > --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml > @@ -88,7 +88,7 @@ examples: > <&mediamix_pd>, <&ispdwp_pd>, <&ispdwp_pd>, > <&mipi_phy2_pd>; > power-domain-names = "bus", "mipi-dsi1", "mipi-csi1", "lcdif1", "isi", > - "mipi-csi2", "lcdif2", "isp1", "dwe", "mipi-dsi2"; > + "mipi-csi2", "lcdif2", "isp", "dwe", "mipi-dsi2"; > clocks = <&clk IMX8MP_CLK_MEDIA_APB_ROOT>, > <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>, > <&clk IMX8MP_CLK_MEDIA_CAM1_PIX_ROOT>, > -- > Regards, > > Laurent Pinchart >
On Tue, 10 May 2022 23:05:43 +0300, Laurent Pinchart wrote: > The DT example incorrectly names the ISP power domain "isp1" instead of > "isp". This causes a validation failure: > > Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.example.dtb: blk-ctl@32ec0000: power-domain-names:7: 'isp' was expected > From schema: Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml > > Fix it. > > Fixes: 584d6dd668e2 ("dt-bindings: soc: Add i.MX8MP media block control DT bindings") > Reported-by: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > Shawn, this fixes an issue in linux-next, could you please apply the > patch to your imx/bindings branch for v5.19 ? > --- > .../devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Now failing in Linus' tree and linux-next and no response, so I've applied. Rob
On Tue, May 31, 2022 at 08:56:39AM -0500, Rob Herring wrote: > On Tue, 10 May 2022 23:05:43 +0300, Laurent Pinchart wrote: > > The DT example incorrectly names the ISP power domain "isp1" instead of > > "isp". This causes a validation failure: > > > > Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.example.dtb: blk-ctl@32ec0000: power-domain-names:7: 'isp' was expected > > From schema: Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml > > > > Fix it. > > > > Fixes: 584d6dd668e2 ("dt-bindings: soc: Add i.MX8MP media block control DT bindings") > > Reported-by: Rob Herring <robh+dt@kernel.org> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > Shawn, this fixes an issue in linux-next, could you please apply the > > patch to your imx/bindings branch for v5.19 ? > > --- > > .../devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Now failing in Linus' tree and linux-next and no response, so I've > applied. Thanks Rob.
diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml index 21d3ee486295..b246d8386ba4 100644 --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml @@ -88,7 +88,7 @@ examples: <&mediamix_pd>, <&ispdwp_pd>, <&ispdwp_pd>, <&mipi_phy2_pd>; power-domain-names = "bus", "mipi-dsi1", "mipi-csi1", "lcdif1", "isi", - "mipi-csi2", "lcdif2", "isp1", "dwe", "mipi-dsi2"; + "mipi-csi2", "lcdif2", "isp", "dwe", "mipi-dsi2"; clocks = <&clk IMX8MP_CLK_MEDIA_APB_ROOT>, <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>, <&clk IMX8MP_CLK_MEDIA_CAM1_PIX_ROOT>,
The DT example incorrectly names the ISP power domain "isp1" instead of "isp". This causes a validation failure: Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.example.dtb: blk-ctl@32ec0000: power-domain-names:7: 'isp' was expected From schema: Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml Fix it. Fixes: 584d6dd668e2 ("dt-bindings: soc: Add i.MX8MP media block control DT bindings") Reported-by: Rob Herring <robh+dt@kernel.org> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- Shawn, this fixes an issue in linux-next, could you please apply the patch to your imx/bindings branch for v5.19 ? --- .../devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)