| Message ID | 20220523123157.v2.1.I47ec78581907f7ef024f10bc085f970abf01ec11@changeid (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2,1/2] arm64: dts: qcom: sc7280: herobrine: Don't disable the keyboard backlight node | expand |
Hi, On Mon, May 23, 2022 at 12:32 PM Matthias Kaehlcke <mka@chromium.org> wrote: > > On herobrine boards the keyboard backlight is controlled through the > PWM LED driver. Currently both the PWM LED node and the node for the > keyboard backlight are disabled in sc7280-herobrine.dtsi, which > requires boards with a backlit keyboard to enable both nodes. There > are no other PWM LEDs on herobrine boards besides the keyboard > backlight, delete the 'disabled' status from the keyboard backlight > node, with that boards only have to enable the 'pwmleds' node for > keyboard backlight support. > > Also add a label to the 'pwmleds' node to allow board files to refer to > it with a phandle. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > --- > > (no changes since v1) > > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Douglas Anderson <dianders@chromium.org>
On Mon, 23 May 2022 12:32:03 -0700, Matthias Kaehlcke wrote: > On herobrine boards the keyboard backlight is controlled through the > PWM LED driver. Currently both the PWM LED node and the node for the > keyboard backlight are disabled in sc7280-herobrine.dtsi, which > requires boards with a backlit keyboard to enable both nodes. There > are no other PWM LEDs on herobrine boards besides the keyboard > backlight, delete the 'disabled' status from the keyboard backlight > node, with that boards only have to enable the 'pwmleds' node for > keyboard backlight support. > > [...] Applied, thanks! [1/2] arm64: dts: qcom: sc7280: herobrine: Don't disable the keyboard backlight node commit: 426e81c7e6250723eb37c8a05187e28eef17484f [2/2] arm64: dts: qcom: sc7280: Enable keyboard backlight for villager commit: 1a22eff4b429f9da9e4259d019cc809ba7b4593c Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi index 9cb1bc8ed6b5..55b513912e79 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi @@ -295,11 +295,10 @@ pp1200_wf_cam: pp1200-wf-cam-regulator { /* BOARD-SPECIFIC TOP LEVEL NODES */ - pwmleds { + pwmleds: pwmleds { compatible = "pwm-leds"; status = "disabled"; keyboard_backlight: keyboard-backlight { - status = "disabled"; label = "cros_ec::kbd_backlight"; pwms = <&cros_ec_pwm 0>; max-brightness = <1023>;
On herobrine boards the keyboard backlight is controlled through the PWM LED driver. Currently both the PWM LED node and the node for the keyboard backlight are disabled in sc7280-herobrine.dtsi, which requires boards with a backlit keyboard to enable both nodes. There are no other PWM LEDs on herobrine boards besides the keyboard backlight, delete the 'disabled' status from the keyboard backlight node, with that boards only have to enable the 'pwmleds' node for keyboard backlight support. Also add a label to the 'pwmleds' node to allow board files to refer to it with a phandle. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> --- (no changes since v1) arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)