| Message ID | 20220523143255.4376-1-linmq006@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mtd: maps: Fix refcount leak in ap_flash_init | expand |
On Mon, May 23, 2022 at 4:33 PM Miaoqian Lin <linmq006@gmail.com> wrote: > of_find_matching_node() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > Fixes: b0afd44bc192 ("mtd: physmap_of: add a hook for Versatile write protection") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Mon, 2022-05-23 at 14:32:55 UTC, Miaoqian Lin wrote: > of_find_matching_node() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > Fixes: b0afd44bc192 ("mtd: physmap_of: add a hook for Versatile write protection") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks. Miquel
diff --git a/drivers/mtd/maps/physmap-versatile.c b/drivers/mtd/maps/physmap-versatile.c index ad7cd9cfaee0..6ba6a1dd127c 100644 --- a/drivers/mtd/maps/physmap-versatile.c +++ b/drivers/mtd/maps/physmap-versatile.c @@ -93,6 +93,7 @@ static int ap_flash_init(struct platform_device *pdev) return -ENODEV; } ebi_base = of_iomap(ebi, 0); + of_node_put(ebi); if (!ebi_base) return -ENODEV;
of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: b0afd44bc192 ("mtd: physmap_of: add a hook for Versatile write protection") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- drivers/mtd/maps/physmap-versatile.c | 1 + 1 file changed, 1 insertion(+)