| Message ID | 20220524103534.2520439-1-vkoul@kernel.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | drm/msm/disp/dpu1: remove supoerflous init | expand |
On Tue, 24 May 2022 at 13:35, Vinod Koul <vkoul@kernel.org> wrote: > > Commit 58dca9810749 ("drm/msm/disp/dpu1: Add support for DSC in > encoder") added dsc_common_mode variable which was set to zero but then > again programmed, so drop the supoerflous init. > > Fixes: 58dca9810749 ("drm/msm/disp/dpu1: Add support for DSC in encoder") > Reported-by: kernel test robot <yujie.liu@intel.com> > Signed-off-by: Vinod Koul <vkoul@kernel.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > index 51f24ba68375..388125c8bda1 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > @@ -1798,7 +1798,6 @@ static void dpu_encoder_prep_dsc(struct dpu_encoder_virt *dpu_enc, > } > } > > - dsc_common_mode = 0; > pic_width = dsc->drm->pic_width; > > dsc_common_mode = DSC_MODE_MULTIPLEX | DSC_MODE_SPLIT_PANEL; > -- > 2.34.1 >
>-----Original Message----- >From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of >Vinod Koul >Sent: Tuesday, May 24, 2022 6:36 AM >To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >Cc: Liu, Yujie <yujie.liu@intel.com>; linux-arm-msm@vger.kernel.org; Abhinav >Kumar <quic_abhinavk@quicinc.com>; dri-devel@lists.freedesktop.org; Bjorn >Andersson <bjorn.andersson@linaro.org>; Vinod Koul <vkoul@kernel.org>; >freedreno@lists.freedesktop.org >Subject: [PATCH] drm/msm/disp/dpu1: remove supoerflous init s/supoerflous/superfluous/ m >Commit 58dca9810749 ("drm/msm/disp/dpu1: Add support for DSC in >encoder") added dsc_common_mode variable which was set to zero but then >again programmed, so drop the supoerflous init. > >Fixes: 58dca9810749 ("drm/msm/disp/dpu1: Add support for DSC in encoder") >Reported-by: kernel test robot <yujie.liu@intel.com> >Signed-off-by: Vinod Koul <vkoul@kernel.org> >--- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c >b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c >index 51f24ba68375..388125c8bda1 100644 >--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c >+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c >@@ -1798,7 +1798,6 @@ static void dpu_encoder_prep_dsc(struct >dpu_encoder_virt *dpu_enc, > } > } > >- dsc_common_mode = 0; > pic_width = dsc->drm->pic_width; > > dsc_common_mode = DSC_MODE_MULTIPLEX | >DSC_MODE_SPLIT_PANEL; >-- >2.34.1
On 5/24/2022 3:35 AM, Vinod Koul wrote: > Commit 58dca9810749 ("drm/msm/disp/dpu1: Add support for DSC in > encoder") added dsc_common_mode variable which was set to zero but then > again programmed, so drop the supoerflous init. Both in the subject line and here, typo supoerflous ---> superfluous Other than that, Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > > Fixes: 58dca9810749 ("drm/msm/disp/dpu1: Add support for DSC in encoder") > Reported-by: kernel test robot <yujie.liu@intel.com> > Signed-off-by: Vinod Koul <vkoul@kernel.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > index 51f24ba68375..388125c8bda1 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > @@ -1798,7 +1798,6 @@ static void dpu_encoder_prep_dsc(struct dpu_encoder_virt *dpu_enc, > } > } > > - dsc_common_mode = 0; > pic_width = dsc->drm->pic_width; > > dsc_common_mode = DSC_MODE_MULTIPLEX | DSC_MODE_SPLIT_PANEL;
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c index 51f24ba68375..388125c8bda1 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c @@ -1798,7 +1798,6 @@ static void dpu_encoder_prep_dsc(struct dpu_encoder_virt *dpu_enc, } } - dsc_common_mode = 0; pic_width = dsc->drm->pic_width; dsc_common_mode = DSC_MODE_MULTIPLEX | DSC_MODE_SPLIT_PANEL;
Commit 58dca9810749 ("drm/msm/disp/dpu1: Add support for DSC in encoder") added dsc_common_mode variable which was set to zero but then again programmed, so drop the supoerflous init. Fixes: 58dca9810749 ("drm/msm/disp/dpu1: Add support for DSC in encoder") Reported-by: kernel test robot <yujie.liu@intel.com> Signed-off-by: Vinod Koul <vkoul@kernel.org> --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 1 - 1 file changed, 1 deletion(-)