| Message ID | 20220504163835.40130-1-bryan.odonoghue@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | clk: qcom: msm8939: DDR and system_mm clock fixes | expand |
On 04/05/2022 17:38, Bryan O'Donoghue wrote: > There a few omissions/bugs I found recently which are worth fixing up. > The BIMC_DDR_CLK_SRC command RCGR points to a value off in the wilderness > and should be fixed. > > More interestingly a number of Multi-media peripherals are defined as > pointing at the system NOC for their clocks, instead of at the System NOC > MM. > > This turns out to be not much of a problem so far because we currently > aren't trying to set any of these clocks and the MM_SNOC clocks are derived > from the same source as regular SNOC clocks, except they can vote for > higher rates. > > Bryan O'Donoghue (4): > clk: qcom: Add missing SYSTEM_MM_NOC_BFDCD_CLK_SRC > clk: qcom: add gcc-msm8939: Fix bimc_ddr_clk_src rcgr base address > clk: qcom: add gcc-msm8939: Add missing system_mm_noc_bfdcd_clk_src > clk: qcom: add gcc-msm8939: Point MM peripherals to system_mm_noc > clock > > drivers/clk/qcom/gcc-msm8939.c | 31 ++++++++++++++------ > include/dt-bindings/clock/qcom,gcc-msm8939.h | 1 + > 2 files changed, 23 insertions(+), 9 deletions(-) > ping !
On Wed, 4 May 2022 17:38:31 +0100, Bryan O'Donoghue wrote: > There a few omissions/bugs I found recently which are worth fixing up. > The BIMC_DDR_CLK_SRC command RCGR points to a value off in the wilderness > and should be fixed. > > More interestingly a number of Multi-media peripherals are defined as > pointing at the system NOC for their clocks, instead of at the System NOC > MM. > > [...] Applied, thanks! [1/4] clk: qcom: Add missing SYSTEM_MM_NOC_BFDCD_CLK_SRC commit: 07e7fcf1714c5f9930ad27613fea940aedba68da [2/4] clk: qcom: add gcc-msm8939: Fix bimc_ddr_clk_src rcgr base address commit: 63d42708320d6d2ca9ed505123d50ff4a542c36f [3/4] clk: qcom: add gcc-msm8939: Add missing system_mm_noc_bfdcd_clk_src commit: dd363e2f7196278e7a30f509a0e8a841cb763b14 [4/4] clk: qcom: add gcc-msm8939: Point MM peripherals to system_mm_noc clock commit: 05eed0990927aa9634682fec58660e30f7b7ae30 Best regards,
There a few omissions/bugs I found recently which are worth fixing up. The BIMC_DDR_CLK_SRC command RCGR points to a value off in the wilderness and should be fixed. More interestingly a number of Multi-media peripherals are defined as pointing at the system NOC for their clocks, instead of at the System NOC MM. This turns out to be not much of a problem so far because we currently aren't trying to set any of these clocks and the MM_SNOC clocks are derived from the same source as regular SNOC clocks, except they can vote for higher rates. Bryan O'Donoghue (4): clk: qcom: Add missing SYSTEM_MM_NOC_BFDCD_CLK_SRC clk: qcom: add gcc-msm8939: Fix bimc_ddr_clk_src rcgr base address clk: qcom: add gcc-msm8939: Add missing system_mm_noc_bfdcd_clk_src clk: qcom: add gcc-msm8939: Point MM peripherals to system_mm_noc clock drivers/clk/qcom/gcc-msm8939.c | 31 ++++++++++++++------ include/dt-bindings/clock/qcom,gcc-msm8939.h | 1 + 2 files changed, 23 insertions(+), 9 deletions(-)