| Message ID | 20220525014308.1853576-2-judyhsiao@chromium.org (mailing list archive) |
|---|---|
| State | Queued |
| Headers | show |
| Series | Add dtsi for sc7280 herobrine boards that using rt5682 codec | expand |
On Wed, May 25, 2022 at 01:43:06AM +0000, Judy Hsiao wrote: > 1. Add drive strength property for mi2s1 on sc7280 based platforms. > 2. Disable the pull-up for mi2s1 lines. > > Signed-off-by: Judy Hsiao <judyhsiao@chromium.org> You already had my 'Reviewed-by' tag for version 1 and 2, please make sure to include these tags when you post a new version (unless there are significant changes). That way maintainers can see that a patch has been reviewed previously, without having to go through the entire patch history, which they are unlikely to do. And your reviewer don't want to be burdened either with having to send the tags over and over again :) Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Hi, On Tue, May 24, 2022 at 6:43 PM Judy Hsiao <judyhsiao@chromium.org> wrote: > > 1. Add drive strength property for mi2s1 on sc7280 based platforms. > 2. Disable the pull-up for mi2s1 lines. > > Signed-off-by: Judy Hsiao <judyhsiao@chromium.org> > --- > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) Reviewed-by: Douglas Anderson <dianders@chromium.org>
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi index 9cb1bc8ed6b5..f3044b39ba66 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi @@ -612,6 +612,21 @@ &dp_hot_plug_det { bias-disable; }; +&mi2s1_data0 { + drive-strength = <6>; + bias-disable; +}; + +&mi2s1_sclk { + drive-strength = <6>; + bias-disable; +}; + +&mi2s1_ws { + drive-strength = <6>; + bias-disable; +}; + &pcie1_clkreq_n { bias-pull-up; drive-strength = <2>;
1. Add drive strength property for mi2s1 on sc7280 based platforms. 2. Disable the pull-up for mi2s1 lines. Signed-off-by: Judy Hsiao <judyhsiao@chromium.org> --- arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 15 +++++++++++++++ 1 file changed, 15 insertions(+)