| Message ID | 20220523175640.60155-1-quic_jaehyoo@quicinc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] ARM: dts: aspeed: nuvia: rename vendor nuvia to qcom | expand |
On 23/05/2022 19:56, Jae Hyun Yoo wrote: > Nuvia has been acquired by Qualcomm and the vendor name 'nuvia' will > not be used anymore so rename aspeed-bmc-nuvia-dc-scm.dts to > aspeed-bmc-qcom-dc-scm-v1.dts and change 'nuvia' to 'qcom' as its vendor > name in the file. And all users of this DTB now have to update their bootloaders, scripts, installation methods. We did not rename FSL or Marvell boards, so neither should be renamed this one. > > Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@quicinc.com> > --- > arch/arm/boot/dts/Makefile | 2 +- > ...eed-bmc-nuvia-dc-scm.dts => aspeed-bmc-qcom-dc-scm-v1.dts} | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > rename arch/arm/boot/dts/{aspeed-bmc-nuvia-dc-scm.dts => aspeed-bmc-qcom-dc-scm-v1.dts} (97%) > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 03f5b3a15415..2a3c95387613 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -1584,7 +1584,6 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ > aspeed-bmc-lenovo-hr630.dtb \ > aspeed-bmc-lenovo-hr855xg2.dtb \ > aspeed-bmc-microsoft-olympus.dtb \ > - aspeed-bmc-nuvia-dc-scm.dtb \ > aspeed-bmc-opp-lanyang.dtb \ > aspeed-bmc-opp-mihawk.dtb \ > aspeed-bmc-opp-mowgli.dtb \ > @@ -1597,6 +1596,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ > aspeed-bmc-opp-witherspoon.dtb \ > aspeed-bmc-opp-zaius.dtb \ > aspeed-bmc-portwell-neptune.dtb \ > + aspeed-bmc-qcom-dc-scm-v1.dtb \ > aspeed-bmc-quanta-q71l.dtb \ > aspeed-bmc-quanta-s6q.dtb \ > aspeed-bmc-supermicro-x11spi.dtb \ > diff --git a/arch/arm/boot/dts/aspeed-bmc-nuvia-dc-scm.dts b/arch/arm/boot/dts/aspeed-bmc-qcom-dc-scm-v1.dts > similarity index 97% > rename from arch/arm/boot/dts/aspeed-bmc-nuvia-dc-scm.dts > rename to arch/arm/boot/dts/aspeed-bmc-qcom-dc-scm-v1.dts > index f4a97cfb0f23..259ef3f54c5c 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-nuvia-dc-scm.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-qcom-dc-scm-v1.dts > @@ -6,8 +6,8 @@ > #include "aspeed-g6.dtsi" > > / { > - model = "Nuvia DC-SCM BMC"; > - compatible = "nuvia,dc-scm-bmc", "aspeed,ast2600"; > + model = "Qualcomm DC-SCM V1 BMC"; > + compatible = "qcom,dc-scm-v1-bmc", "aspeed,ast2600"; You need also change bindings. Best regards, Krzysztof
Hi Krzysztof, On 5/24/2022 2:53 AM, Krzysztof Kozlowski wrote: > On 23/05/2022 19:56, Jae Hyun Yoo wrote: >> Nuvia has been acquired by Qualcomm and the vendor name 'nuvia' will >> not be used anymore so rename aspeed-bmc-nuvia-dc-scm.dts to >> aspeed-bmc-qcom-dc-scm-v1.dts and change 'nuvia' to 'qcom' as its vendor >> name in the file. > > And all users of this DTB now have to update their bootloaders, scripts, > installation methods. We did not rename FSL or Marvell boards, so > neither should be renamed this one. Yeah, I know that we don't rename dts but the previous version of this change was picked recently in the middle of code review https://lore.kernel.org/all/979a5c87-a7ea-a1f0-e42e-29043df6b348@quicinc.com/ and the v3 was pulled recently so it's still in the -next queue so I believe it has a chance to be renamed since no one is using the DTB yet. >> >> Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@quicinc.com> >> --- >> arch/arm/boot/dts/Makefile | 2 +- >> ...eed-bmc-nuvia-dc-scm.dts => aspeed-bmc-qcom-dc-scm-v1.dts} | 4 ++-- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> rename arch/arm/boot/dts/{aspeed-bmc-nuvia-dc-scm.dts => aspeed-bmc-qcom-dc-scm-v1.dts} (97%) >> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >> index 03f5b3a15415..2a3c95387613 100644 >> --- a/arch/arm/boot/dts/Makefile >> +++ b/arch/arm/boot/dts/Makefile >> @@ -1584,7 +1584,6 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ >> aspeed-bmc-lenovo-hr630.dtb \ >> aspeed-bmc-lenovo-hr855xg2.dtb \ >> aspeed-bmc-microsoft-olympus.dtb \ >> - aspeed-bmc-nuvia-dc-scm.dtb \ >> aspeed-bmc-opp-lanyang.dtb \ >> aspeed-bmc-opp-mihawk.dtb \ >> aspeed-bmc-opp-mowgli.dtb \ >> @@ -1597,6 +1596,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ >> aspeed-bmc-opp-witherspoon.dtb \ >> aspeed-bmc-opp-zaius.dtb \ >> aspeed-bmc-portwell-neptune.dtb \ >> + aspeed-bmc-qcom-dc-scm-v1.dtb \ >> aspeed-bmc-quanta-q71l.dtb \ >> aspeed-bmc-quanta-s6q.dtb \ >> aspeed-bmc-supermicro-x11spi.dtb \ >> diff --git a/arch/arm/boot/dts/aspeed-bmc-nuvia-dc-scm.dts b/arch/arm/boot/dts/aspeed-bmc-qcom-dc-scm-v1.dts >> similarity index 97% >> rename from arch/arm/boot/dts/aspeed-bmc-nuvia-dc-scm.dts >> rename to arch/arm/boot/dts/aspeed-bmc-qcom-dc-scm-v1.dts >> index f4a97cfb0f23..259ef3f54c5c 100644 >> --- a/arch/arm/boot/dts/aspeed-bmc-nuvia-dc-scm.dts >> +++ b/arch/arm/boot/dts/aspeed-bmc-qcom-dc-scm-v1.dts >> @@ -6,8 +6,8 @@ >> #include "aspeed-g6.dtsi" >> >> / { >> - model = "Nuvia DC-SCM BMC"; >> - compatible = "nuvia,dc-scm-bmc", "aspeed,ast2600"; >> + model = "Qualcomm DC-SCM V1 BMC"; >> + compatible = "qcom,dc-scm-v1-bmc", "aspeed,ast2600"; > > > You need also change bindings. I didn't see any case of changing bindings for adding a new Aspped BMC dts. Thanks, Jae > > Best regards, > Krzysztof
On Tue, May 24, 2022 at 11:53:17AM +0200, Krzysztof Kozlowski wrote: > On 23/05/2022 19:56, Jae Hyun Yoo wrote: > > Nuvia has been acquired by Qualcomm and the vendor name 'nuvia' will > > not be used anymore so rename aspeed-bmc-nuvia-dc-scm.dts to > > aspeed-bmc-qcom-dc-scm-v1.dts and change 'nuvia' to 'qcom' as its vendor > > name in the file. > > And all users of this DTB now have to update their bootloaders, scripts, > installation methods. We did not rename FSL or Marvell boards, so > neither should be renamed this one. > This board does not exist to the public yet! That makes all users limited to those on Cc: with quicinc emails! Graeme > > > > Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@quicinc.com> > > --- > > arch/arm/boot/dts/Makefile | 2 +- > > ...eed-bmc-nuvia-dc-scm.dts => aspeed-bmc-qcom-dc-scm-v1.dts} | 4 ++-- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > rename arch/arm/boot/dts/{aspeed-bmc-nuvia-dc-scm.dts => aspeed-bmc-qcom-dc-scm-v1.dts} (97%) > > > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > > index 03f5b3a15415..2a3c95387613 100644 > > --- a/arch/arm/boot/dts/Makefile > > +++ b/arch/arm/boot/dts/Makefile > > @@ -1584,7 +1584,6 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ > > aspeed-bmc-lenovo-hr630.dtb \ > > aspeed-bmc-lenovo-hr855xg2.dtb \ > > aspeed-bmc-microsoft-olympus.dtb \ > > - aspeed-bmc-nuvia-dc-scm.dtb \ > > aspeed-bmc-opp-lanyang.dtb \ > > aspeed-bmc-opp-mihawk.dtb \ > > aspeed-bmc-opp-mowgli.dtb \ > > @@ -1597,6 +1596,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ > > aspeed-bmc-opp-witherspoon.dtb \ > > aspeed-bmc-opp-zaius.dtb \ > > aspeed-bmc-portwell-neptune.dtb \ > > + aspeed-bmc-qcom-dc-scm-v1.dtb \ > > aspeed-bmc-quanta-q71l.dtb \ > > aspeed-bmc-quanta-s6q.dtb \ > > aspeed-bmc-supermicro-x11spi.dtb \ > > diff --git a/arch/arm/boot/dts/aspeed-bmc-nuvia-dc-scm.dts b/arch/arm/boot/dts/aspeed-bmc-qcom-dc-scm-v1.dts > > similarity index 97% > > rename from arch/arm/boot/dts/aspeed-bmc-nuvia-dc-scm.dts > > rename to arch/arm/boot/dts/aspeed-bmc-qcom-dc-scm-v1.dts > > index f4a97cfb0f23..259ef3f54c5c 100644 > > --- a/arch/arm/boot/dts/aspeed-bmc-nuvia-dc-scm.dts > > +++ b/arch/arm/boot/dts/aspeed-bmc-qcom-dc-scm-v1.dts > > @@ -6,8 +6,8 @@ > > #include "aspeed-g6.dtsi" > > > > / { > > - model = "Nuvia DC-SCM BMC"; > > - compatible = "nuvia,dc-scm-bmc", "aspeed,ast2600"; > > + model = "Qualcomm DC-SCM V1 BMC"; > > + compatible = "qcom,dc-scm-v1-bmc", "aspeed,ast2600"; > > > You need also change bindings. > > > Best regards, > Krzysztof
On 24/05/2022 13:57, Jae Hyun Yoo wrote: > Hi Krzysztof, > > On 5/24/2022 2:53 AM, Krzysztof Kozlowski wrote: >> On 23/05/2022 19:56, Jae Hyun Yoo wrote: >>> Nuvia has been acquired by Qualcomm and the vendor name 'nuvia' will >>> not be used anymore so rename aspeed-bmc-nuvia-dc-scm.dts to >>> aspeed-bmc-qcom-dc-scm-v1.dts and change 'nuvia' to 'qcom' as its vendor >>> name in the file. >> >> And all users of this DTB now have to update their bootloaders, scripts, >> installation methods. We did not rename FSL or Marvell boards, so >> neither should be renamed this one. > > Yeah, I know that we don't rename dts but the previous version of this > change was picked recently in the middle of code review > https://lore.kernel.org/all/979a5c87-a7ea-a1f0-e42e-29043df6b348@quicinc.com/ > and the v3 was pulled recently so it's still in the -next queue so > I believe it has a chance to be renamed since no one is using the DTB > yet. Ah, so it is still in next (or was before this merge window). OK, thanks for explanation. > >>> >>> Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@quicinc.com> >>> --- >>> arch/arm/boot/dts/Makefile | 2 +- >>> ...eed-bmc-nuvia-dc-scm.dts => aspeed-bmc-qcom-dc-scm-v1.dts} | 4 ++-- >>> 2 files changed, 3 insertions(+), 3 deletions(-) >>> rename arch/arm/boot/dts/{aspeed-bmc-nuvia-dc-scm.dts => aspeed-bmc-qcom-dc-scm-v1.dts} (97%) >>> >>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >>> index 03f5b3a15415..2a3c95387613 100644 >>> --- a/arch/arm/boot/dts/Makefile >>> +++ b/arch/arm/boot/dts/Makefile >>> @@ -1584,7 +1584,6 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ >>> aspeed-bmc-lenovo-hr630.dtb \ >>> aspeed-bmc-lenovo-hr855xg2.dtb \ >>> aspeed-bmc-microsoft-olympus.dtb \ >>> - aspeed-bmc-nuvia-dc-scm.dtb \ >>> aspeed-bmc-opp-lanyang.dtb \ >>> aspeed-bmc-opp-mihawk.dtb \ >>> aspeed-bmc-opp-mowgli.dtb \ >>> @@ -1597,6 +1596,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ >>> aspeed-bmc-opp-witherspoon.dtb \ >>> aspeed-bmc-opp-zaius.dtb \ >>> aspeed-bmc-portwell-neptune.dtb \ >>> + aspeed-bmc-qcom-dc-scm-v1.dtb \ >>> aspeed-bmc-quanta-q71l.dtb \ >>> aspeed-bmc-quanta-s6q.dtb \ >>> aspeed-bmc-supermicro-x11spi.dtb \ >>> diff --git a/arch/arm/boot/dts/aspeed-bmc-nuvia-dc-scm.dts b/arch/arm/boot/dts/aspeed-bmc-qcom-dc-scm-v1.dts >>> similarity index 97% >>> rename from arch/arm/boot/dts/aspeed-bmc-nuvia-dc-scm.dts >>> rename to arch/arm/boot/dts/aspeed-bmc-qcom-dc-scm-v1.dts >>> index f4a97cfb0f23..259ef3f54c5c 100644 >>> --- a/arch/arm/boot/dts/aspeed-bmc-nuvia-dc-scm.dts >>> +++ b/arch/arm/boot/dts/aspeed-bmc-qcom-dc-scm-v1.dts >>> @@ -6,8 +6,8 @@ >>> #include "aspeed-g6.dtsi" >>> >>> / { >>> - model = "Nuvia DC-SCM BMC"; >>> - compatible = "nuvia,dc-scm-bmc", "aspeed,ast2600"; >>> + model = "Qualcomm DC-SCM V1 BMC"; >>> + compatible = "qcom,dc-scm-v1-bmc", "aspeed,ast2600"; >> >> >> You need also change bindings. > > I didn't see any case of changing bindings for adding a new Aspped BMC > dts. Hmmm... Where do you document these bindings? Or does it mean Aspeed does not document it at all, every time the checkpatch complains but no one thought about it why? :) Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index 03f5b3a15415..2a3c95387613 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -1584,7 +1584,6 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ aspeed-bmc-lenovo-hr630.dtb \ aspeed-bmc-lenovo-hr855xg2.dtb \ aspeed-bmc-microsoft-olympus.dtb \ - aspeed-bmc-nuvia-dc-scm.dtb \ aspeed-bmc-opp-lanyang.dtb \ aspeed-bmc-opp-mihawk.dtb \ aspeed-bmc-opp-mowgli.dtb \ @@ -1597,6 +1596,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ aspeed-bmc-opp-witherspoon.dtb \ aspeed-bmc-opp-zaius.dtb \ aspeed-bmc-portwell-neptune.dtb \ + aspeed-bmc-qcom-dc-scm-v1.dtb \ aspeed-bmc-quanta-q71l.dtb \ aspeed-bmc-quanta-s6q.dtb \ aspeed-bmc-supermicro-x11spi.dtb \ diff --git a/arch/arm/boot/dts/aspeed-bmc-nuvia-dc-scm.dts b/arch/arm/boot/dts/aspeed-bmc-qcom-dc-scm-v1.dts similarity index 97% rename from arch/arm/boot/dts/aspeed-bmc-nuvia-dc-scm.dts rename to arch/arm/boot/dts/aspeed-bmc-qcom-dc-scm-v1.dts index f4a97cfb0f23..259ef3f54c5c 100644 --- a/arch/arm/boot/dts/aspeed-bmc-nuvia-dc-scm.dts +++ b/arch/arm/boot/dts/aspeed-bmc-qcom-dc-scm-v1.dts @@ -6,8 +6,8 @@ #include "aspeed-g6.dtsi" / { - model = "Nuvia DC-SCM BMC"; - compatible = "nuvia,dc-scm-bmc", "aspeed,ast2600"; + model = "Qualcomm DC-SCM V1 BMC"; + compatible = "qcom,dc-scm-v1-bmc", "aspeed,ast2600"; aliases { serial4 = &uart5;
Nuvia has been acquired by Qualcomm and the vendor name 'nuvia' will not be used anymore so rename aspeed-bmc-nuvia-dc-scm.dts to aspeed-bmc-qcom-dc-scm-v1.dts and change 'nuvia' to 'qcom' as its vendor name in the file. Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@quicinc.com> --- arch/arm/boot/dts/Makefile | 2 +- ...eed-bmc-nuvia-dc-scm.dts => aspeed-bmc-qcom-dc-scm-v1.dts} | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) rename arch/arm/boot/dts/{aspeed-bmc-nuvia-dc-scm.dts => aspeed-bmc-qcom-dc-scm-v1.dts} (97%)