| Message ID | 20220526204152.831948-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Commit | f028328f60bd33cbdc4b65dac2efa98ed6ca26b7 |
| Headers | show |
| Series | arm64: dts: sprd: adjust whitespace around '=' | expand |
Hi Krzysztof, On Fri, May 27, 2022 at 4:42 AM Krzysztof Kozlowski < krzysztof.kozlowski@linaro.org> wrote: > Fix whitespace coding style: use single space instead of tabs or > multiple spaces around '=' sign in property assignment. No functional > changes (same DTB). > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Thanks for your patch. We have a plan to reconstruct the device tree of SPRD into modular form. sc9836 has been in status of EOL for years and I believe no one will need to run it anymore. We want to remove it as well. But your patch is fine. It could be taken in advance. Reviewed-by: Orson Zhai <orsonzhai@gmail.com> --- > > Output compared with dtx_diff and fdtdump. > --- > arch/arm64/boot/dts/sprd/sc9836.dtsi | 10 +++++----- > arch/arm64/boot/dts/sprd/sc9863a.dtsi | 4 ++-- > arch/arm64/boot/dts/sprd/whale2.dtsi | 2 +- > 3 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/boot/dts/sprd/sc9836.dtsi > b/arch/arm64/boot/dts/sprd/sc9836.dtsi > index 231436be0e3f..8bb8a70966d2 100644 > --- a/arch/arm64/boot/dts/sprd/sc9836.dtsi > +++ b/arch/arm64/boot/dts/sprd/sc9836.dtsi > @@ -207,11 +207,11 @@ gic: interrupt-controller@12001000 { > }; > > psci { > - compatible = "arm,psci"; > - method = "smc"; > - cpu_on = <0xc4000003>; > - cpu_off = <0x84000002>; > - cpu_suspend = <0xc4000001>; > + compatible = "arm,psci"; > + method = "smc"; > + cpu_on = <0xc4000003>; > + cpu_off = <0x84000002>; > + cpu_suspend = <0xc4000001>; > }; > > timer { > diff --git a/arch/arm64/boot/dts/sprd/sc9863a.dtsi > b/arch/arm64/boot/dts/sprd/sc9863a.dtsi > index 8cf4a6575980..22d81ace740a 100644 > --- a/arch/arm64/boot/dts/sprd/sc9863a.dtsi > +++ b/arch/arm64/boot/dts/sprd/sc9863a.dtsi > @@ -552,7 +552,7 @@ ap-ahb { > ranges; > > sdio0: sdio@20300000 { > - compatible = "sprd,sdhci-r11"; > + compatible = "sprd,sdhci-r11"; > reg = <0 0x20300000 0 0x1000>; > interrupts = <GIC_SPI 57 > IRQ_TYPE_LEVEL_HIGH>; > > @@ -568,7 +568,7 @@ sdio0: sdio@20300000 { > }; > > sdio3: sdio@20600000 { > - compatible = "sprd,sdhci-r11"; > + compatible = "sprd,sdhci-r11"; > reg = <0 0x20600000 0 0x1000>; > interrupts = <GIC_SPI 60 > IRQ_TYPE_LEVEL_HIGH>; > > diff --git a/arch/arm64/boot/dts/sprd/whale2.dtsi > b/arch/arm64/boot/dts/sprd/whale2.dtsi > index 79b9591c37aa..957b2658e1fb 100644 > --- a/arch/arm64/boot/dts/sprd/whale2.dtsi > +++ b/arch/arm64/boot/dts/sprd/whale2.dtsi > @@ -132,7 +132,7 @@ ap_dma: dma-controller@20100000 { > }; > > sdio3: sdio@50430000 { > - compatible = "sprd,sdhci-r11"; > + compatible = "sprd,sdhci-r11"; > reg = <0 0x50430000 0 0x1000>; > interrupts = <GIC_SPI 41 > IRQ_TYPE_LEVEL_HIGH>; > > -- > 2.34.1 > >
On Fri, May 27, 2022 at 12:35 PM Orson Zhai <orsonzhai@gmail.com> wrote: > > Hi Krzysztof, > > On Fri, May 27, 2022 at 4:42 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: >> >> Fix whitespace coding style: use single space instead of tabs or >> multiple spaces around '=' sign in property assignment. No functional >> changes (same DTB). >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> > > Thanks for your patch. > > We have a plan to reconstruct the device tree of SPRD into modular form. > sc9836 has been in status of EOL for years and I believe no one will need to run it anymore. > We want to remove it as well. > > But your patch is fine. > It could be taken in advance. > > Reviewed-by: Orson Zhai <orsonzhai@gmail.com> Sorry, re-send for my getting failure... -Orson > >> --- >> >> Output compared with dtx_diff and fdtdump. >> --- >> arch/arm64/boot/dts/sprd/sc9836.dtsi | 10 +++++----- >> arch/arm64/boot/dts/sprd/sc9863a.dtsi | 4 ++-- >> arch/arm64/boot/dts/sprd/whale2.dtsi | 2 +- >> 3 files changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/sprd/sc9836.dtsi b/arch/arm64/boot/dts/sprd/sc9836.dtsi >> index 231436be0e3f..8bb8a70966d2 100644 >> --- a/arch/arm64/boot/dts/sprd/sc9836.dtsi >> +++ b/arch/arm64/boot/dts/sprd/sc9836.dtsi >> @@ -207,11 +207,11 @@ gic: interrupt-controller@12001000 { >> }; >> >> psci { >> - compatible = "arm,psci"; >> - method = "smc"; >> - cpu_on = <0xc4000003>; >> - cpu_off = <0x84000002>; >> - cpu_suspend = <0xc4000001>; >> + compatible = "arm,psci"; >> + method = "smc"; >> + cpu_on = <0xc4000003>; >> + cpu_off = <0x84000002>; >> + cpu_suspend = <0xc4000001>; >> }; >> >> timer { >> diff --git a/arch/arm64/boot/dts/sprd/sc9863a.dtsi b/arch/arm64/boot/dts/sprd/sc9863a.dtsi >> index 8cf4a6575980..22d81ace740a 100644 >> --- a/arch/arm64/boot/dts/sprd/sc9863a.dtsi >> +++ b/arch/arm64/boot/dts/sprd/sc9863a.dtsi >> @@ -552,7 +552,7 @@ ap-ahb { >> ranges; >> >> sdio0: sdio@20300000 { >> - compatible = "sprd,sdhci-r11"; >> + compatible = "sprd,sdhci-r11"; >> reg = <0 0x20300000 0 0x1000>; >> interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>; >> >> @@ -568,7 +568,7 @@ sdio0: sdio@20300000 { >> }; >> >> sdio3: sdio@20600000 { >> - compatible = "sprd,sdhci-r11"; >> + compatible = "sprd,sdhci-r11"; >> reg = <0 0x20600000 0 0x1000>; >> interrupts = <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>; >> >> diff --git a/arch/arm64/boot/dts/sprd/whale2.dtsi b/arch/arm64/boot/dts/sprd/whale2.dtsi >> index 79b9591c37aa..957b2658e1fb 100644 >> --- a/arch/arm64/boot/dts/sprd/whale2.dtsi >> +++ b/arch/arm64/boot/dts/sprd/whale2.dtsi >> @@ -132,7 +132,7 @@ ap_dma: dma-controller@20100000 { >> }; >> >> sdio3: sdio@50430000 { >> - compatible = "sprd,sdhci-r11"; >> + compatible = "sprd,sdhci-r11"; >> reg = <0 0x50430000 0 0x1000>; >> interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>; >> >> -- >> 2.34.1 >>
On Thu, 26 May 2022 22:41:52 +0200, Krzysztof Kozlowski wrote: > Fix whitespace coding style: use single space instead of tabs or > multiple spaces around '=' sign in property assignment. No functional > changes (same DTB). > > Applied, thanks! [1/1] arm64: dts: sprd: adjust whitespace around '=' https://git.kernel.org/krzk/linux/c/f028328f60bd33cbdc4b65dac2efa98ed6ca26b7 Best regards,
Hello: This patch was applied to soc/soc.git (for-next) by Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>: On Thu, 26 May 2022 22:41:52 +0200 you wrote: > Fix whitespace coding style: use single space instead of tabs or > multiple spaces around '=' sign in property assignment. No functional > changes (same DTB). > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > [...] Here is the summary with links: - arm64: dts: sprd: adjust whitespace around '=' https://git.kernel.org/soc/soc/c/f028328f60bd You are awesome, thank you!
diff --git a/arch/arm64/boot/dts/sprd/sc9836.dtsi b/arch/arm64/boot/dts/sprd/sc9836.dtsi index 231436be0e3f..8bb8a70966d2 100644 --- a/arch/arm64/boot/dts/sprd/sc9836.dtsi +++ b/arch/arm64/boot/dts/sprd/sc9836.dtsi @@ -207,11 +207,11 @@ gic: interrupt-controller@12001000 { }; psci { - compatible = "arm,psci"; - method = "smc"; - cpu_on = <0xc4000003>; - cpu_off = <0x84000002>; - cpu_suspend = <0xc4000001>; + compatible = "arm,psci"; + method = "smc"; + cpu_on = <0xc4000003>; + cpu_off = <0x84000002>; + cpu_suspend = <0xc4000001>; }; timer { diff --git a/arch/arm64/boot/dts/sprd/sc9863a.dtsi b/arch/arm64/boot/dts/sprd/sc9863a.dtsi index 8cf4a6575980..22d81ace740a 100644 --- a/arch/arm64/boot/dts/sprd/sc9863a.dtsi +++ b/arch/arm64/boot/dts/sprd/sc9863a.dtsi @@ -552,7 +552,7 @@ ap-ahb { ranges; sdio0: sdio@20300000 { - compatible = "sprd,sdhci-r11"; + compatible = "sprd,sdhci-r11"; reg = <0 0x20300000 0 0x1000>; interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>; @@ -568,7 +568,7 @@ sdio0: sdio@20300000 { }; sdio3: sdio@20600000 { - compatible = "sprd,sdhci-r11"; + compatible = "sprd,sdhci-r11"; reg = <0 0x20600000 0 0x1000>; interrupts = <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>; diff --git a/arch/arm64/boot/dts/sprd/whale2.dtsi b/arch/arm64/boot/dts/sprd/whale2.dtsi index 79b9591c37aa..957b2658e1fb 100644 --- a/arch/arm64/boot/dts/sprd/whale2.dtsi +++ b/arch/arm64/boot/dts/sprd/whale2.dtsi @@ -132,7 +132,7 @@ ap_dma: dma-controller@20100000 { }; sdio3: sdio@50430000 { - compatible = "sprd,sdhci-r11"; + compatible = "sprd,sdhci-r11"; reg = <0 0x50430000 0 0x1000>; interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
Fix whitespace coding style: use single space instead of tabs or multiple spaces around '=' sign in property assignment. No functional changes (same DTB). Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Output compared with dtx_diff and fdtdump. --- arch/arm64/boot/dts/sprd/sc9836.dtsi | 10 +++++----- arch/arm64/boot/dts/sprd/sc9863a.dtsi | 4 ++-- arch/arm64/boot/dts/sprd/whale2.dtsi | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-)