| Message ID | 20220524073934.319134-1-alexander.stein@ew.tq-group.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/1] soc: imx: imx8m-blk-ctrl: fix display clock for LCDIF2 power domain | expand |
Hi Alexander, On Tue, May 24, 2022 at 09:39:34AM +0200, Alexander Stein wrote: > LCDIF2 has its own display clock, use this one. Whoops, looks like I missed that :/ > > Fixes: 07614fed00e9 ("soc: imx: imx8m-blk-ctrl: Add i.MX8MP media blk-ctrl") > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> > --- > I noticed this while trying to get LVDS (on LCDIF2) working. Apparently > it is not strictly required, but better to have this right. > > drivers/soc/imx/imx8m-blk-ctrl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c > index 7f49385ed2f8..7ebc28709e94 100644 > --- a/drivers/soc/imx/imx8m-blk-ctrl.c > +++ b/drivers/soc/imx/imx8m-blk-ctrl.c > @@ -667,7 +667,7 @@ static const struct imx8m_blk_ctrl_domain_data imx8mp_media_blk_ctl_domain_data[ > }, > [IMX8MP_MEDIABLK_PD_LCDIF_2] = { > .name = "mediablk-lcdif-2", > - .clk_names = (const char *[]){ "disp1", "apb", "axi", }, > + .clk_names = (const char *[]){ "disp2", "apb", "axi", }, > .num_clks = 3, > .gpc_name = "lcdif2", > .rst_mask = BIT(11) | BIT(12) | BIT(24), > -- > 2.25.1 >
On Tue, 2022-05-24 at 09:39 +0200, Alexander Stein wrote: > LCDIF2 has its own display clock, use this one. > > Fixes: 07614fed00e9 ("soc: imx: imx8m-blk-ctrl: Add i.MX8MP media > blk-ctrl") > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> Tested along with related patches, driving InnoLux G150XNE LVDS panel attached to NXP i.MX 8M Plus EVK. Tree: https://gitlab.collabora.com/martyn/linux/-/tree/imx8mp Tested-by: Martyn Welch <martyn.welch@collabora.com> > --- > I noticed this while trying to get LVDS (on LCDIF2) working. > Apparently > it is not strictly required, but better to have this right. > > drivers/soc/imx/imx8m-blk-ctrl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c > b/drivers/soc/imx/imx8m-blk-ctrl.c > index 7f49385ed2f8..7ebc28709e94 100644 > --- a/drivers/soc/imx/imx8m-blk-ctrl.c > +++ b/drivers/soc/imx/imx8m-blk-ctrl.c > @@ -667,7 +667,7 @@ static const struct imx8m_blk_ctrl_domain_data > imx8mp_media_blk_ctl_domain_data[ > }, > [IMX8MP_MEDIABLK_PD_LCDIF_2] = { > .name = "mediablk-lcdif-2", > - .clk_names = (const char *[]){ "disp1", "apb", "axi", > }, > + .clk_names = (const char *[]){ "disp2", "apb", "axi", > }, > .num_clks = 3, > .gpc_name = "lcdif2", > .rst_mask = BIT(11) | BIT(12) | BIT(24),
On Tue, May 24, 2022 at 09:39:34AM +0200, Alexander Stein wrote: > LCDIF2 has its own display clock, use this one. > > Fixes: 07614fed00e9 ("soc: imx: imx8m-blk-ctrl: Add i.MX8MP media blk-ctrl") > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> Applied, thanks!
diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c index 7f49385ed2f8..7ebc28709e94 100644 --- a/drivers/soc/imx/imx8m-blk-ctrl.c +++ b/drivers/soc/imx/imx8m-blk-ctrl.c @@ -667,7 +667,7 @@ static const struct imx8m_blk_ctrl_domain_data imx8mp_media_blk_ctl_domain_data[ }, [IMX8MP_MEDIABLK_PD_LCDIF_2] = { .name = "mediablk-lcdif-2", - .clk_names = (const char *[]){ "disp1", "apb", "axi", }, + .clk_names = (const char *[]){ "disp2", "apb", "axi", }, .num_clks = 3, .gpc_name = "lcdif2", .rst_mask = BIT(11) | BIT(12) | BIT(24),
LCDIF2 has its own display clock, use this one. Fixes: 07614fed00e9 ("soc: imx: imx8m-blk-ctrl: Add i.MX8MP media blk-ctrl") Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- I noticed this while trying to get LVDS (on LCDIF2) working. Apparently it is not strictly required, but better to have this right. drivers/soc/imx/imx8m-blk-ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)