diff mbox series

media: renesas: rcar_drif: Drop of_match_ptr()

Message ID 20220525092054.26089-1-laurent.pinchart+renesas@ideasonboard.com (mailing list archive)
State Mainlined
Commit b73560c81f623b16db52cd546aba763c6ee99bd8
Delegated to: Kieran Bingham
Headers show
Series media: renesas: rcar_drif: Drop of_match_ptr() | expand

Commit Message

Laurent Pinchart May 25, 2022, 9:20 a.m. UTC
The device_driver structure's of_match_table field exists
unconditionally, so there's no need for of_match_ptr(). This fixes a
compiler warning when test-compiling on non-OF platforms:

drivers/media/platform/renesas/rcar_drif.c:1470:34: warning: unused variable 'rcar_drif_of_table' [-Wunused-const-variable]
static const struct of_device_id rcar_drif_of_table[] = {
                                 ^
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 drivers/media/platform/renesas/rcar_drif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 6c1c1eb8c87de221051b9198d40971640060842f

Comments

Kieran Bingham May 27, 2022, 12:03 p.m. UTC | #1
Quoting Laurent Pinchart (2022-05-25 10:20:54)
> The device_driver structure's of_match_table field exists
> unconditionally, so there's no need for of_match_ptr(). This fixes a
> compiler warning when test-compiling on non-OF platforms:
> 
> drivers/media/platform/renesas/rcar_drif.c:1470:34: warning: unused variable 'rcar_drif_of_table' [-Wunused-const-variable]
> static const struct of_device_id rcar_drif_of_table[] = {
>                                  ^
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> ---
>  drivers/media/platform/renesas/rcar_drif.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/renesas/rcar_drif.c b/drivers/media/platform/renesas/rcar_drif.c
> index 9a0982fa5c6b..5167960781bf 100644
> --- a/drivers/media/platform/renesas/rcar_drif.c
> +++ b/drivers/media/platform/renesas/rcar_drif.c
> @@ -1477,7 +1477,7 @@ MODULE_DEVICE_TABLE(of, rcar_drif_of_table);
>  static struct platform_driver rcar_drif_driver = {
>         .driver = {
>                 .name = RCAR_DRIF_DRV_NAME,
> -               .of_match_table = of_match_ptr(rcar_drif_of_table),
> +               .of_match_table = rcar_drif_of_table,
>                 .pm = &rcar_drif_pm_ops,
>                 },
>         .probe = rcar_drif_probe,
> 
> base-commit: 6c1c1eb8c87de221051b9198d40971640060842f
> -- 
> Regards,
> 
> Laurent Pinchart
>
diff mbox series

Patch

diff --git a/drivers/media/platform/renesas/rcar_drif.c b/drivers/media/platform/renesas/rcar_drif.c
index 9a0982fa5c6b..5167960781bf 100644
--- a/drivers/media/platform/renesas/rcar_drif.c
+++ b/drivers/media/platform/renesas/rcar_drif.c
@@ -1477,7 +1477,7 @@  MODULE_DEVICE_TABLE(of, rcar_drif_of_table);
 static struct platform_driver rcar_drif_driver = {
 	.driver = {
 		.name = RCAR_DRIF_DRV_NAME,
-		.of_match_table = of_match_ptr(rcar_drif_of_table),
+		.of_match_table = rcar_drif_of_table,
 		.pm = &rcar_drif_pm_ops,
 		},
 	.probe = rcar_drif_probe,