[net,v2,0/2] net: ipa: fix page free in two spots

Message

Alex Elder May 26, 2022, 3:23 p.m. UTC

When a receive buffer is not wrapped in an SKB and passed to the
network stack, the (compound) page gets freed within the IPA driver.
This is currently quite rare.

The pages are freed using __free_pages(), but they should instead be
freed using page_put().  This series fixes this, in two spots.

These patches work for the current linus/master branch, but won't
apply cleanly to earlier stable branches.  (Nevertheless, the fix is
a trivial substitution everwhere __free_pages() is called.)

Version 2 is just rebased on today's net/master branch.

					-Alex

Alex Elder (2):
  net: ipa: fix page free in ipa_endpoint_trans_release()
  net: ipa: fix page free in ipa_endpoint_replenish_one()

 drivers/net/ipa/ipa_endpoint.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

Comments

[e-mail] May 28, 2022, 2:20 a.m. UTC | #1

Hello:

This series was applied to netdev/net.git (master)
by Jakub Kicinski <[e-mail]>:

On Thu, 26 May 2022 10:23:12 -0500 you wrote:
> When a receive buffer is not wrapped in an SKB and passed to the
> network stack, the (compound) page gets freed within the IPA driver.
> This is currently quite rare.
> 
> The pages are freed using __free_pages(), but they should instead be
> freed using page_put().  This series fixes this, in two spots.
> 
> [...]

Here is the summary with links:
  - [net,v2,1/2] net: ipa: fix page free in ipa_endpoint_trans_release()
    https://git.kernel.org/netdev/net/c/155c0c90bca9
  - [net,v2,2/2] net: ipa: fix page free in ipa_endpoint_replenish_one()
    https://git.kernel.org/netdev/net/c/70132763d5d2

You are awesome, thank you!