| Message ID | 20220518191126.60396-1-athierry@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | staging: vchiq_arm: remove some unnecessary global variables | expand |
Hi Adrien, Am 18.05.22 um 21:11 schrieb Adrien Thierry: > This patch series aims at removing some unnecessary global structures > (namely, 'g_dev' and 'vchiq_states'), in order to make the driver more > robust. This is part of an effort to address TODO item "Get rid of all non > essential global structures and create a proper per device structure". sorry for the delay, but i was fighting with some platform regressions in Linux 5.18. So except of my comments, this series is: Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
On Mon, May 30, 2022 at 10:19:14PM +0200, Stefan Wahren wrote: > Hi Adrien, > > Am 18.05.22 um 21:11 schrieb Adrien Thierry: > > This patch series aims at removing some unnecessary global structures > > (namely, 'g_dev' and 'vchiq_states'), in order to make the driver more > > robust. This is part of an effort to address TODO item "Get rid of all non > > essential global structures and create a proper per device structure". > > sorry for the delay, but i was fighting with some platform regressions in > Linux 5.18. > > So except of my comments, this series is: > > Tested-by: Stefan Wahren <stefan.wahren@i2se.com> > > Hi Stefan, Not directly related to these patches, but if you don't mind I would like to know what tests in specific are necessary to tag a Tested-by on a vchiq patch? For instance, running the userland vchiq_test -f on a RPi 3B would be enough? thanks, Gaston
This patch series aims at removing some unnecessary global structures (namely, 'g_dev' and 'vchiq_states'), in order to make the driver more robust. This is part of an effort to address TODO item "Get rid of all non essential global structures and create a proper per device structure". Changes since v1: - added more info in commit messages - split commit removing the 'vchiq_states' array into several changes to make the review easier. Adrien Thierry (9): staging: vchiq_arm: add reference to vchiq device in vchiq_state staging: vchiq_arm: get rid of global device structure staging: vchiq_arm: pass vchiq instance to service callbacks staging: vchiq_arm: pass vchiq instance to 'find_service_by_handle' staging: vchiq_arm: pass vchiq instance to 'vchiq_get_client_id' staging: vchiq_arm: pass vchiq instance to 'vchiq_get_service_userdata' staging: vchiq_arm: pass vchiq instance to 'handle_to_service' staging: vchiq_arm: use state from vchiq instance staging: vchiq_arm: remove global 'vchiq_states' array .../bcm2835-audio/bcm2835-vchiq.c | 40 +++++--- .../include/linux/raspberrypi/vchiq.h | 48 +++++---- .../interface/vchiq_arm/vchiq_arm.c | 92 ++++++++---------- .../interface/vchiq_arm/vchiq_arm.h | 8 +- .../interface/vchiq_arm/vchiq_core.c | 97 ++++++++++--------- .../interface/vchiq_arm/vchiq_core.h | 38 +++----- .../interface/vchiq_arm/vchiq_dev.c | 40 ++++---- .../vc04_services/vchiq-mmal/mmal-vchiq.c | 63 ++++++------ 8 files changed, 217 insertions(+), 209 deletions(-) base-commit: e41f7a5521d7f03dca99e3207633df71740569dd