| Message ID | 20220530201436.902505-1-fparent@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/7] dt-bindings: display: mediatek: dpi: add power-domains property | expand |
On Mon, 30 May 2022 22:14:30 +0200, Fabien Parent wrote: > DPI is part of the display / multimedia block in MediaTek SoCs, and > always have a power-domain (at least in the upstream device-trees). > Add the power-domains property to the binding documentation. > > Signed-off-by: Fabien Parent <fparent@baylibre.com> > --- > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Error: Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.example.dts:29.35-36 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:364: Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.example.dtb] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1401: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Hi, Fabien: On Mon, 2022-05-30 at 22:14 +0200, Fabien Parent wrote: > DPI is part of the display / multimedia block in MediaTek SoCs, and > always have a power-domain (at least in the upstream device-trees). > Add the power-domains property to the binding documentation. > > Signed-off-by: Fabien Parent <fparent@baylibre.com> > --- > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 6 > ++++++ > 1 file changed, 6 insertions(+) > > diff --git > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam > l > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam > l > index 77ee1b923991..caf4c88708f4 100644 > --- > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam > l > +++ > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam > l > @@ -57,6 +57,9 @@ properties: > Output port node. This port should be connected to the input > port of an > attached HDMI or LVDS encoder chip. > > + power-domains: > + maxItems: 1 > + > required: > - compatible > - reg > @@ -64,6 +67,7 @@ required: > - clocks > - clock-names > - port > + - power-domains > > additionalProperties: false > > @@ -71,11 +75,13 @@ examples: > - | > #include <dt-bindings/interrupt-controller/arm-gic.h> > #include <dt-bindings/clock/mt8173-clk.h> > + #include <dt-bindings/power/mt8183-power.h> Why do you include mt8183 power header file for mt8173 dpi node? Regards, CK > > dpi0: dpi@1401d000 { > compatible = "mediatek,mt8173-dpi"; > reg = <0x1401d000 0x1000>; > interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_LOW>; > + power-domains = <&spm MT8173_POWER_DOMAIN_MM>; > clocks = <&mmsys CLK_MM_DPI_PIXEL>, > <&mmsys CLK_MM_DPI_ENGINE>, > <&apmixedsys CLK_APMIXED_TVDPLL>;
> -----Original Message----- > From: Linux-mediatek <linux-mediatek-bounces@lists.infradead.org> On > Behalf Of CK Hu > Sent: Friday, June 17, 2022 1:31 PM > To: Fabien Parent <fparent@baylibre.com>; matthias.bgg@gmail.com; > Jitao Shi (石记涛) <jitao.shi@mediatek.com>; > krzysztof.kozlowski+dt@linaro.org; robh+dt@kernel.org > Cc: chunkuang.hu@kernel.org; p.zabel@pengutronix.de; airlied@linux.ie > ; daniel@ffwll.ch; dri-devel@lists.freedesktop.org; > linux-mediatek@lists.infradead.org; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH 1/7] dt-bindings: display: mediatek: dpi: add > power-domains property > > Hi, Fabien: > > On Mon, 2022-05-30 at 22:14 +0200, Fabien Parent wrote: > > DPI is part of the display / multimedia block in MediaTek SoCs, > > and > > always have a power-domain (at least in the upstream device-trees). > > Add the power-domains property to the binding documentation. > > > > Signed-off-by: Fabien Parent <fparent@baylibre.com> > > --- > > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 6 > > ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y > > am > > l > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y > > am > > l > > index 77ee1b923991..caf4c88708f4 100644 > > --- > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y > > am > > l > > +++ > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y > > am > > l > > @@ -57,6 +57,9 @@ properties: > > Output port node. This port should be connected to the > > input > > port of an > > attached HDMI or LVDS encoder chip. > > > > + power-domains: > > + maxItems: 1 > > + > > required: > > - compatible > > - reg > > @@ -64,6 +67,7 @@ required: > > - clocks > > - clock-names > > - port > > + - power-domains > > > > additionalProperties: false > > > > @@ -71,11 +75,13 @@ examples: > > - | > > #include <dt-bindings/interrupt-controller/arm-gic.h> > > #include <dt-bindings/clock/mt8173-clk.h> > > + #include <dt-bindings/power/mt8183-power.h> > > Why do you include mt8183 power header file for mt8173 dpi node? > > Regards, > CK > > > > > dpi0: dpi@1401d000 { > > compatible = "mediatek,mt8173-dpi"; > > reg = <0x1401d000 0x1000>; > > interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_LOW>; > > + power-domains = <&spm MT8173_POWER_DOMAIN_MM>; > > clocks = <&mmsys CLK_MM_DPI_PIXEL>, > > <&mmsys CLK_MM_DPI_ENGINE>, > > <&apmixedsys CLK_APMIXED_TVDPLL>; > > Hi fparent: I think CK's suggestion, probably because you included the wrong header file for power. Because I did not find the definition of MT8173_POWER_DOMAIN_MM in the path of dt-bindings/power/mt8183-power.h, it was defined in dt- bindings/power/mt8173-power.h. Please discuss if you have different opinions. Best Regards! xinlei
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml index 77ee1b923991..caf4c88708f4 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml @@ -57,6 +57,9 @@ properties: Output port node. This port should be connected to the input port of an attached HDMI or LVDS encoder chip. + power-domains: + maxItems: 1 + required: - compatible - reg @@ -64,6 +67,7 @@ required: - clocks - clock-names - port + - power-domains additionalProperties: false @@ -71,11 +75,13 @@ examples: - | #include <dt-bindings/interrupt-controller/arm-gic.h> #include <dt-bindings/clock/mt8173-clk.h> + #include <dt-bindings/power/mt8183-power.h> dpi0: dpi@1401d000 { compatible = "mediatek,mt8173-dpi"; reg = <0x1401d000 0x1000>; interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_LOW>; + power-domains = <&spm MT8173_POWER_DOMAIN_MM>; clocks = <&mmsys CLK_MM_DPI_PIXEL>, <&mmsys CLK_MM_DPI_ENGINE>, <&apmixedsys CLK_APMIXED_TVDPLL>;
DPI is part of the display / multimedia block in MediaTek SoCs, and always have a power-domain (at least in the upstream device-trees). Add the power-domains property to the binding documentation. Signed-off-by: Fabien Parent <fparent@baylibre.com> --- .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 6 ++++++ 1 file changed, 6 insertions(+)