| Message ID | 20220525210117.2489333-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | bcd7ec2cd720d5034a95d42f7ba3276b5e917bda |
| Headers | show |
| Series | dt-bindings: PCI: socionext,uniphier-pcie: Add missing child interrupt controller | expand |
Hi Rob, On 2022/05/26 6:01, Rob Herring wrote: > The Socionext interrupt controller internal to the the PCI block isn't > documented which causes warnings when unevaluatedProperties check is > also fixed. Add the 'interrupt-controller' child node and properties and > fixup the example so that interrupt properties can be parsed. Surely internal interrupt controller isn't described, and should be documented. And the child node name "legacy-interrupt-controller" also should be fixed. Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> BTW I can't reproduce such warnings with my environment. Can you show the command line to reproduce the warnings? Thank you, > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../bindings/pci/socionext,uniphier-pcie.yaml | 23 ++++++++++++++++++- > 1 file changed, 22 insertions(+), 1 deletion(-) > > diff --git > a/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml > b/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml > index f5926d0fb085..638b99db0433 100644 > --- a/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml > @@ -51,6 +51,19 @@ properties: > phy-names: > const: pcie-phy > > + interrupt-controller: > + type: object > + additionalProperties: false > + > + properties: > + interrupt-controller: true > + > + '#interrupt-cells': > + const: 1 > + > + interrupts: > + maxItems: 1 > + > required: > - compatible > - reg > @@ -62,6 +75,13 @@ unevaluatedProperties: false > > examples: > - | > + bus { > + gic: interrupt-controller { > + interrupt-controller; > + #interrupt-cells = <3>; > + }; > + }; > + > pcie: pcie@66000000 { > compatible = "socionext,uniphier-pcie"; > reg-names = "dbi", "link", "config"; > @@ -80,6 +100,7 @@ examples: > phys = <&pcie_phy>; > #interrupt-cells = <1>; > interrupt-names = "dma", "msi"; > + interrupt-parent = <&gic>; > interrupts = <0 224 4>, <0 225 4>; > interrupt-map-mask = <0 0 0 7>; > interrupt-map = <0 0 0 1 &pcie_intc 0>, > @@ -87,7 +108,7 @@ examples: > <0 0 0 3 &pcie_intc 2>, > <0 0 0 4 &pcie_intc 3>; > > - pcie_intc: legacy-interrupt-controller { > + pcie_intc: interrupt-controller { > interrupt-controller; > #interrupt-cells = <1>; > interrupt-parent = <&gic>; > --- Best Regards Kunihiko Hayashi
On Thu, May 26, 2022 at 4:02 AM Kunihiko Hayashi <hayashi.kunihiko@socionext.com> wrote: > > Hi Rob, > > On 2022/05/26 6:01, Rob Herring wrote: > > The Socionext interrupt controller internal to the the PCI block isn't > > documented which causes warnings when unevaluatedProperties check is > > also fixed. Add the 'interrupt-controller' child node and properties and > > fixup the example so that interrupt properties can be parsed. > > Surely internal interrupt controller isn't described, and should be documented. > And the child node name "legacy-interrupt-controller" also should be fixed. > > Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> Thanks. > > BTW I can't reproduce such warnings with my environment. > Can you show the command line to reproduce the warnings? "causes warnings when unevaluatedProperties check is also fixed" You won't. I have a fix in dtschema pending, but first all the warnings that appear need to be fixed. Rob
On 2022/05/26 21:46, Rob Herring wrote: > On Thu, May 26, 2022 at 4:02 AM Kunihiko Hayashi > <hayashi.kunihiko@socionext.com> wrote: >> >> Hi Rob, >> >> On 2022/05/26 6:01, Rob Herring wrote: >>> The Socionext interrupt controller internal to the the PCI block isn't >>> documented which causes warnings when unevaluatedProperties check is >>> also fixed. Add the 'interrupt-controller' child node and properties and >>> fixup the example so that interrupt properties can be parsed. >> >> Surely internal interrupt controller isn't described, and should be >> documented. >> And the child node name "legacy-interrupt-controller" also should be >> fixed. >> >> Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > > Thanks. > >> >> BTW I can't reproduce such warnings with my environment. >> Can you show the command line to reproduce the warnings? > > "causes warnings when unevaluatedProperties check is also fixed" > > You won't. I have a fix in dtschema pending, but first all the > warnings that appear need to be fixed. I understand. I don't care abort the warning on the way to fix. Thank you, --- Best Regards Kunihiko Hayashi
On Wed, May 25, 2022 at 04:01:16PM -0500, Rob Herring wrote: > The Socionext interrupt controller internal to the the PCI block isn't > documented which causes warnings when unevaluatedProperties check is > also fixed. Add the 'interrupt-controller' child node and properties and > fixup the example so that interrupt properties can be parsed. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../bindings/pci/socionext,uniphier-pcie.yaml | 23 ++++++++++++++++++- > 1 file changed, 22 insertions(+), 1 deletion(-) Applied, thanks.
diff --git a/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml b/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml index f5926d0fb085..638b99db0433 100644 --- a/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml @@ -51,6 +51,19 @@ properties: phy-names: const: pcie-phy + interrupt-controller: + type: object + additionalProperties: false + + properties: + interrupt-controller: true + + '#interrupt-cells': + const: 1 + + interrupts: + maxItems: 1 + required: - compatible - reg @@ -62,6 +75,13 @@ unevaluatedProperties: false examples: - | + bus { + gic: interrupt-controller { + interrupt-controller; + #interrupt-cells = <3>; + }; + }; + pcie: pcie@66000000 { compatible = "socionext,uniphier-pcie"; reg-names = "dbi", "link", "config"; @@ -80,6 +100,7 @@ examples: phys = <&pcie_phy>; #interrupt-cells = <1>; interrupt-names = "dma", "msi"; + interrupt-parent = <&gic>; interrupts = <0 224 4>, <0 225 4>; interrupt-map-mask = <0 0 0 7>; interrupt-map = <0 0 0 1 &pcie_intc 0>, @@ -87,7 +108,7 @@ examples: <0 0 0 3 &pcie_intc 2>, <0 0 0 4 &pcie_intc 3>; - pcie_intc: legacy-interrupt-controller { + pcie_intc: interrupt-controller { interrupt-controller; #interrupt-cells = <1>; interrupt-parent = <&gic>;
The Socionext interrupt controller internal to the the PCI block isn't documented which causes warnings when unevaluatedProperties check is also fixed. Add the 'interrupt-controller' child node and properties and fixup the example so that interrupt properties can be parsed. Signed-off-by: Rob Herring <robh@kernel.org> --- .../bindings/pci/socionext,uniphier-pcie.yaml | 23 ++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-)