| Message ID | 20220521031621.3494402-1-chao@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | generic: adjust strict SPO recovery testcases for f2fs | expand |
+Cc Zorro, Any comments? On 2022/5/21 11:16, Chao Yu wrote: > Testcases like generic 342/502/526/527 expect that filesystems will > recover all related metadata changes to the file which was fsynced > before sudden power off. > > This patch adjusts to use "fsync_mode=strict" mountoption for f2fs > to pass these testcases. > > Signed-off-by: Chao Yu <chao@kernel.org> > --- > tests/generic/342 | 5 +++++ > tests/generic/502 | 5 +++++ > tests/generic/526 | 5 +++++ > tests/generic/527 | 5 +++++ > 4 files changed, 20 insertions(+) > > diff --git a/tests/generic/342 b/tests/generic/342 > index 676b876b..cdffaaf3 100755 > --- a/tests/generic/342 > +++ b/tests/generic/342 > @@ -31,6 +31,11 @@ _require_dm_target flakey > > _scratch_mkfs >>$seqres.full 2>&1 > _require_metadata_journaling $SCRATCH_DEV > + > +if [ $FSTYP = "f2fs" ]; then > + export MOUNT_OPTIONS="-o fsync_mode=strict $MOUNT_OPTIONS" > +fi > + > _init_flakey > _mount_flakey > > diff --git a/tests/generic/502 b/tests/generic/502 > index b0f9077f..b5589b81 100755 > --- a/tests/generic/502 > +++ b/tests/generic/502 > @@ -34,6 +34,11 @@ _require_dm_target flakey > > _scratch_mkfs >>$seqres.full 2>&1 > _require_metadata_journaling $SCRATCH_DEV > + > +if [ $FSTYP = "f2fs" ]; then > + export MOUNT_OPTIONS="-o fsync_mode=strict $MOUNT_OPTIONS" > +fi > + > _init_flakey > _mount_flakey > > diff --git a/tests/generic/526 b/tests/generic/526 > index dc7cb36c..ada4dbee 100755 > --- a/tests/generic/526 > +++ b/tests/generic/526 > @@ -32,6 +32,11 @@ _require_dm_target flakey > > _scratch_mkfs >>$seqres.full 2>&1 > _require_metadata_journaling $SCRATCH_DEV > + > +if [ $FSTYP = "f2fs" ]; then > + export MOUNT_OPTIONS="-o fsync_mode=strict $MOUNT_OPTIONS" > +fi > + > _init_flakey > _mount_flakey > > diff --git a/tests/generic/527 b/tests/generic/527 > index 40cd1c6a..de09d171 100755 > --- a/tests/generic/527 > +++ b/tests/generic/527 > @@ -32,6 +32,11 @@ _require_dm_target flakey > > _scratch_mkfs >>$seqres.full 2>&1 > _require_metadata_journaling $SCRATCH_DEV > + > +if [ $FSTYP = "f2fs" ]; then > + export MOUNT_OPTIONS="-o fsync_mode=strict $MOUNT_OPTIONS" > +fi > + > _init_flakey > _mount_flakey >
On Sat, May 21, 2022 at 11:16:21AM +0800, Chao Yu wrote: > Testcases like generic 342/502/526/527 expect that filesystems will > recover all related metadata changes to the file which was fsynced > before sudden power off. > > This patch adjusts to use "fsync_mode=strict" mountoption for f2fs > to pass these testcases. > > Signed-off-by: Chao Yu <chao@kernel.org> > --- I don't have better idea, so it's good to me. Reviewed-by: Zorro Lang <zlang@redhat.com> I'm thinking about is there only f2fs has this kind of requirement? If this's not a single problem, we can help a common helper for that. But if only f2fs, I think this change is fine. Welcome better ideas if anyone else has. If no more, I'll merge it. Thanks, Zorro > tests/generic/342 | 5 +++++ > tests/generic/502 | 5 +++++ > tests/generic/526 | 5 +++++ > tests/generic/527 | 5 +++++ > 4 files changed, 20 insertions(+) > > diff --git a/tests/generic/342 b/tests/generic/342 > index 676b876b..cdffaaf3 100755 > --- a/tests/generic/342 > +++ b/tests/generic/342 > @@ -31,6 +31,11 @@ _require_dm_target flakey > > _scratch_mkfs >>$seqres.full 2>&1 > _require_metadata_journaling $SCRATCH_DEV > + > +if [ $FSTYP = "f2fs" ]; then > + export MOUNT_OPTIONS="-o fsync_mode=strict $MOUNT_OPTIONS" > +fi > + > _init_flakey > _mount_flakey > > diff --git a/tests/generic/502 b/tests/generic/502 > index b0f9077f..b5589b81 100755 > --- a/tests/generic/502 > +++ b/tests/generic/502 > @@ -34,6 +34,11 @@ _require_dm_target flakey > > _scratch_mkfs >>$seqres.full 2>&1 > _require_metadata_journaling $SCRATCH_DEV > + > +if [ $FSTYP = "f2fs" ]; then > + export MOUNT_OPTIONS="-o fsync_mode=strict $MOUNT_OPTIONS" > +fi > + > _init_flakey > _mount_flakey > > diff --git a/tests/generic/526 b/tests/generic/526 > index dc7cb36c..ada4dbee 100755 > --- a/tests/generic/526 > +++ b/tests/generic/526 > @@ -32,6 +32,11 @@ _require_dm_target flakey > > _scratch_mkfs >>$seqres.full 2>&1 > _require_metadata_journaling $SCRATCH_DEV > + > +if [ $FSTYP = "f2fs" ]; then > + export MOUNT_OPTIONS="-o fsync_mode=strict $MOUNT_OPTIONS" > +fi > + > _init_flakey > _mount_flakey > > diff --git a/tests/generic/527 b/tests/generic/527 > index 40cd1c6a..de09d171 100755 > --- a/tests/generic/527 > +++ b/tests/generic/527 > @@ -32,6 +32,11 @@ _require_dm_target flakey > > _scratch_mkfs >>$seqres.full 2>&1 > _require_metadata_journaling $SCRATCH_DEV > + > +if [ $FSTYP = "f2fs" ]; then > + export MOUNT_OPTIONS="-o fsync_mode=strict $MOUNT_OPTIONS" > +fi > + > _init_flakey > _mount_flakey > > -- > 2.25.1 >
diff --git a/tests/generic/342 b/tests/generic/342 index 676b876b..cdffaaf3 100755 --- a/tests/generic/342 +++ b/tests/generic/342 @@ -31,6 +31,11 @@ _require_dm_target flakey _scratch_mkfs >>$seqres.full 2>&1 _require_metadata_journaling $SCRATCH_DEV + +if [ $FSTYP = "f2fs" ]; then + export MOUNT_OPTIONS="-o fsync_mode=strict $MOUNT_OPTIONS" +fi + _init_flakey _mount_flakey diff --git a/tests/generic/502 b/tests/generic/502 index b0f9077f..b5589b81 100755 --- a/tests/generic/502 +++ b/tests/generic/502 @@ -34,6 +34,11 @@ _require_dm_target flakey _scratch_mkfs >>$seqres.full 2>&1 _require_metadata_journaling $SCRATCH_DEV + +if [ $FSTYP = "f2fs" ]; then + export MOUNT_OPTIONS="-o fsync_mode=strict $MOUNT_OPTIONS" +fi + _init_flakey _mount_flakey diff --git a/tests/generic/526 b/tests/generic/526 index dc7cb36c..ada4dbee 100755 --- a/tests/generic/526 +++ b/tests/generic/526 @@ -32,6 +32,11 @@ _require_dm_target flakey _scratch_mkfs >>$seqres.full 2>&1 _require_metadata_journaling $SCRATCH_DEV + +if [ $FSTYP = "f2fs" ]; then + export MOUNT_OPTIONS="-o fsync_mode=strict $MOUNT_OPTIONS" +fi + _init_flakey _mount_flakey diff --git a/tests/generic/527 b/tests/generic/527 index 40cd1c6a..de09d171 100755 --- a/tests/generic/527 +++ b/tests/generic/527 @@ -32,6 +32,11 @@ _require_dm_target flakey _scratch_mkfs >>$seqres.full 2>&1 _require_metadata_journaling $SCRATCH_DEV + +if [ $FSTYP = "f2fs" ]; then + export MOUNT_OPTIONS="-o fsync_mode=strict $MOUNT_OPTIONS" +fi + _init_flakey _mount_flakey
Testcases like generic 342/502/526/527 expect that filesystems will recover all related metadata changes to the file which was fsynced before sudden power off. This patch adjusts to use "fsync_mode=strict" mountoption for f2fs to pass these testcases. Signed-off-by: Chao Yu <chao@kernel.org> --- tests/generic/342 | 5 +++++ tests/generic/502 | 5 +++++ tests/generic/526 | 5 +++++ tests/generic/527 | 5 +++++ 4 files changed, 20 insertions(+)