diff mbox series

[7/8] xfs/167: adjust runtime with TIME_FACTOR

Message ID 20220602003126.2903779-8-david@fromorbit.com (mailing list archive)
State New, archived
Headers show
Series [1/8] xfstests: Add Log Attribute Replay test | expand

Commit Message

Dave Chinner June 2, 2022, 12:31 a.m. UTC 
From: Dave Chinner <dchinner@redhat.com>

xfs/167 takes between 6 and 10 minutes to run on my SSD based test
machines. It's running 50 loops of a unwritten extent conversion
test program whilst running a heavy fsstress workload in the
background. This does not need to run for 10 minutes on every auto
group regression test run. Shorten it to loop 5 * TIME_FACTOR
so that normal runtime drops to something sane but can still be
easily ramped up if soak/stress testing is being run.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
 tests/xfs/167 | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Darrick J. Wong June 2, 2022, 12:53 a.m. UTC | #1 
On Thu, Jun 02, 2022 at 10:31:25AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> xfs/167 takes between 6 and 10 minutes to run on my SSD based test
> machines. It's running 50 loops of a unwritten extent conversion
> test program whilst running a heavy fsstress workload in the
> background. This does not need to run for 10 minutes on every auto
> group regression test run. Shorten it to loop 5 * TIME_FACTOR
> so that normal runtime drops to something sane but can still be
> easily ramped up if soak/stress testing is being run.
> 
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

Looks good to me,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  tests/xfs/167 | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/xfs/167 b/tests/xfs/167
> index 5f985010..15bb1854 100755
> --- a/tests/xfs/167
> +++ b/tests/xfs/167
> @@ -47,13 +47,11 @@ _require_fs_space $SCRATCH_MNT 10485760
>  
>  TEST_FILE=$SCRATCH_MNT/test_file
>  TEST_PROG=$here/src/unwritten_sync
> -LOOPS=50
> +LOOPS=$((5 * $TIME_FACTOR))
>  
>  echo "*** test unwritten extent conversion under heavy I/O"
> -
> -workout
> -
>  rm -f $TEST_FILE
> +workout
>  $TEST_PROG $LOOPS $TEST_FILE
>  
>  echo "     *** test done"
> -- 
> 2.35.1
>
diff mbox series

Patch

diff --git a/tests/xfs/167 b/tests/xfs/167
index 5f985010..15bb1854 100755
--- a/tests/xfs/167
+++ b/tests/xfs/167
@@ -47,13 +47,11 @@  _require_fs_space $SCRATCH_MNT 10485760
 
 TEST_FILE=$SCRATCH_MNT/test_file
 TEST_PROG=$here/src/unwritten_sync
-LOOPS=50
+LOOPS=$((5 * $TIME_FACTOR))
 
 echo "*** test unwritten extent conversion under heavy I/O"
-
-workout
-
 rm -f $TEST_FILE
+workout
 $TEST_PROG $LOOPS $TEST_FILE
 
 echo "     *** test done"