| Message ID | e9bafd799489215710f7880214b58d6487407248.1654320767.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Deferred |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | nfp: Remove kernel.h when not needed | expand |
On Sat, Jun 04, 2022 at 07:33:00AM +0200, Christophe JAILLET wrote: > When kernel.h is used in the headers it adds a lot into dependency hell, > especially when there are circular dependencies are involved. > > Remove kernel.h when it is not needed. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Thanks for improving the NFP driver. I think the contents of this patch looks good. Reviewed-by: Simon Horman <simon.horman@corigine.com> I also think this patch is appropriate for net-next ("[PATCH net-next] ..." in subject) and should thus be re-submitted once net-next re-opens for the v5.20 development cycle, which I would expect to happen in the coming days, after v5.19-rc1 has been released. I'm happy to handle re-submitting it if you prefer.
Le 04/06/2022 à 11:17, Simon Horman a écrit : > On Sat, Jun 04, 2022 at 07:33:00AM +0200, Christophe JAILLET wrote: >> When kernel.h is used in the headers it adds a lot into dependency hell, >> especially when there are circular dependencies are involved. >> >> Remove kernel.h when it is not needed. >> >> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > > Thanks for improving the NFP driver. > > I think the contents of this patch looks good. > > Reviewed-by: Simon Horman <simon.horman@corigine.com> > > I also think this patch is appropriate for net-next > ("[PATCH net-next] ..." in subject) and should thus be re-submitted > once net-next re-opens for the v5.20 development cycle, which I would > expect to happen in the coming days, after v5.19-rc1 has been released. > > I'm happy to handle re-submitting it if you prefer. > Hi, if you don't mind, yes I prefer. Dealing with timing of release cycles and prefix depending on where the patch should land is a bit too much for me. Thank you for your help :) CJ
On Sat, Jun 04, 2022 at 02:58:25PM +0200, Christophe JAILLET wrote: > Le 04/06/2022 à 11:17, Simon Horman a écrit : > > On Sat, Jun 04, 2022 at 07:33:00AM +0200, Christophe JAILLET wrote: > > > When kernel.h is used in the headers it adds a lot into dependency hell, > > > especially when there are circular dependencies are involved. > > > > > > Remove kernel.h when it is not needed. > > > > > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > > > > Thanks for improving the NFP driver. > > > > I think the contents of this patch looks good. > > > > Reviewed-by: Simon Horman <simon.horman@corigine.com> > > > > I also think this patch is appropriate for net-next > > ("[PATCH net-next] ..." in subject) and should thus be re-submitted > > once net-next re-opens for the v5.20 development cycle, which I would > > expect to happen in the coming days, after v5.19-rc1 has been released. > > > > I'm happy to handle re-submitting it if you prefer. > > > > Hi, > if you don't mind, yes I prefer. > > Dealing with timing of release cycles and prefix depending on where the > patch should land is a bit too much for me. > > Thank you for your help :) You are welcome, thanks for your patch.
diff --git a/drivers/net/ethernet/netronome/nfp/nfpcore/crc32.h b/drivers/net/ethernet/netronome/nfp/nfpcore/crc32.h index afab6f0fc564..6ad43c7cefe6 100644 --- a/drivers/net/ethernet/netronome/nfp/nfpcore/crc32.h +++ b/drivers/net/ethernet/netronome/nfp/nfpcore/crc32.h @@ -4,7 +4,6 @@ #ifndef NFP_CRC32_H #define NFP_CRC32_H -#include <linux/kernel.h> #include <linux/crc32.h> /**
When kernel.h is used in the headers it adds a lot into dependency hell, especially when there are circular dependencies are involved. Remove kernel.h when it is not needed. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/net/ethernet/netronome/nfp/nfpcore/crc32.h | 1 - 1 file changed, 1 deletion(-)