| Message ID | 20220601191730.29721-2-macroalpha82@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | adc-joystick: Add polled support | expand |
On 2022-06-01 21:17, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> Hi Chris, > > Add devicetree bindings for adc-joystick-polled. > > Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com> > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > --- > Documentation/devicetree/bindings/input/adc-joystick.yaml | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/input/adc-joystick.yaml > b/Documentation/devicetree/bindings/input/adc-joystick.yaml > index 2ee04e03bc22..a9d2ac157322 100644 > --- a/Documentation/devicetree/bindings/input/adc-joystick.yaml > +++ b/Documentation/devicetree/bindings/input/adc-joystick.yaml > @@ -12,11 +12,15 @@ maintainers: > > description: > > Bindings for joystick devices connected to ADC controllers > supporting > - the Industrial I/O subsystem. > + the Industrial I/O subsystem. Supports both polled devices where no > + iio trigger is available and non-polled devices which are triggered > + by iio. > > properties: > compatible: > - const: adc-joystick > + enum: > + - adc-joystick > + - adc-joystick-polled There is no need to create a new compatible for your functionality. Instead, just add a new (optional) property. cheers, Artur > > io-channels: > minItems: 1
On Wed, Jun 01, 2022 at 09:44:43PM +0200, Artur Rojek wrote: > On 2022-06-01 21:17, Chris Morgan wrote: > > From: Chris Morgan <macromorgan@hotmail.com> > > Hi Chris, > > > > > Add devicetree bindings for adc-joystick-polled. > > > > Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com> > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > > --- > > Documentation/devicetree/bindings/input/adc-joystick.yaml | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/input/adc-joystick.yaml > > b/Documentation/devicetree/bindings/input/adc-joystick.yaml > > index 2ee04e03bc22..a9d2ac157322 100644 > > --- a/Documentation/devicetree/bindings/input/adc-joystick.yaml > > +++ b/Documentation/devicetree/bindings/input/adc-joystick.yaml > > @@ -12,11 +12,15 @@ maintainers: > > > > description: > > > Bindings for joystick devices connected to ADC controllers supporting > > - the Industrial I/O subsystem. > > + the Industrial I/O subsystem. Supports both polled devices where no > > + iio trigger is available and non-polled devices which are triggered > > + by iio. > > > > properties: > > compatible: > > - const: adc-joystick > > + enum: > > + - adc-joystick > > + - adc-joystick-polled > > There is no need to create a new compatible for your functionality. Instead, > just add a new (optional) property. Perhaps the already defined for input devices 'poll-interval'. Rob
diff --git a/Documentation/devicetree/bindings/input/adc-joystick.yaml b/Documentation/devicetree/bindings/input/adc-joystick.yaml index 2ee04e03bc22..a9d2ac157322 100644 --- a/Documentation/devicetree/bindings/input/adc-joystick.yaml +++ b/Documentation/devicetree/bindings/input/adc-joystick.yaml @@ -12,11 +12,15 @@ maintainers: description: > Bindings for joystick devices connected to ADC controllers supporting - the Industrial I/O subsystem. + the Industrial I/O subsystem. Supports both polled devices where no + iio trigger is available and non-polled devices which are triggered + by iio. properties: compatible: - const: adc-joystick + enum: + - adc-joystick + - adc-joystick-polled io-channels: minItems: 1