[v2,0/2] drm/bridge: analogix_dp: Self-refresh state machine fixes

Message

Brian Norris Feb. 28, 2022, 8:25 p.m. UTC

Hi,

I've been investigating several eDP issues on a Rockchip RK3399 system
and have two proposed bugfixes. RK3399 has two CRTCs, either of which
can be used for eDP output. For both fixes, we have bugs due to the
relationship between the generalized "self refresh helpers" and the
analogix-dp bridge driver which controls much of the PSR mechanics.
These bugs are most visible when switching between CRTCs.

I'm not a DRM expert, but I've been poking at a lot of Rockchip display
drivers recently. I'd love some skeptical eyes, so feel free to ask
questions if I haven't explained issues well, or the proposals look
fishy.

Regards,
Brian

Changes in v2:
- Drop "->enable" condition in crtc_needs_disable(); this could possibly
  be "->active" to reflect the intended hardware state, but it also is a
  little over-specific. We want to make a transition through "disabled"
  any time we're exiting PSR at the same time as a CRTC switch.
  (Thanks Liu Ying)

Brian Norris (2):
  drm/bridge: analogix_dp: Support PSR-exit to disable transition
  drm/atomic: Force bridge self-refresh-exit on CRTC switch

 .../drm/bridge/analogix/analogix_dp_core.c    | 42 +++++++++++++++++--
 drivers/gpu/drm/drm_atomic_helper.c           | 16 +++++--
 2 files changed, 51 insertions(+), 7 deletions(-)

Comments

Brian Norris March 10, 2022, 11:50 p.m. UTC | #1

On Mon, Feb 28, 2022 at 12:25 PM Brian Norris <[e-mail]> wrote:
>
> Hi,
>
> I've been investigating several eDP issues on a Rockchip RK3399 system
> and have two proposed bugfixes. RK3399 has two CRTCs, either of which
> can be used for eDP output. For both fixes, we have bugs due to the
> relationship between the generalized "self refresh helpers" and the
> analogix-dp bridge driver which controls much of the PSR mechanics.
> These bugs are most visible when switching between CRTCs.
>
> I'm not a DRM expert, but I've been poking at a lot of Rockchip display
> drivers recently. I'd love some skeptical eyes, so feel free to ask
> questions if I haven't explained issues well, or the proposals look
> fishy.
>
> Regards,
> Brian

Ping for review? Sean, perhaps? (You already reviewed this on the
Chromium tracker.)

Brian

Brian Norris May 23, 2022, 9:51 p.m. UTC | #2

On Thu, Mar 10, 2022 at 3:50 PM Brian Norris <[e-mail]> wrote:
> On Mon, Feb 28, 2022 at 12:25 PM Brian Norris <[e-mail]> wrote:

> Ping for review? Sean, perhaps? (You already reviewed this on the
> Chromium tracker.)

Ping

Sean Paul June 3, 2022, 3:11 p.m. UTC | #3

On Mon, May 23, 2022 at 5:51 PM Brian Norris <[e-mail]> wrote:
>
> On Thu, Mar 10, 2022 at 3:50 PM Brian Norris <[e-mail]> wrote:
> > On Mon, Feb 28, 2022 at 12:25 PM Brian Norris <[e-mail]> wrote:
>
> > Ping for review? Sean, perhaps? (You already reviewed this on the
> > Chromium tracker.)
>
> Ping

Apologies for the delay. Please in future ping on irc/chat if you're
waiting for review from me, my inbox is often neglected.

The set still looks good to me,

Reviewed-by: Sean Paul <[e-mail]>


Sean

Doug Anderson June 3, 2022, 3:17 p.m. UTC | #4

Hi,

On Fri, Jun 3, 2022 at 8:11 AM Sean Paul <[e-mail]> wrote:
>
> On Mon, May 23, 2022 at 5:51 PM Brian Norris <[e-mail]> wrote:
> >
> > On Thu, Mar 10, 2022 at 3:50 PM Brian Norris <[e-mail]> wrote:
> > > On Mon, Feb 28, 2022 at 12:25 PM Brian Norris <[e-mail]> wrote:
> >
> > > Ping for review? Sean, perhaps? (You already reviewed this on the
> > > Chromium tracker.)
> >
> > Ping
>
> Apologies for the delay. Please in future ping on irc/chat if you're
> waiting for review from me, my inbox is often neglected.
>
> The set still looks good to me,
>
> Reviewed-by: Sean Paul <[e-mail]>

Unless someone yells, I'll plan to apply both patches to
drm-misc-fixes early next week, possibly Monday. Seems like if someone
was going to object to these they've had plenty of time up until now.

-Doug

Doug Anderson June 6, 2022, 8:30 p.m. UTC | #5

Hi,

On Fri, Jun 3, 2022 at 8:17 AM Doug Anderson <[e-mail]> wrote:
>
> Hi,
>
> On Fri, Jun 3, 2022 at 8:11 AM Sean Paul <[e-mail]> wrote:
> >
> > On Mon, May 23, 2022 at 5:51 PM Brian Norris <[e-mail]> wrote:
> > >
> > > On Thu, Mar 10, 2022 at 3:50 PM Brian Norris <[e-mail]> wrote:
> > > > On Mon, Feb 28, 2022 at 12:25 PM Brian Norris <[e-mail]> wrote:
> > >
> > > > Ping for review? Sean, perhaps? (You already reviewed this on the
> > > > Chromium tracker.)
> > >
> > > Ping
> >
> > Apologies for the delay. Please in future ping on irc/chat if you're
> > waiting for review from me, my inbox is often neglected.
> >
> > The set still looks good to me,
> >
> > Reviewed-by: Sean Paul <[e-mail]>
>
> Unless someone yells, I'll plan to apply both patches to
> drm-misc-fixes early next week, possibly Monday. Seems like if someone
> was going to object to these they've had plenty of time up until now.

As promised, I pushed these to drm-misc-fixes:

e54a4424925a drm/atomic: Force bridge self-refresh-exit on CRTC switch
ca871659ec16 drm/bridge: analogix_dp: Support PSR-exit to disable transition

-Doug

Brian Norris June 7, 2022, 12:56 a.m. UTC | #6

On Mon, Jun 6, 2022 at 1:30 PM Doug Anderson <[e-mail]> wrote:
> On Fri, Jun 3, 2022 at 8:17 AM Doug Anderson <[e-mail]> wrote:
> > On Fri, Jun 3, 2022 at 8:11 AM Sean Paul <[e-mail]> wrote:
> > > Apologies for the delay. Please in future ping on irc/chat if you're
> > > waiting for review from me, my inbox is often neglected.

OK, I'll try to keep that in mind. I can't help myself with the
semi-relevant XKCD though ;)
https://xkcd.com/1254/

> > > The set still looks good to me,
> > >
> > > Reviewed-by: Sean Paul <[e-mail]>

Thanks!

> > Unless someone yells, I'll plan to apply both patches to
> > drm-misc-fixes early next week, possibly Monday. Seems like if someone
> > was going to object to these they've had plenty of time up until now.
>
> As promised, I pushed these to drm-misc-fixes:
>
> e54a4424925a drm/atomic: Force bridge self-refresh-exit on CRTC switch
> ca871659ec16 drm/bridge: analogix_dp: Support PSR-exit to disable transition

And thanks, Doug.

Brian