| Message ID | 20220602053250.62593-5-chanho61.park@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | support secondary ufs for Exynos Auto v9 SoC | expand |
On 02/06/2022 07:32, Chanho Park wrote: > Drop "ufs0-" label name usage of ufs phy and hci nodes. > Regarding the comments of reg properties, we don't need to illustrate here > because we can find the description from the dt-binding doc. > > Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Chanho Park <chanho61.park@samsung.com> > --- Thanks, DTS look ok, I'll take the last three patches after merge window. Best regards, Krzysztof
On 02/06/2022 07:32, Chanho Park wrote: > Drop "ufs0-" label name usage of ufs phy and hci nodes. > Regarding the comments of reg properties, we don't need to illustrate here > because we can find the description from the dt-binding doc. > > Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Chanho Park <chanho61.park@samsung.com> This does not apply. Can you rebase and send the DTS patches as separate patchset? Best regards, Krzysztof
> Subject: Re: [PATCH v2 4/6] arm64: dts: exynosautov9: adjust DT style of > ufs nodes > > On 02/06/2022 07:32, Chanho Park wrote: > > Drop "ufs0-" label name usage of ufs phy and hci nodes. > > Regarding the comments of reg properties, we don't need to illustrate > > here because we can find the description from the dt-binding doc. > > > > Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Signed-off-by: Chanho Park <chanho61.park@samsung.com> > > This does not apply. Can you rebase and send the DTS patches as separate > patchset? I forgot to point the baseline of this patchset. I stacked this patch on top of below patch. If you do not apply below patch or put this separate branch, I'll rebase this patchset without below patch. https://lore.kernel.org/linux-samsung-soc/20220526204323.832243-1-krzysztof.kozlowski@linaro.org/ Best Regards, Chanho Park
On Thu, 2 Jun 2022 14:32:48 +0900, Chanho Park wrote: > Drop "ufs0-" label name usage of ufs phy and hci nodes. > Regarding the comments of reg properties, we don't need to illustrate here > because we can find the description from the dt-binding doc. > > Applied, thanks! [4/6] arm64: dts: exynosautov9: adjust DT style of ufs nodes https://git.kernel.org/krzk/linux/c/283d046406c22409d45b3ab31a4c93fe94b66349 Best regards,
On 07/06/2022 07:21, Chanho Park wrote: >> Subject: Re: [PATCH v2 4/6] arm64: dts: exynosautov9: adjust DT style of >> ufs nodes >> >> On 02/06/2022 07:32, Chanho Park wrote: >>> Drop "ufs0-" label name usage of ufs phy and hci nodes. >>> Regarding the comments of reg properties, we don't need to illustrate >>> here because we can find the description from the dt-binding doc. >>> >>> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> Signed-off-by: Chanho Park <chanho61.park@samsung.com> >> >> This does not apply. Can you rebase and send the DTS patches as separate >> patchset? > > I forgot to point the baseline of this patchset. I stacked this patch on top of below patch. > If you do not apply below patch or put this separate branch, I'll rebase this patchset without below patch. > > https://lore.kernel.org/linux-samsung-soc/20220526204323.832243-1-krzysztof.kozlowski@linaro.org/ Oh, thanks! Unfortunately it helped for the patch #4 (first of DTS) but not for the next one. Maybe some other patch caused the hunks to differ. Please rebase remaining two DTS patches. Best regards, Krzysztof
> Oh, thanks! Unfortunately it helped for the patch #4 (first of DTS) but > not for the next one. Maybe some other patch caused the hunks to differ. > Please rebase remaining two DTS patches. Looks like they're conflicted with watchdog patches. I'll rebase rest two patches on top of your next/dt64 branch. https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/log/?h=next/dt64 Best Regards, Chanho Park
diff --git a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi index 26e427295946..beb46b5a83b6 100644 --- a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi +++ b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi @@ -369,7 +369,7 @@ serial_0: serial@10300000 { }; }; - ufs_0_phy: ufs0-phy@17e04000 { + ufs_0_phy: phy@17e04000 { compatible = "samsung,exynosautov9-ufs-phy"; reg = <0x17e04000 0xc00>; reg-names = "phy-pma"; @@ -380,13 +380,13 @@ ufs_0_phy: ufs0-phy@17e04000 { status = "disabled"; }; - ufs_0: ufs0@17e00000 { + ufs_0: ufs@17e00000 { compatible = "samsung,exynosautov9-ufs"; - reg = <0x17e00000 0x100>, /* 0: HCI standard */ - <0x17e01100 0x410>, /* 1: Vendor-specific */ - <0x17e80000 0x8000>, /* 2: UNIPRO */ - <0x17dc0000 0x2200>; /* 3: UFS protector */ + reg = <0x17e00000 0x100>, + <0x17e01100 0x410>, + <0x17e80000 0x8000>, + <0x17dc0000 0x2200>; reg-names = "hci", "vs_hci", "unipro", "ufsp"; interrupts = <GIC_SPI 227 IRQ_TYPE_LEVEL_HIGH>; clocks = <&cmu_fsys2 CLK_GOUT_FSYS2_UFS_EMBD0_ACLK>,
Drop "ufs0-" label name usage of ufs phy and hci nodes. Regarding the comments of reg properties, we don't need to illustrate here because we can find the description from the dt-binding doc. Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Chanho Park <chanho61.park@samsung.com> --- arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)