| Message ID | 20220607072907.127000-4-chanho61.park@samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 521f88bf4daa04ca96968be1f49a49f5a4e31488 |
| Headers | show |
| Series | [v4,1/5] dt-bindings: phy: samsung,ufs-phy: make pmu-syscon as phandle-array | expand |
On 07/06/2022 09:29, Chanho Park wrote: > Put const qualifier of samsung_ufs_phy_cfg pointer because they will > not be changed from drvdata. > > Signed-off-by: Chanho Park <chanho61.park@samsung.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
>-----Original Message----- >From: Chanho Park [mailto:chanho61.park@samsung.com] >Sent: Tuesday, June 7, 2022 12:59 PM >To: Kishon Vijay Abraham I <kishon@ti.com>; Vinod Koul ><vkoul@kernel.org>; Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; >Alim Akhtar <alim.akhtar@samsung.com>; Rob Herring ><robh+dt@kernel.org>; Krzysztof Kozlowski ><krzysztof.kozlowski+dt@linaro.org> >Cc: devicetree@vger.kernel.org; linux-phy@lists.infradead.org; linux- >samsung-soc@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Chanho >Park <chanho61.park@samsung.com> >Subject: [PATCH v4 3/5] phy: samsung: ufs: constify samsung_ufs_phy_cfg > >Put const qualifier of samsung_ufs_phy_cfg pointer because they will not be >changed from drvdata. > >Signed-off-by: Chanho Park <chanho61.park@samsung.com> >--- Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> > drivers/phy/samsung/phy-samsung-ufs.c | 4 ++-- drivers/phy/samsung/phy- >samsung-ufs.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/drivers/phy/samsung/phy-samsung-ufs.c >b/drivers/phy/samsung/phy-samsung-ufs.c >index ed272631e8aa..cd1c02d2cdda 100644 >--- a/drivers/phy/samsung/phy-samsung-ufs.c >+++ b/drivers/phy/samsung/phy-samsung-ufs.c >@@ -75,7 +75,7 @@ static int samsung_ufs_phy_wait_for_lock_acq(struct >phy *phy) static int samsung_ufs_phy_calibrate(struct phy *phy) { > struct samsung_ufs_phy *ufs_phy = get_samsung_ufs_phy(phy); >- struct samsung_ufs_phy_cfg **cfgs = ufs_phy->cfgs; >+ const struct samsung_ufs_phy_cfg * const *cfgs = ufs_phy->cfgs; > const struct samsung_ufs_phy_cfg *cfg; > int err = 0; > int i; >@@ -327,7 +327,7 @@ static int samsung_ufs_phy_probe(struct >platform_device *pdev) > drvdata = match->data; > phy->dev = dev; > phy->drvdata = drvdata; >- phy->cfgs = (struct samsung_ufs_phy_cfg **)drvdata->cfgs; >+ phy->cfgs = drvdata->cfgs; > phy->isol = &drvdata->isol; > phy->lane_cnt = PHY_DEF_LANE_CNT; > >diff --git a/drivers/phy/samsung/phy-samsung-ufs.h >b/drivers/phy/samsung/phy-samsung-ufs.h >index 1788b356cf56..5cd919539a3e 100644 >--- a/drivers/phy/samsung/phy-samsung-ufs.h >+++ b/drivers/phy/samsung/phy-samsung-ufs.h >@@ -121,7 +121,7 @@ struct samsung_ufs_phy { > struct clk *rx0_symbol_clk; > struct clk *rx1_symbol_clk; > const struct samsung_ufs_phy_drvdata *drvdata; >- struct samsung_ufs_phy_cfg **cfgs; >+ const struct samsung_ufs_phy_cfg * const *cfgs; > const struct pmu_isol *isol; > u8 lane_cnt; > int ufs_phy_state; >-- >2.36.1
diff --git a/drivers/phy/samsung/phy-samsung-ufs.c b/drivers/phy/samsung/phy-samsung-ufs.c index ed272631e8aa..cd1c02d2cdda 100644 --- a/drivers/phy/samsung/phy-samsung-ufs.c +++ b/drivers/phy/samsung/phy-samsung-ufs.c @@ -75,7 +75,7 @@ static int samsung_ufs_phy_wait_for_lock_acq(struct phy *phy) static int samsung_ufs_phy_calibrate(struct phy *phy) { struct samsung_ufs_phy *ufs_phy = get_samsung_ufs_phy(phy); - struct samsung_ufs_phy_cfg **cfgs = ufs_phy->cfgs; + const struct samsung_ufs_phy_cfg * const *cfgs = ufs_phy->cfgs; const struct samsung_ufs_phy_cfg *cfg; int err = 0; int i; @@ -327,7 +327,7 @@ static int samsung_ufs_phy_probe(struct platform_device *pdev) drvdata = match->data; phy->dev = dev; phy->drvdata = drvdata; - phy->cfgs = (struct samsung_ufs_phy_cfg **)drvdata->cfgs; + phy->cfgs = drvdata->cfgs; phy->isol = &drvdata->isol; phy->lane_cnt = PHY_DEF_LANE_CNT; diff --git a/drivers/phy/samsung/phy-samsung-ufs.h b/drivers/phy/samsung/phy-samsung-ufs.h index 1788b356cf56..5cd919539a3e 100644 --- a/drivers/phy/samsung/phy-samsung-ufs.h +++ b/drivers/phy/samsung/phy-samsung-ufs.h @@ -121,7 +121,7 @@ struct samsung_ufs_phy { struct clk *rx0_symbol_clk; struct clk *rx1_symbol_clk; const struct samsung_ufs_phy_drvdata *drvdata; - struct samsung_ufs_phy_cfg **cfgs; + const struct samsung_ufs_phy_cfg * const *cfgs; const struct pmu_isol *isol; u8 lane_cnt; int ufs_phy_state;
Put const qualifier of samsung_ufs_phy_cfg pointer because they will not be changed from drvdata. Signed-off-by: Chanho Park <chanho61.park@samsung.com> --- drivers/phy/samsung/phy-samsung-ufs.c | 4 ++-- drivers/phy/samsung/phy-samsung-ufs.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)