| Message ID | 20220606051131.14182-2-rex-bc.chen@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | MediaTek MT8195 display binding | expand |
On Mon, 06 Jun 2022 13:11:29 +0800, Bo-Chen Chen wrote: > From: "Nancy.Lin" <nancy.lin@mediatek.com> > > Add vdosys1 RDMA definition. > > Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com> > Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Tested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > .../display/mediatek/mediatek,mdp-rdma.yaml | 88 +++++++++++++++++++ > 1 file changed, 88 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml: properties:compatible: [{'const': 'mediatek,mt8195-vdo1-rdma'}] is not of type 'object', 'boolean' from schema $id: http://json-schema.org/draft-07/schema# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml: ignoring, error in schema: properties: compatible Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.example.dtb:0:0: /example-0/soc/rdma@1c104000: failed to match any schema with compatible: ['mediatek,mt8195-vdo1-rdma'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Mon, 2022-06-06 at 20:53 +0800, Rob Herring wrote: > On Mon, 06 Jun 2022 13:11:29 +0800, Bo-Chen Chen wrote: > > From: "Nancy.Lin" <nancy.lin@mediatek.com> > > > > Add vdosys1 RDMA definition. > > > > Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com> > > Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com> > > Reviewed-by: AngeloGioacchino Del Regno < > > angelogioacchino.delregno@collabora.com> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Tested-by: AngeloGioacchino Del Regno < > > angelogioacchino.delregno@collabora.com> > > --- > > .../display/mediatek/mediatek,mdp-rdma.yaml | 88 > > +++++++++++++++++++ > > 1 file changed, 88 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/display/mediatek/mediatek,mdp- > > rdma.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m > dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/display/mediatek/mediatek,md > p-rdma.yaml: properties:compatible: [{'const': 'mediatek,mt8195-vdo1- > rdma'}] is not of type 'object', 'boolean' > from schema $id: > https://urldefense.com/v3/__http://json-schema.org/draft-07/schema*__;Iw!!CTRNKA9wMg0ARbw!3hhZrSKSWnCN5Bha9laiHlB5JCx9_p-ksaYDZmoCLQRi1tI4KJCcTJQva2vds3j3bwKF$ > > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/display/mediatek/mediatek,md > p-rdma.yaml: ignoring, error in schema: properties: compatible > Documentation/devicetree/bindings/display/mediatek/mediatek,mdp- > rdma.example.dtb:0:0: /example-0/soc/rdma@1c104000: failed to match > any schema with compatible: ['mediatek,mt8195-vdo1-rdma'] > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/ > > This check can fail if there are any dependencies. The base for a > patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up > to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. > Hello Rob, We found that if we write this, and the error will disapear: properties: compatible: - - const: mediatek,mt8195-vdo1-rdma + items: + - const: mediatek,mt8195-vdo1-rdma But from Krzysztof's review[1], he adviced us to drop items. Is there any suggsetion for this error or do we have any misunderstanding? [1]:https://patchwork.kernel.org/comment/24849447/ BRs, Rex
On Mon, Jun 06, 2022 at 09:30:42PM +0800, Rex-BC Chen wrote: > On Mon, 2022-06-06 at 20:53 +0800, Rob Herring wrote: > > On Mon, 06 Jun 2022 13:11:29 +0800, Bo-Chen Chen wrote: > > > From: "Nancy.Lin" <nancy.lin@mediatek.com> > > > > > > Add vdosys1 RDMA definition. > > > > > > Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com> > > > Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com> > > > Reviewed-by: AngeloGioacchino Del Regno < > > > angelogioacchino.delregno@collabora.com> > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > Tested-by: AngeloGioacchino Del Regno < > > > angelogioacchino.delregno@collabora.com> > > > --- > > > .../display/mediatek/mediatek,mdp-rdma.yaml | 88 > > > +++++++++++++++++++ > > > 1 file changed, 88 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindings/display/mediatek/mediatek,mdp- > > > rdma.yaml > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m > > dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/linux-dt- > > review/Documentation/devicetree/bindings/display/mediatek/mediatek,md > > p-rdma.yaml: properties:compatible: [{'const': 'mediatek,mt8195-vdo1- > > rdma'}] is not of type 'object', 'boolean' > > from schema $id: > > https://urldefense.com/v3/__http://json-schema.org/draft-07/schema*__;Iw!!CTRNKA9wMg0ARbw!3hhZrSKSWnCN5Bha9laiHlB5JCx9_p-ksaYDZmoCLQRi1tI4KJCcTJQva2vds3j3bwKF$ > > > > /builds/robherring/linux-dt- > > review/Documentation/devicetree/bindings/display/mediatek/mediatek,md > > p-rdma.yaml: ignoring, error in schema: properties: compatible > > Documentation/devicetree/bindings/display/mediatek/mediatek,mdp- > > rdma.example.dtb:0:0: /example-0/soc/rdma@1c104000: failed to match > > any schema with compatible: ['mediatek,mt8195-vdo1-rdma'] > > > > doc reference errors (make refcheckdocs): > > > > See https://patchwork.ozlabs.org/patch/ > > > > This check can fail if there are any dependencies. The base for a > > patch > > series is generally the most recent rc1. > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure 'yamllint' is installed and dt-schema is up > > to > > date: > > > > pip3 install dtschema --upgrade > > > > Please check and re-submit. > > > > Hello Rob, > > We found that if we write this, and the error will disapear: > properties: > compatible: > - - const: mediatek,mt8195-vdo1-rdma > + items: > + - const: mediatek,mt8195-vdo1-rdma > > But from Krzysztof's review[1], he adviced us to drop items. > > Is there any suggsetion for this error or do we have any > misunderstanding? The '-' is important. compatible: const: mediatek,mt8195-vdo1-rdma
On Tue, 2022-06-07 at 23:11 +0800, Rob Herring wrote: > On Mon, Jun 06, 2022 at 09:30:42PM +0800, Rex-BC Chen wrote: > > On Mon, 2022-06-06 at 20:53 +0800, Rob Herring wrote: > > > On Mon, 06 Jun 2022 13:11:29 +0800, Bo-Chen Chen wrote: > > > > From: "Nancy.Lin" <nancy.lin@mediatek.com> > > > > > > > > Add vdosys1 RDMA definition. > > > > > > > > Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com> > > > > Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com> > > > > Reviewed-by: AngeloGioacchino Del Regno < > > > > angelogioacchino.delregno@collabora.com> > > > > Reviewed-by: Krzysztof Kozlowski < > > > > krzysztof.kozlowski@linaro.org> > > > > Tested-by: AngeloGioacchino Del Regno < > > > > angelogioacchino.delregno@collabora.com> > > > > --- > > > > .../display/mediatek/mediatek,mdp-rdma.yaml | 88 > > > > +++++++++++++++++++ > > > > 1 file changed, 88 insertions(+) > > > > create mode 100644 > > > > Documentation/devicetree/bindings/display/mediatek/mediatek,mdp > > > > - > > > > rdma.yaml > > > > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m > > > dt_binding_check' > > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > > > yamllint warnings/errors: > > > > > > dtschema/dtc warnings/errors: > > > /builds/robherring/linux-dt- > > > review/Documentation/devicetree/bindings/display/mediatek/mediate > > > k,md > > > p-rdma.yaml: properties:compatible: [{'const': 'mediatek,mt8195- > > > vdo1- > > > rdma'}] is not of type 'object', 'boolean' > > > from schema $id: > > > https://urldefense.com/v3/__http://json-schema.org/draft-07/schema*__;Iw!!CTRNKA9wMg0ARbw!3hhZrSKSWnCN5Bha9laiHlB5JCx9_p-ksaYDZmoCLQRi1tI4KJCcTJQva2vds3j3bwKF$ > > > > > > /builds/robherring/linux-dt- > > > review/Documentation/devicetree/bindings/display/mediatek/mediate > > > k,md > > > p-rdma.yaml: ignoring, error in schema: properties: compatible > > > Documentation/devicetree/bindings/display/mediatek/mediatek,mdp- > > > rdma.example.dtb:0:0: /example-0/soc/rdma@1c104000: failed to > > > match > > > any schema with compatible: ['mediatek,mt8195-vdo1-rdma'] > > > > > > doc reference errors (make refcheckdocs): > > > > > > See https://patchwork.ozlabs.org/patch/ > > > > > > This check can fail if there are any dependencies. The base for a > > > patch > > > series is generally the most recent rc1. > > > > > > If you already ran 'make dt_binding_check' and didn't see the > > > above > > > error(s), then make sure 'yamllint' is installed and dt-schema is > > > up > > > to > > > date: > > > > > > pip3 install dtschema --upgrade > > > > > > Please check and re-submit. > > > > > > > Hello Rob, > > > > We found that if we write this, and the error will disapear: > > properties: > > compatible: > > - - const: mediatek,mt8195-vdo1-rdma > > + items: > > + - const: mediatek,mt8195-vdo1-rdma > > > > But from Krzysztof's review[1], he adviced us to drop items. > > > > Is there any suggsetion for this error or do we have any > > misunderstanding? > > The '-' is important. > > compatible: > const: mediatek,mt8195-vdo1-rdma Hello Rob, Thanks for hint. I will update this and resend. BRs, Rex
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml new file mode 100644 index 000000000000..678abb321cc2 --- /dev/null +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml @@ -0,0 +1,88 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/mediatek/mediatek,mdp-rdma.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MediaTek MDP RDMA + +maintainers: + - Chun-Kuang Hu <chunkuang.hu@kernel.org> + - Philipp Zabel <p.zabel@pengutronix.de> + +description: + The MediaTek MDP RDMA stands for Read Direct Memory Access. + It provides real time data to the back-end panel driver, such as DSI, + DPI and DP_INTF. + It contains one line buffer to store the sufficient pixel data. + RDMA device node must be siblings to the central MMSYS_CONFIG node. + For a description of the MMSYS_CONFIG binding, see + Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml for details. + +properties: + compatible: + - const: mediatek,mt8195-vdo1-rdma + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + power-domains: + maxItems: 1 + + clocks: + items: + - description: RDMA Clock + + iommus: + maxItems: 1 + + mediatek,gce-client-reg: + description: + The register of display function block to be set by gce. There are 4 arguments, + such as gce node, subsys id, offset and register size. The subsys id that is + mapping to the register of display function blocks is defined in the gce header + include/dt-bindings/gce/<chip>-gce.h of each chips. + $ref: /schemas/types.yaml#/definitions/phandle-array + items: + items: + - description: phandle of GCE + - description: GCE subsys id + - description: register offset + - description: register size + maxItems: 1 + +required: + - compatible + - reg + - power-domains + - clocks + - iommus + - mediatek,gce-client-reg + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/clock/mt8195-clk.h> + #include <dt-bindings/power/mt8195-power.h> + #include <dt-bindings/gce/mt8195-gce.h> + #include <dt-bindings/memory/mt8195-memory-port.h> + + soc { + #address-cells = <2>; + #size-cells = <2>; + + rdma@1c104000 { + compatible = "mediatek,mt8195-vdo1-rdma"; + reg = <0 0x1c104000 0 0x1000>; + interrupts = <GIC_SPI 495 IRQ_TYPE_LEVEL_HIGH 0>; + clocks = <&vdosys1 CLK_VDO1_MDP_RDMA0>; + power-domains = <&spm MT8195_POWER_DOMAIN_VDOSYS1>; + iommus = <&iommu_vdo M4U_PORT_L2_MDP_RDMA0>; + mediatek,gce-client-reg = <&gce0 SUBSYS_1c10XXXX 0x4000 0x1000>; + }; + };