| Message ID | 20220609113911.380368-3-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | dt-bindings: input: gpio-keys: rework matching children | expand |
On Thu, Jun 09, 2022 at 01:39:06PM +0200, Krzysztof Kozlowski wrote: > gpio-keys schema requires keys to have more generic name. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml > index 47a56b83a610..4c7691c38b10 100644 > --- a/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml > @@ -152,7 +152,7 @@ examples: > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_uid>, <&pinmux_uid>; > > - uid { > + switch-uid { In this example, and more importantly the original copy in nuvoton-wpcm450-supermicro-x9sci-ln4f.dts, I think button-uid fits slightly better, because it's a momentary push button. (Still arguably a switch, but not one that would stay in both the on and off position.) Thanks, Jonathan
On 09/06/2022 17:20, Jonathan Neuschäfer wrote: > On Thu, Jun 09, 2022 at 01:39:06PM +0200, Krzysztof Kozlowski wrote: >> gpio-keys schema requires keys to have more generic name. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> .../devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml >> index 47a56b83a610..4c7691c38b10 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml >> +++ b/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml >> @@ -152,7 +152,7 @@ examples: >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_uid>, <&pinmux_uid>; >> >> - uid { >> + switch-uid { > > In this example, and more importantly the original copy in > nuvoton-wpcm450-supermicro-x9sci-ln4f.dts, I think button-uid fits > slightly better, because it's a momentary push button. (Still arguably a > switch, but not one that would stay in both the on and off position.) Sure, I'll change it to button-uid. Thanks! Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml index 47a56b83a610..4c7691c38b10 100644 --- a/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml @@ -152,7 +152,7 @@ examples: pinctrl-names = "default"; pinctrl-0 = <&pinctrl_uid>, <&pinmux_uid>; - uid { + switch-uid { label = "UID"; linux,code = <102>; gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>;
gpio-keys schema requires keys to have more generic name. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)