diff mbox series

[1/1] MIPS: Loongson-3: fix compile mips cpu_hwmon as module build error.

Message ID 20220608011229.2056016-1-liyupeng@zbhlos.com (mailing list archive)
State Accepted
Commit 41e456400212803704e82691716e1d7b0865114a
Headers show
Series [1/1] MIPS: Loongson-3: fix compile mips cpu_hwmon as module build error. | expand

Commit Message

Yupeng Li June 8, 2022, 1:12 a.m. UTC
set cpu_hwmon as a module build with loongson_sysconf, loongson_chiptemp
  undefined error,fix cpu_hwmon compile options to be bool.Some kernel
  compilation error information is as follows:

  Checking missing-syscalls for N32
  CALL    scripts/checksyscalls.sh
  Checking missing-syscalls for O32
  CALL    scripts/checksyscalls.sh
  CALL    scripts/checksyscalls.sh
  CHK     include/generated/compile.h
  CC [M]  drivers/platform/mips/cpu_hwmon.o
  Building modules, stage 2.
  MODPOST 200 modules
ERROR: "loongson_sysconf" [drivers/platform/mips/cpu_hwmon.ko] undefined!
ERROR: "loongson_chiptemp" [drivers/platform/mips/cpu_hwmon.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:92:__modpost] 错误 1
make: *** [Makefile:1261:modules] 错误 2

Signed-off-by: Yupeng Li <liyupeng@zbhlos.com>
---
 drivers/platform/mips/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Huacai Chen June 8, 2022, 4:11 a.m. UTC | #1
Reviewed-by: Huacai Chen <chenhuacai@kernel.org>

On Wed, Jun 8, 2022 at 9:41 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 6/7/22 18:12, Yupeng Li wrote:
> >    set cpu_hwmon as a module build with loongson_sysconf, loongson_chiptemp
> >    undefined error,fix cpu_hwmon compile options to be bool.Some kernel
> >    compilation error information is as follows:
> >
> >    Checking missing-syscalls for N32
> >    CALL    scripts/checksyscalls.sh
> >    Checking missing-syscalls for O32
> >    CALL    scripts/checksyscalls.sh
> >    CALL    scripts/checksyscalls.sh
> >    CHK     include/generated/compile.h
> >    CC [M]  drivers/platform/mips/cpu_hwmon.o
> >    Building modules, stage 2.
> >    MODPOST 200 modules
> > ERROR: "loongson_sysconf" [drivers/platform/mips/cpu_hwmon.ko] undefined!
> > ERROR: "loongson_chiptemp" [drivers/platform/mips/cpu_hwmon.ko] undefined!
> > make[1]: *** [scripts/Makefile.modpost:92:__modpost] 错误 1
> > make: *** [Makefile:1261:modules] 错误 2
> >
> > Signed-off-by: Yupeng Li <liyupeng@zbhlos.com>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
> > ---
> >   drivers/platform/mips/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/mips/Kconfig b/drivers/platform/mips/Kconfig
> > index d421e1482395..6b51ad01f791 100644
> > --- a/drivers/platform/mips/Kconfig
> > +++ b/drivers/platform/mips/Kconfig
> > @@ -17,7 +17,7 @@ menuconfig MIPS_PLATFORM_DEVICES
> >   if MIPS_PLATFORM_DEVICES
> >
> >   config CPU_HWMON
> > -     tristate "Loongson-3 CPU HWMon Driver"
> > +     bool "Loongson-3 CPU HWMon Driver"
> >       depends on MACH_LOONGSON64
> >       select HWMON
> >       default y
>
Thomas Bogendoerfer June 9, 2022, 8:25 p.m. UTC | #2
On Wed, Jun 08, 2022 at 09:12:29AM +0800, Yupeng Li wrote:
>   set cpu_hwmon as a module build with loongson_sysconf, loongson_chiptemp
>   undefined error,fix cpu_hwmon compile options to be bool.Some kernel
>   compilation error information is as follows:
> 
>   Checking missing-syscalls for N32
>   CALL    scripts/checksyscalls.sh
>   Checking missing-syscalls for O32
>   CALL    scripts/checksyscalls.sh
>   CALL    scripts/checksyscalls.sh
>   CHK     include/generated/compile.h
>   CC [M]  drivers/platform/mips/cpu_hwmon.o
>   Building modules, stage 2.
>   MODPOST 200 modules
> ERROR: "loongson_sysconf" [drivers/platform/mips/cpu_hwmon.ko] undefined!
> ERROR: "loongson_chiptemp" [drivers/platform/mips/cpu_hwmon.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:92:__modpost] 错误 1
> make: *** [Makefile:1261:modules] 错误 2
> 
> Signed-off-by: Yupeng Li <liyupeng@zbhlos.com>
> ---
>  drivers/platform/mips/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/mips/Kconfig b/drivers/platform/mips/Kconfig
> index d421e1482395..6b51ad01f791 100644
> --- a/drivers/platform/mips/Kconfig
> +++ b/drivers/platform/mips/Kconfig
> @@ -17,7 +17,7 @@ menuconfig MIPS_PLATFORM_DEVICES
>  if MIPS_PLATFORM_DEVICES
>  
>  config CPU_HWMON
> -	tristate "Loongson-3 CPU HWMon Driver"
> +	bool "Loongson-3 CPU HWMon Driver"
>  	depends on MACH_LOONGSON64
>  	select HWMON
>  	default y
> -- 
> 2.34.1

applied to mips-fixes.

Thomas.
diff mbox series

Patch

diff --git a/drivers/platform/mips/Kconfig b/drivers/platform/mips/Kconfig
index d421e1482395..6b51ad01f791 100644
--- a/drivers/platform/mips/Kconfig
+++ b/drivers/platform/mips/Kconfig
@@ -17,7 +17,7 @@  menuconfig MIPS_PLATFORM_DEVICES
 if MIPS_PLATFORM_DEVICES
 
 config CPU_HWMON
-	tristate "Loongson-3 CPU HWMon Driver"
+	bool "Loongson-3 CPU HWMon Driver"
 	depends on MACH_LOONGSON64
 	select HWMON
 	default y