mbox series

[0/5] misc update for openclose and provided buffer

Message ID 20220610090734.857067-1-hao.xu@linux.dev (mailing list archive)
Headers show
Series misc update for openclose and provided buffer | expand

Message

Hao Xu June 10, 2022, 9:07 a.m. UTC
From: Hao Xu <howeyxu@tencent.com>

Patch 1 and 2 are bug fixes for openclose
Patch 3 is to support better close logic
Patch 4 is code clean
Patch 5 is a bug fix for ring-mapped provided buffer

Hao Xu (5):
  io_uring: openclose: fix bug of closing wrong fixed file
  io_uring: openclose: fix bug of unexpected return value in
    IORING_CLOSE_FD_AND_FILE_SLOT mode
  io_uring: openclose: support separate return value for
    IORING_CLOSE_FD_AND_FILE_SLOT
  io_uring: remove duplicate kbuf release
  io_uring: kbuf: consume ring buffer in partial io case

 io_uring/io_uring.c  |  6 ------
 io_uring/kbuf.c      |  9 +++++++--
 io_uring/kbuf.h      | 10 ++++++++--
 io_uring/openclose.c | 10 +++++++---
 io_uring/rsrc.c      |  2 +-
 5 files changed, 23 insertions(+), 14 deletions(-)

Comments

Pavel Begunkov June 10, 2022, 10:13 a.m. UTC | #1
On 6/10/22 10:07, Hao Xu wrote:
> From: Hao Xu <howeyxu@tencent.com>
> 
> Patch 1 and 2 are bug fixes for openclose
> Patch 3 is to support better close logic
> Patch 4 is code clean
> Patch 5 is a bug fix for ring-mapped provided buffer

Looks that at least the problem from 1/5 also exists in 5.19,
can you split out 5.19 fixes and send them separately?


> Hao Xu (5):
>    io_uring: openclose: fix bug of closing wrong fixed file
>    io_uring: openclose: fix bug of unexpected return value in
>      IORING_CLOSE_FD_AND_FILE_SLOT mode
>    io_uring: openclose: support separate return value for
>      IORING_CLOSE_FD_AND_FILE_SLOT
>    io_uring: remove duplicate kbuf release
>    io_uring: kbuf: consume ring buffer in partial io case
> 
>   io_uring/io_uring.c  |  6 ------
>   io_uring/kbuf.c      |  9 +++++++--
>   io_uring/kbuf.h      | 10 ++++++++--
>   io_uring/openclose.c | 10 +++++++---
>   io_uring/rsrc.c      |  2 +-
>   5 files changed, 23 insertions(+), 14 deletions(-)
>
Hao Xu June 10, 2022, 10:34 a.m. UTC | #2
On 6/10/22 18:13, Pavel Begunkov wrote:
> On 6/10/22 10:07, Hao Xu wrote:
>> From: Hao Xu <howeyxu@tencent.com>
>>
>> Patch 1 and 2 are bug fixes for openclose
>> Patch 3 is to support better close logic
>> Patch 4 is code clean
>> Patch 5 is a bug fix for ring-mapped provided buffer
> 
> Looks that at least the problem from 1/5 also exists in 5.19,
> can you split out 5.19 fixes and send them separately?

Sure.

> 
> 
>> Hao Xu (5):
>>    io_uring: openclose: fix bug of closing wrong fixed file
>>    io_uring: openclose: fix bug of unexpected return value in
>>      IORING_CLOSE_FD_AND_FILE_SLOT mode
>>    io_uring: openclose: support separate return value for
>>      IORING_CLOSE_FD_AND_FILE_SLOT
>>    io_uring: remove duplicate kbuf release
>>    io_uring: kbuf: consume ring buffer in partial io case
>>
>>   io_uring/io_uring.c  |  6 ------
>>   io_uring/kbuf.c      |  9 +++++++--
>>   io_uring/kbuf.h      | 10 ++++++++--
>>   io_uring/openclose.c | 10 +++++++---
>>   io_uring/rsrc.c      |  2 +-
>>   5 files changed, 23 insertions(+), 14 deletions(-)
>>
>