| Message ID | CAGcXWkzSrEPPT2m=2trWN-BV-ix9TcHCvZYya5i54ei=EWGTZw@mail.gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | Add thermal control driver for Sunplus SoC | expand |
On 10/06/2022 03:32, 郭力豪 wrote: > Add bindings for Sunplus thermal driver > > Signed-off-by: Li-hao Kuo <lhjeff911@gmail.com> Thank you for your patch. There is something to discuss/improve. > --- > Changes in v9: > - Change the setting of compatible > - Mosdify the setting of remove funciton. Your subject misses space after "dt-bindings:". Look at other patches how they are named. Please fix it. Normally I would give conditional review, but I am afraid it you won't fix it, based on our previous history here. :( So sorry, but for such small change, I expect v10. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/thermal/sunplus,thermal.yaml b/Documentation/devicetree/bindings/thermal/sunplus,thermal.yaml new file mode 100644 index 0000000..52094da --- /dev/null +++ b/Documentation/devicetree/bindings/thermal/sunplus,thermal.yaml @@ -0,0 +1,43 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright (C) Sunplus Co., Ltd. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/thermal/sunplus,thermal.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sunplus Thermal controller + +maintainers: + - Li-hao Kuo <lhjeff911@gmail.com> + +properties: + compatible: + enum: + - sunplus,sp7021-thermal + + reg: + maxItems: 1 + + nvmem-cells: + maxItems: 1 + + nvmem-cell-names: + const: calib + +required: + - compatible + - reg + - nvmem-cells + - nvmem-cell-names + +additionalProperties: false + +examples: + - | + thermal@9c000280 { + compatible = "sunplus,sp7021-thermal"; + reg = <0x9c000280 0xc>; + nvmem-cells = <&calib>; + nvmem-cell-names = "calib"; + }; +... diff --git a/MAINTAINERS b/MAINTAINERS index 23bde07..a8c44eb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -19107,6 +19107,7 @@ SUNPLUS THERMAL DRIVER M: Li-hao Kuo <lhjeff911@gmail.com> L: linux-pm@vger.kernel.org S: Maintained +F: Documentation/devicetree/bindings/thermal/sunplus_thermal.yaml F: drivers/thermal/sunplus_thermal.c SUNPLUS UART DRIVER
Add bindings for Sunplus thermal driver Signed-off-by: Li-hao Kuo <lhjeff911@gmail.com> --- Changes in v9: - Change the setting of compatible - Mosdify the setting of remove funciton. .../bindings/thermal/sunplus,thermal.yaml | 43 ++++++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 44 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/sunplus,thermal.yaml