| Message ID | 20220609162729.1441760-1-andre.przywara@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: display: arm,malidp: remove bogus RQOS property | expand |
On Thu, Jun 09, 2022 at 05:27:29PM +0100, Andre Przywara wrote: > As Liviu pointed out, the arm,malidp-arqos-high-level property > mentioned in the original .txt binding was a mistake, and > arm,malidp-arqos-value needs to take its place. > > The binding commit ce6eb0253cba ("dt/bindings: display: Add optional > property node define for Mali DP500") mentions the right name in the > commit message, but has the wrong name in the diff. > Commit d298e6a27a81 ("drm/arm/mali-dp: Add display QoS interface > configuration for Mali DP500") uses the property in the driver, but uses > the shorter name. > > Remove the wrong property from the binding, and use the proper name in > the example. The actual property was already documented properly. > > Fixes: 2c8b082a3ab1 ("dt-bindings: display: convert Arm Mali-DP to DT schema") > Link: https://lore.kernel.org/linux-arm-kernel/YnumGEilUblhBx8E@e110455-lin.cambridge.arm.com/ > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > Reported-by: Liviu Dudau <liviu.dudau@arm.com> Reviewed-by: Liviu Dudau <liviu.dudau@arm.com> Thanks for cleaning this up! Best regards, Liviu > --- > Documentation/devicetree/bindings/display/arm,malidp.yaml | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/arm,malidp.yaml b/Documentation/devicetree/bindings/display/arm,malidp.yaml > index 795a08ac9f128..2a17ec6fc97c0 100644 > --- a/Documentation/devicetree/bindings/display/arm,malidp.yaml > +++ b/Documentation/devicetree/bindings/display/arm,malidp.yaml > @@ -71,11 +71,6 @@ properties: > - description: number of output lines for the green channel (G) > - description: number of output lines for the blue channel (B) > > - arm,malidp-arqos-high-level: > - $ref: /schemas/types.yaml#/definitions/uint32 > - description: > - integer describing the ARQoS levels of DP500's QoS signaling > - > arm,malidp-arqos-value: > $ref: /schemas/types.yaml#/definitions/uint32 > description: > @@ -113,7 +108,7 @@ examples: > clocks = <&oscclk2>, <&fpgaosc0>, <&fpgaosc1>, <&fpgaosc1>; > clock-names = "pxlclk", "mclk", "aclk", "pclk"; > arm,malidp-output-port-lines = /bits/ 8 <8 8 8>; > - arm,malidp-arqos-high-level = <0xd000d000>; > + arm,malidp-arqos-value = <0xd000d000>; > > port { > dp0_output: endpoint { > -- > 2.25.1 >
On Thu, 09 Jun 2022 17:27:29 +0100, Andre Przywara wrote: > As Liviu pointed out, the arm,malidp-arqos-high-level property > mentioned in the original .txt binding was a mistake, and > arm,malidp-arqos-value needs to take its place. > > The binding commit ce6eb0253cba ("dt/bindings: display: Add optional > property node define for Mali DP500") mentions the right name in the > commit message, but has the wrong name in the diff. > Commit d298e6a27a81 ("drm/arm/mali-dp: Add display QoS interface > configuration for Mali DP500") uses the property in the driver, but uses > the shorter name. > > Remove the wrong property from the binding, and use the proper name in > the example. The actual property was already documented properly. > > Fixes: 2c8b082a3ab1 ("dt-bindings: display: convert Arm Mali-DP to DT schema") > Link: https://lore.kernel.org/linux-arm-kernel/YnumGEilUblhBx8E@e110455-lin.cambridge.arm.com/ > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > Reported-by: Liviu Dudau <liviu.dudau@arm.com> > --- > Documentation/devicetree/bindings/display/arm,malidp.yaml | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > Applied, thanks!
diff --git a/Documentation/devicetree/bindings/display/arm,malidp.yaml b/Documentation/devicetree/bindings/display/arm,malidp.yaml index 795a08ac9f128..2a17ec6fc97c0 100644 --- a/Documentation/devicetree/bindings/display/arm,malidp.yaml +++ b/Documentation/devicetree/bindings/display/arm,malidp.yaml @@ -71,11 +71,6 @@ properties: - description: number of output lines for the green channel (G) - description: number of output lines for the blue channel (B) - arm,malidp-arqos-high-level: - $ref: /schemas/types.yaml#/definitions/uint32 - description: - integer describing the ARQoS levels of DP500's QoS signaling - arm,malidp-arqos-value: $ref: /schemas/types.yaml#/definitions/uint32 description: @@ -113,7 +108,7 @@ examples: clocks = <&oscclk2>, <&fpgaosc0>, <&fpgaosc1>, <&fpgaosc1>; clock-names = "pxlclk", "mclk", "aclk", "pclk"; arm,malidp-output-port-lines = /bits/ 8 <8 8 8>; - arm,malidp-arqos-high-level = <0xd000d000>; + arm,malidp-arqos-value = <0xd000d000>; port { dp0_output: endpoint {
As Liviu pointed out, the arm,malidp-arqos-high-level property mentioned in the original .txt binding was a mistake, and arm,malidp-arqos-value needs to take its place. The binding commit ce6eb0253cba ("dt/bindings: display: Add optional property node define for Mali DP500") mentions the right name in the commit message, but has the wrong name in the diff. Commit d298e6a27a81 ("drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500") uses the property in the driver, but uses the shorter name. Remove the wrong property from the binding, and use the proper name in the example. The actual property was already documented properly. Fixes: 2c8b082a3ab1 ("dt-bindings: display: convert Arm Mali-DP to DT schema") Link: https://lore.kernel.org/linux-arm-kernel/YnumGEilUblhBx8E@e110455-lin.cambridge.arm.com/ Signed-off-by: Andre Przywara <andre.przywara@arm.com> Reported-by: Liviu Dudau <liviu.dudau@arm.com> --- Documentation/devicetree/bindings/display/arm,malidp.yaml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)