diff mbox series

genirq/PM: Unexport {suspend,resume}_device_irqs()

Message ID fad9b50609f9d9828ea14772dbd4d195713f1c4b.1654846687.git.lukas@wunner.de (mailing list archive)
State Handled Elsewhere, archived
Headers show
Series genirq/PM: Unexport {suspend,resume}_device_irqs() | expand

Commit Message

Lukas Wunner June 10, 2022, 7:40 a.m. UTC
Ever since {suspend,resume}_device_irqs() were introduced in 2009
by commit 0a0c5168df27 ("PM: Introduce functions for suspending and
resuming device interrupts"), they've been exported even though there
are no module users and never will be:  The functions are solely called
by the PM core, which is always built-in.  Unexport them.

Signed-off-by: Lukas Wunner <lukas@wunner.de>
---
 kernel/irq/pm.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Rafael J. Wysocki June 10, 2022, 1:33 p.m. UTC | #1
On Fri, Jun 10, 2022 at 9:41 AM Lukas Wunner <lukas@wunner.de> wrote:
>
> Ever since {suspend,resume}_device_irqs() were introduced in 2009
> by commit 0a0c5168df27 ("PM: Introduce functions for suspending and
> resuming device interrupts"), they've been exported even though there
> are no module users and never will be:  The functions are solely called
> by the PM core, which is always built-in.  Unexport them.
>
> Signed-off-by: Lukas Wunner <lukas@wunner.de>

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

or I can take it if no one else does.

> ---
>  kernel/irq/pm.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/kernel/irq/pm.c b/kernel/irq/pm.c
> index ca71123a6130..c556bc49d213 100644
> --- a/kernel/irq/pm.c
> +++ b/kernel/irq/pm.c
> @@ -147,7 +147,6 @@ void suspend_device_irqs(void)
>                         synchronize_irq(irq);
>         }
>  }
> -EXPORT_SYMBOL_GPL(suspend_device_irqs);
>
>  static void resume_irq(struct irq_desc *desc)
>  {
> @@ -259,4 +258,3 @@ void resume_device_irqs(void)
>  {
>         resume_irqs(false);
>  }
> -EXPORT_SYMBOL_GPL(resume_device_irqs);
> --
> 2.35.2
>
diff mbox series

Patch

diff --git a/kernel/irq/pm.c b/kernel/irq/pm.c
index ca71123a6130..c556bc49d213 100644
--- a/kernel/irq/pm.c
+++ b/kernel/irq/pm.c
@@ -147,7 +147,6 @@  void suspend_device_irqs(void)
 			synchronize_irq(irq);
 	}
 }
-EXPORT_SYMBOL_GPL(suspend_device_irqs);
 
 static void resume_irq(struct irq_desc *desc)
 {
@@ -259,4 +258,3 @@  void resume_device_irqs(void)
 {
 	resume_irqs(false);
 }
-EXPORT_SYMBOL_GPL(resume_device_irqs);