| Message ID | 20220610084545.547700-7-nuno.sa@analog.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | make iio inkern interface firmware agnostic | expand |
On Fri, Jun 10, 2022 at 10:46 AM Nuno Sá <nuno.sa@analog.com> wrote: > > Do not trust the fact that iio.h includes of.h which in turn includes > all the headers we are relying on. > > The ultimate goal is to actually drop of.h from iio.h. ... > #include <linux/mod_devicetable.h> > #include <linux/mutex.h> > #include <linux/platform_device.h> > +#include <linux/property.h> > +#include <linux/of.h> Ordering (from the context I don't see it's messed up already)
On Fri, 2022-06-10 at 16:45 +0200, Andy Shevchenko wrote: > On Fri, Jun 10, 2022 at 10:46 AM Nuno Sá <nuno.sa@analog.com> wrote: > > > > Do not trust the fact that iio.h includes of.h which in turn > > includes > > all the headers we are relying on. > > > > The ultimate goal is to actually drop of.h from iio.h. > > ... > > > #include <linux/mod_devicetable.h> > > #include <linux/mutex.h> > > #include <linux/platform_device.h> > > +#include <linux/property.h> > > +#include <linux/of.h> > > Ordering (from the context I don't see it's messed up already) > Will double check on v2... - Nuno Sá
On Fri, 10 Jun 2022 21:49:22 +0200 Nuno Sá <noname.nuno@gmail.com> wrote: > On Fri, 2022-06-10 at 16:45 +0200, Andy Shevchenko wrote: > > On Fri, Jun 10, 2022 at 10:46 AM Nuno Sá <nuno.sa@analog.com> wrote: > > > > > > Do not trust the fact that iio.h includes of.h which in turn > > > includes > > > all the headers we are relying on. > > > > > > The ultimate goal is to actually drop of.h from iio.h. > > > > ... > > > > > #include <linux/mod_devicetable.h> > > > #include <linux/mutex.h> > > > #include <linux/platform_device.h> > > > +#include <linux/property.h> > > > +#include <linux/of.h> > > > > Ordering (from the context I don't see it's messed up already) > > > > Will double check on v2... Fixed up whilst applying... > > - Nuno Sá
diff --git a/drivers/iio/adc/ingenic-adc.c b/drivers/iio/adc/ingenic-adc.c index 2b3912c6ca6b..e731ba47add2 100644 --- a/drivers/iio/adc/ingenic-adc.c +++ b/drivers/iio/adc/ingenic-adc.c @@ -18,6 +18,8 @@ #include <linux/mod_devicetable.h> #include <linux/mutex.h> #include <linux/platform_device.h> +#include <linux/property.h> +#include <linux/of.h> #define JZ_ADC_REG_ENABLE 0x00 #define JZ_ADC_REG_CFG 0x04
Do not trust the fact that iio.h includes of.h which in turn includes all the headers we are relying on. The ultimate goal is to actually drop of.h from iio.h. Signed-off-by: Nuno Sá <nuno.sa@analog.com> --- drivers/iio/adc/ingenic-adc.c | 2 ++ 1 file changed, 2 insertions(+)