| Message ID | 1654793615-21290-1-git-send-email-radhey.shyam.pandey@amd.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3a51e969fa90da2a904597249a772224243ab4b5 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2,net-next] dt-bindings: net: xilinx: document xilinx emaclite driver binding | expand |
On Thu, 2022-06-09 at 22:23 +0530, Radhey Shyam Pandey wrote: > Add basic description for the xilinx emaclite driver DT bindings. > > Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com> Even if marked for 'net-next', my understanding is that should go via the device tree repo. I'm dropping from the netdev patchwork, please correct me if I'm wrong, thanks! Paolo
[AMD Official Use Only - General] > -----Original Message----- > From: Paolo Abeni <pabeni@redhat.com> > Sent: Tuesday, June 14, 2022 2:40 PM > To: Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com>; > davem@davemloft.net; edumazet@google.com; kuba@kernel.org; > robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; Katakam, Harini > <harini.katakam@amd.com> > Cc: netdev@vger.kernel.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; git (AMD-Xilinx) <git@amd.com> > Subject: Re: [PATCH v2 net-next] dt-bindings: net: xilinx: document xilinx > emaclite driver binding > > On Thu, 2022-06-09 at 22:23 +0530, Radhey Shyam Pandey wrote: > > Add basic description for the xilinx emaclite driver DT bindings. > > > > Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com> > > Even if marked for 'net-next', my understanding is that should go via the > device tree repo. I'm dropping from the netdev patchwork, please correct me if > I'm wrong, thanks! I have seen a mixed set of the convention for dts patches. They are following both routes i.e device tree or subsystem repos provided acked from device tree maintainer. If there is preference for device tree repo then I can drop net-next from subject prefix and resend it for the dt repo. > > Paolo
On 14/06/2022 14:09, Pandey, Radhey Shyam wrote: > [AMD Official Use Only - General] > >> -----Original Message----- >> From: Paolo Abeni <pabeni@redhat.com> >> Sent: Tuesday, June 14, 2022 2:40 PM >> To: Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com>; >> davem@davemloft.net; edumazet@google.com; kuba@kernel.org; >> robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; Katakam, Harini >> <harini.katakam@amd.com> >> Cc: netdev@vger.kernel.org; devicetree@vger.kernel.org; linux- >> kernel@vger.kernel.org; git (AMD-Xilinx) <git@amd.com> >> Subject: Re: [PATCH v2 net-next] dt-bindings: net: xilinx: document xilinx >> emaclite driver binding >> >> On Thu, 2022-06-09 at 22:23 +0530, Radhey Shyam Pandey wrote: >>> Add basic description for the xilinx emaclite driver DT bindings. >>> >>> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com> >> >> Even if marked for 'net-next', my understanding is that should go via the >> device tree repo. I'm dropping from the netdev patchwork, please correct me if >> I'm wrong, thanks! > > I have seen a mixed set of the convention for dts patches. They are following > both routes i.e device tree or subsystem repos provided acked from device > tree maintainer. If there is preference for device tree repo then I can drop > net-next from subject prefix and resend it for the dt repo. If you got Ack from Devicetree bindings maintainer (Rob Herring or me), then feel free to take it via net-next. I think, it is actually preferred, unless this is some fix which needs to go via DT (Rob's) tree. If you don't have these acks, then better don't take it :) unless it's really waiting too long on the lists. I hope it's not that case. Best regards, Krzysztof
On 14/06/2022 15:48, Krzysztof Kozlowski wrote: > On 14/06/2022 14:09, Pandey, Radhey Shyam wrote: >> [AMD Official Use Only - General] >> >>> -----Original Message----- >>> From: Paolo Abeni <pabeni@redhat.com> >>> Sent: Tuesday, June 14, 2022 2:40 PM >>> To: Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com>; >>> davem@davemloft.net; edumazet@google.com; kuba@kernel.org; >>> robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; Katakam, Harini >>> <harini.katakam@amd.com> >>> Cc: netdev@vger.kernel.org; devicetree@vger.kernel.org; linux- >>> kernel@vger.kernel.org; git (AMD-Xilinx) <git@amd.com> >>> Subject: Re: [PATCH v2 net-next] dt-bindings: net: xilinx: document xilinx >>> emaclite driver binding >>> >>> On Thu, 2022-06-09 at 22:23 +0530, Radhey Shyam Pandey wrote: >>>> Add basic description for the xilinx emaclite driver DT bindings. >>>> >>>> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com> >>> >>> Even if marked for 'net-next', my understanding is that should go via the >>> device tree repo. I'm dropping from the netdev patchwork, please correct me if >>> I'm wrong, thanks! >> >> I have seen a mixed set of the convention for dts patches. They are following >> both routes i.e device tree or subsystem repos provided acked from device >> tree maintainer. If there is preference for device tree repo then I can drop >> net-next from subject prefix and resend it for the dt repo. > > If you got Ack from Devicetree bindings maintainer (Rob Herring or me), > then feel free to take it via net-next. I think, it is actually > preferred, unless this is some fix which needs to go via DT (Rob's) tree. > > If you don't have these acks, then better don't take it :) unless it's > really waiting too long on the lists. I hope it's not that case. I got this reply in my mailbox but I cannot find at all the original patch, which might explain why it was not acked. I found it on lore, though. Rob had here questions but I think you resolved/answered them, so from my side: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Tue, 14 Jun 2022 15:48:43 -0700 Krzysztof Kozlowski wrote: > > I have seen a mixed set of the convention for dts patches. They are following > > both routes i.e device tree or subsystem repos provided acked from device > > tree maintainer. If there is preference for device tree repo then I can drop > > net-next from subject prefix and resend it for the dt repo. > > If you got Ack from Devicetree bindings maintainer (Rob Herring or me), > then feel free to take it via net-next. I think, it is actually > preferred, unless this is some fix which needs to go via DT (Rob's) tree. > > If you don't have these acks, then better don't take it :) unless it's > really waiting too long on the lists. I hope it's not that case. GTK, thanks. I'm also often confused by the correct tree for DT patches. I'll revive the patch in PW and apply it later today.
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Thu, 9 Jun 2022 22:23:35 +0530 you wrote: > Add basic description for the xilinx emaclite driver DT bindings. > > Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com> > --- > Changes since v1: > - Move ethernet-controller.yaml reference after maintainers. > - Drop interrupt second cell in example node. > - Set local-mac-address to all 0s in example node. > - Put the reg after compatible in DTS code. > > [...] Here is the summary with links: - [v2,net-next] dt-bindings: net: xilinx: document xilinx emaclite driver binding https://git.kernel.org/netdev/net-next/c/3a51e969fa90 You are awesome, thank you!
On Tue, Jun 14, 2022 at 7:54 PM Jakub Kicinski <kuba@kernel.org> wrote: > > On Tue, 14 Jun 2022 15:48:43 -0700 Krzysztof Kozlowski wrote: > > > I have seen a mixed set of the convention for dts patches. They are following > > > both routes i.e device tree or subsystem repos provided acked from device > > > tree maintainer. If there is preference for device tree repo then I can drop > > > net-next from subject prefix and resend it for the dt repo. > > > > If you got Ack from Devicetree bindings maintainer (Rob Herring or me), > > then feel free to take it via net-next. I think, it is actually > > preferred, unless this is some fix which needs to go via DT (Rob's) tree. > > > > If you don't have these acks, then better don't take it :) unless it's > > really waiting too long on the lists. I hope it's not that case. > > GTK, thanks. I'm also often confused by the correct tree for DT patches. It is documented in Documentation/devicetree/bindings/submitting-patches.rst, section II. The default is bindings should go thru subsystem trees. Given netdev's tendency to apply bindings before DT review and even semi-automated checks, but skipping standalone patches, I haven't minded picking them up. Rob
diff --git a/Documentation/devicetree/bindings/net/xlnx,emaclite.yaml b/Documentation/devicetree/bindings/net/xlnx,emaclite.yaml new file mode 100644 index 000000000000..92d8ade988f6 --- /dev/null +++ b/Documentation/devicetree/bindings/net/xlnx,emaclite.yaml @@ -0,0 +1,63 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/xlnx,emaclite.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Xilinx Emaclite Ethernet controller + +maintainers: + - Radhey Shyam Pandey <radhey.shyam.pandey@amd.com> + - Harini Katakam <harini.katakam@amd.com> + +allOf: + - $ref: ethernet-controller.yaml# + +properties: + compatible: + enum: + - xlnx,opb-ethernetlite-1.01.a + - xlnx,opb-ethernetlite-1.01.b + - xlnx,xps-ethernetlite-1.00.a + - xlnx,xps-ethernetlite-2.00.a + - xlnx,xps-ethernetlite-2.01.a + - xlnx,xps-ethernetlite-3.00.a + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + phy-handle: true + + local-mac-address: true + + xlnx,tx-ping-pong: + type: boolean + description: hardware supports tx ping pong buffer. + + xlnx,rx-ping-pong: + type: boolean + description: hardware supports rx ping pong buffer. + +required: + - compatible + - reg + - interrupts + - phy-handle + +additionalProperties: false + +examples: + - | + axi_ethernetlite_1: ethernet@40e00000 { + compatible = "xlnx,xps-ethernetlite-3.00.a"; + reg = <0x40e00000 0x10000>; + interrupt-parent = <&axi_intc_1>; + interrupts = <1>; + local-mac-address = [00 00 00 00 00 00]; + phy-handle = <&phy0>; + xlnx,rx-ping-pong; + xlnx,tx-ping-pong; + };
Add basic description for the xilinx emaclite driver DT bindings. Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com> --- Changes since v1: - Move ethernet-controller.yaml reference after maintainers. - Drop interrupt second cell in example node. - Set local-mac-address to all 0s in example node. - Put the reg after compatible in DTS code. Changes since RFC: - Add ethernet-controller yaml reference. - 4 space indent for DTS example. --- .../bindings/net/xlnx,emaclite.yaml | 63 +++++++++++++++++++ 1 file changed, 63 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/xlnx,emaclite.yaml