| Message ID | 20220615120803.41350-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v1,1/1] iio: adc: intel_mrfld_adc: explicitly add proper header files | expand |
Hi Andy, > -----Original Message----- > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Sent: Wednesday, June 15, 2022 2:08 PM > To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; > Alexandru Ardelean <aardelean@deviqon.com>; linux- > iio@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: Jonathan Cameron <jic23@kernel.org>; Lars-Peter Clausen > <lars@metafoo.de> > Subject: [PATCH v1 1/1] iio: adc: intel_mrfld_adc: explicitly add proper > header files > > [External] > > Do not trust the fact that iio.h includes of.h which in turn includes > all the headers we are relying on. > > The ultimate goal is to actually drop of.h from iio.h. > > Signed-off-by: Andy Shevchenko > <andriy.shevchenko@linux.intel.com> > --- > > Jonathan, this should be squeezed before we remove of.h in iio.h > I think Nuno somehow missed this Yes, I did (compile) tested this on arm and arm64 as I said in the cover. I guess this one won't be enabled on those archs :). I was planning to send this on v2 (I did noticed the kernel test bot emails) but yeah, this should actually be included with the other patches before removing of.h from iio. Thanks! Reviewed-by: Nuno Sá <nuno.sa@analog.com>
On Wed, 15 Jun 2022 12:15:48 +0000 "Sa, Nuno" <Nuno.Sa@analog.com> wrote: > Hi Andy, > > > -----Original Message----- > > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Sent: Wednesday, June 15, 2022 2:08 PM > > To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; > > Alexandru Ardelean <aardelean@deviqon.com>; linux- > > iio@vger.kernel.org; linux-kernel@vger.kernel.org > > Cc: Jonathan Cameron <jic23@kernel.org>; Lars-Peter Clausen > > <lars@metafoo.de> > > Subject: [PATCH v1 1/1] iio: adc: intel_mrfld_adc: explicitly add proper > > header files > > > > [External] > > > > Do not trust the fact that iio.h includes of.h which in turn includes > > all the headers we are relying on. > > > > The ultimate goal is to actually drop of.h from iio.h. > > > > Signed-off-by: Andy Shevchenko > > <andriy.shevchenko@linux.intel.com> > > --- > > > > Jonathan, this should be squeezed before we remove of.h in iio.h > > I think Nuno somehow missed this > > Yes, I did (compile) tested this on arm and arm64 as I said in the cover. > I guess this one won't be enabled on those archs :). > > I was planning to send this on v2 (I did noticed the kernel test bot > emails) but yeah, this should actually be included with the other > patches before removing of.h from iio. Thanks! > > Reviewed-by: Nuno Sá <nuno.sa@analog.com> Applied. Oddly didn't show up in my normal x86 build test. As suggested, slotted in before the of.h removal patch. Thanks, Jonathan >
On Wed, 15 Jun 2022 22:09:30 +0100 Jonathan Cameron <jic23@kernel.org> wrote: > On Wed, 15 Jun 2022 12:15:48 +0000 > "Sa, Nuno" <Nuno.Sa@analog.com> wrote: > > > Hi Andy, > > > > > -----Original Message----- > > > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > Sent: Wednesday, June 15, 2022 2:08 PM > > > To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; > > > Alexandru Ardelean <aardelean@deviqon.com>; linux- > > > iio@vger.kernel.org; linux-kernel@vger.kernel.org > > > Cc: Jonathan Cameron <jic23@kernel.org>; Lars-Peter Clausen > > > <lars@metafoo.de> > > > Subject: [PATCH v1 1/1] iio: adc: intel_mrfld_adc: explicitly add proper > > > header files > > > > > > [External] > > > > > > Do not trust the fact that iio.h includes of.h which in turn includes > > > all the headers we are relying on. > > > > > > The ultimate goal is to actually drop of.h from iio.h. > > > > > > Signed-off-by: Andy Shevchenko > > > <andriy.shevchenko@linux.intel.com> > > > --- > > > > > > Jonathan, this should be squeezed before we remove of.h in iio.h > > > I think Nuno somehow missed this > > > > Yes, I did (compile) tested this on arm and arm64 as I said in the cover. > > I guess this one won't be enabled on those archs :). > > > > I was planning to send this on v2 (I did noticed the kernel test bot > > emails) but yeah, this should actually be included with the other > > patches before removing of.h from iio. Thanks! > > > > Reviewed-by: Nuno Sá <nuno.sa@analog.com> > > Applied. Oddly didn't show up in my normal x86 build test. Figured out the chain of necessary dependencies so I'll catch anything effecting this in my smoke test build going forwards. Thanks, Jonathan > > As suggested, slotted in before the of.h removal patch. > > Thanks, > > Jonathan > > > >
diff --git a/drivers/iio/adc/intel_mrfld_adc.c b/drivers/iio/adc/intel_mrfld_adc.c index 616de0c3a049..7263ad76124d 100644 --- a/drivers/iio/adc/intel_mrfld_adc.c +++ b/drivers/iio/adc/intel_mrfld_adc.c @@ -15,6 +15,7 @@ #include <linux/interrupt.h> #include <linux/mfd/intel_soc_pmic.h> #include <linux/mfd/intel_soc_pmic_mrfld.h> +#include <linux/mod_devicetable.h> #include <linux/module.h> #include <linux/mutex.h> #include <linux/platform_device.h>
Do not trust the fact that iio.h includes of.h which in turn includes all the headers we are relying on. The ultimate goal is to actually drop of.h from iio.h. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- Jonathan, this should be squeezed before we remove of.h in iio.h I think Nuno somehow missed this drivers/iio/adc/intel_mrfld_adc.c | 1 + 1 file changed, 1 insertion(+)