diff mbox series

bpf: fix bpf_skc_lookup comment wrt. return type

Message ID 20220617152121.29617-1-tklauser@distanz.ch (mailing list archive)
State Accepted
Commit f5be22c64bd6ee6c1cb0b34f4ff748d43879cd4c
Delegated to: BPF
Headers show
Series bpf: fix bpf_skc_lookup comment wrt. return type | expand

Checks

Context Check Description
bpf/vmtest-bpf-next-PR pending PR summary
netdev/tree_selection success Guessed tree name to be net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix warning Target tree name not specified in the subject
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 25 this patch: 25
netdev/cc_maintainers warning 9 maintainers not CCed: edumazet@google.com songliubraving@fb.com pabeni@redhat.com davem@davemloft.net yhs@fb.com john.fastabend@gmail.com kuba@kernel.org kafai@fb.com kpsingh@kernel.org
netdev/build_clang success Errors and warnings before: 6 this patch: 6
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 25 this patch: 25
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
bpf/vmtest-bpf-next-VM_Test-1 pending Logs for Kernel LATEST on ubuntu-latest with gcc
bpf/vmtest-bpf-next-VM_Test-2 pending Logs for Kernel LATEST on ubuntu-latest with llvm-15
bpf/vmtest-bpf-next-VM_Test-3 pending Logs for Kernel LATEST on z15 with gcc

Commit Message

Tobias Klauser June 17, 2022, 3:21 p.m. UTC
The function no longer returns 'unsigned long' as of commit edbf8c01de5a
("bpf: add skc_lookup_tcp helper").

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
 net/core/filter.c | 2 --
 1 file changed, 2 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org June 17, 2022, 4:40 p.m. UTC | #1
Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:

On Fri, 17 Jun 2022 17:21:21 +0200 you wrote:
> The function no longer returns 'unsigned long' as of commit edbf8c01de5a
> ("bpf: add skc_lookup_tcp helper").
> 
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
>  net/core/filter.c | 2 --
>  1 file changed, 2 deletions(-)

Here is the summary with links:
  - bpf: fix bpf_skc_lookup comment wrt. return type
    https://git.kernel.org/bpf/bpf-next/c/f5be22c64bd6

You are awesome, thank you!
diff mbox series

Patch

diff --git a/net/core/filter.c b/net/core/filter.c
index 5af58eb48587..89cb007b6a09 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -6463,8 +6463,6 @@  static struct sock *sk_lookup(struct net *net, struct bpf_sock_tuple *tuple,
 
 /* bpf_skc_lookup performs the core lookup for different types of sockets,
  * taking a reference on the socket if it doesn't have the flag SOCK_RCU_FREE.
- * Returns the socket as an 'unsigned long' to simplify the casting in the
- * callers to satisfy BPF_CALL declarations.
  */
 static struct sock *
 __bpf_skc_lookup(struct sk_buff *skb, struct bpf_sock_tuple *tuple, u32 len,