| Message ID | 20220603053529.76405-1-damien.lemoal@opensource.wdc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block: remove queue from struct blk_independent_access_range | expand |
On Fri, Jun 03, 2022 at 02:35:29PM +0900, Damien Le Moal wrote: > The request queue pointer in struct blk_independent_access_range is > unused. Remove it. Looks good: Reviewed-by: Christoph Hellwig <hch@lst.de> As does the original fix, I actually had a patch doing both in one in one of my queues for the next merge window..
On 6/3/22 14:35, Damien Le Moal wrote: > The request queue pointer in struct blk_independent_access_range is > unused. Remove it. > > Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com> Jens, Ping ? This now can have also: Fixes: 41e46b3c2aa2 ("block: Fix potential deadlock in blk_ia_range_sysfs_show()") > --- > block/blk-ia-ranges.c | 1 - > include/linux/blkdev.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/block/blk-ia-ranges.c b/block/blk-ia-ranges.c > index 56ed48d2954e..47c89e65b57f 100644 > --- a/block/blk-ia-ranges.c > +++ b/block/blk-ia-ranges.c > @@ -144,7 +144,6 @@ int disk_register_independent_access_ranges(struct gendisk *disk, > } > > for (i = 0; i < iars->nr_ia_ranges; i++) { > - iars->ia_range[i].queue = q; > ret = kobject_init_and_add(&iars->ia_range[i].kobj, > &blk_ia_range_ktype, &iars->kobj, > "%d", i); > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 1b24c1fb3bb1..62633619146e 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -341,7 +341,6 @@ static inline int blkdev_zone_mgmt_ioctl(struct block_device *bdev, > */ > struct blk_independent_access_range { > struct kobject kobj; > - struct request_queue *queue; > sector_t sector; > sector_t nr_sectors; > };
On 6/19/22 5:29 PM, Damien Le Moal wrote: > On 6/3/22 14:35, Damien Le Moal wrote: >> The request queue pointer in struct blk_independent_access_range is >> unused. Remove it. >> >> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com> > > Jens, > > Ping ? > > This now can have also: > > Fixes: 41e46b3c2aa2 ("block: Fix potential deadlock in > blk_ia_range_sysfs_show()") I'll queue it up, was OOO that week (and week after).
diff --git a/block/blk-ia-ranges.c b/block/blk-ia-ranges.c index 56ed48d2954e..47c89e65b57f 100644 --- a/block/blk-ia-ranges.c +++ b/block/blk-ia-ranges.c @@ -144,7 +144,6 @@ int disk_register_independent_access_ranges(struct gendisk *disk, } for (i = 0; i < iars->nr_ia_ranges; i++) { - iars->ia_range[i].queue = q; ret = kobject_init_and_add(&iars->ia_range[i].kobj, &blk_ia_range_ktype, &iars->kobj, "%d", i); diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 1b24c1fb3bb1..62633619146e 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -341,7 +341,6 @@ static inline int blkdev_zone_mgmt_ioctl(struct block_device *bdev, */ struct blk_independent_access_range { struct kobject kobj; - struct request_queue *queue; sector_t sector; sector_t nr_sectors; };
The request queue pointer in struct blk_independent_access_range is unused. Remove it. Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com> --- block/blk-ia-ranges.c | 1 - include/linux/blkdev.h | 1 - 2 files changed, 2 deletions(-)