| Message ID | 20220620104316.57592-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9ef165406308515dcf2e3f6e97b39a1c56d86db5 |
| Headers | show |
| Series | [v1,1/1] usb: typec: wcove: Drop wrong dependency to INTEL_SOC_PMIC | expand |
On 6/20/22 03:43, Andy Shevchenko wrote: > Intel SoC PMIC is a generic name for all PMICs that are used > on Intel platforms. In particular, INTEL_SOC_PMIC kernel configuration > option refers to Crystal Cove PMIC, which has never been a part > of any Intel Broxton hardware. Drop wrong dependency from Kconfig. > > Note, the correct dependency is satisfied via ACPI PMIC OpRegion driver, > which the Type-C depends on. > > Fixes: d2061f9cc32d ("usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY") > Reported-by: Hans de Goede <hdegoede@redhat.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/usb/typec/tcpm/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm/Kconfig b/drivers/usb/typec/tcpm/Kconfig > index 557f392fe24d..073fd2ea5e0b 100644 > --- a/drivers/usb/typec/tcpm/Kconfig > +++ b/drivers/usb/typec/tcpm/Kconfig > @@ -56,7 +56,6 @@ config TYPEC_WCOVE > tristate "Intel WhiskeyCove PMIC USB Type-C PHY driver" > depends on ACPI > depends on MFD_INTEL_PMC_BXT > - depends on INTEL_SOC_PMIC > depends on BXT_WC_PMIC_OPREGION > help > This driver adds support for USB Type-C on Intel Broxton platforms
Hi, On 6/20/22 12:43, Andy Shevchenko wrote: > Intel SoC PMIC is a generic name for all PMICs that are used > on Intel platforms. In particular, INTEL_SOC_PMIC kernel configuration > option refers to Crystal Cove PMIC, which has never been a part > of any Intel Broxton hardware. Drop wrong dependency from Kconfig. > > Note, the correct dependency is satisfied via ACPI PMIC OpRegion driver, > which the Type-C depends on. > > Fixes: d2061f9cc32d ("usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY") > Reported-by: Hans de Goede <hdegoede@redhat.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/usb/typec/tcpm/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm/Kconfig b/drivers/usb/typec/tcpm/Kconfig > index 557f392fe24d..073fd2ea5e0b 100644 > --- a/drivers/usb/typec/tcpm/Kconfig > +++ b/drivers/usb/typec/tcpm/Kconfig > @@ -56,7 +56,6 @@ config TYPEC_WCOVE > tristate "Intel WhiskeyCove PMIC USB Type-C PHY driver" > depends on ACPI > depends on MFD_INTEL_PMC_BXT > - depends on INTEL_SOC_PMIC > depends on BXT_WC_PMIC_OPREGION > help > This driver adds support for USB Type-C on Intel Broxton platforms
On Mon, Jun 20, 2022 at 01:43:16PM +0300, Andy Shevchenko wrote: > Intel SoC PMIC is a generic name for all PMICs that are used > on Intel platforms. In particular, INTEL_SOC_PMIC kernel configuration > option refers to Crystal Cove PMIC, which has never been a part > of any Intel Broxton hardware. Drop wrong dependency from Kconfig. > > Note, the correct dependency is satisfied via ACPI PMIC OpRegion driver, > which the Type-C depends on. > > Fixes: d2061f9cc32d ("usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY") > Reported-by: Hans de Goede <hdegoede@redhat.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/tcpm/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm/Kconfig b/drivers/usb/typec/tcpm/Kconfig > index 557f392fe24d..073fd2ea5e0b 100644 > --- a/drivers/usb/typec/tcpm/Kconfig > +++ b/drivers/usb/typec/tcpm/Kconfig > @@ -56,7 +56,6 @@ config TYPEC_WCOVE > tristate "Intel WhiskeyCove PMIC USB Type-C PHY driver" > depends on ACPI > depends on MFD_INTEL_PMC_BXT > - depends on INTEL_SOC_PMIC > depends on BXT_WC_PMIC_OPREGION > help > This driver adds support for USB Type-C on Intel Broxton platforms > -- > 2.35.1
diff --git a/drivers/usb/typec/tcpm/Kconfig b/drivers/usb/typec/tcpm/Kconfig index 557f392fe24d..073fd2ea5e0b 100644 --- a/drivers/usb/typec/tcpm/Kconfig +++ b/drivers/usb/typec/tcpm/Kconfig @@ -56,7 +56,6 @@ config TYPEC_WCOVE tristate "Intel WhiskeyCove PMIC USB Type-C PHY driver" depends on ACPI depends on MFD_INTEL_PMC_BXT - depends on INTEL_SOC_PMIC depends on BXT_WC_PMIC_OPREGION help This driver adds support for USB Type-C on Intel Broxton platforms
Intel SoC PMIC is a generic name for all PMICs that are used on Intel platforms. In particular, INTEL_SOC_PMIC kernel configuration option refers to Crystal Cove PMIC, which has never been a part of any Intel Broxton hardware. Drop wrong dependency from Kconfig. Note, the correct dependency is satisfied via ACPI PMIC OpRegion driver, which the Type-C depends on. Fixes: d2061f9cc32d ("usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY") Reported-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/usb/typec/tcpm/Kconfig | 1 - 1 file changed, 1 deletion(-)