| Message ID | 20220514144436.4298-1-trondmy@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Allow nfs4-acl-tools to access 'dacl' and 'sacl' | expand |
On Sat, May 14, 2022 at 10:44:30AM -0400, trondmy@kernel.org wrote: > From: Trond Myklebust <trond.myklebust@hammerspace.com> > > The following patch set matches the kernel patches to allow access to > the NFSv4.1 'dacl' and 'sacl' attributes. The current patches are very > basic, adding support for encoding/decoding the new attributes only when > the user specifies the '--dacl' or '--sacl' flags on the command line. Seems like a reasonable thing to do. I'd rather not be responsible for nfs4-acl-tools any longer, though. --b. > > Trond Myklebust (6): > libnfs4acl: Add helpers to set the dacl and sacl > libnfs4acl: Add support for the NFS4.1 ACE_INHERITED_ACE flag > The NFSv41 DACL and SACL prepend an extra field to the acl > nfs4_getacl: Add support for the --dacl and --sacl options > nfs4_setacl: Add support for the --dacl and --sacl options > Edit manpages to document the new --dacl, --sacl and inheritance > features > > include/libacl_nfs4.h | 18 +++++++ > include/nfs4.h | 6 +++ > libnfs4acl/Makefile | 2 + > libnfs4acl/acl_nfs4_copy_acl.c | 2 + > libnfs4acl/acl_nfs4_xattr_load.c | 14 +++++- > libnfs4acl/acl_nfs4_xattr_pack.c | 22 ++++++-- > libnfs4acl/nfs4_ace_from_string.c | 3 ++ > libnfs4acl/nfs4_get_ace_flags.c | 2 + > libnfs4acl/nfs4_getacl.c | 84 +++++++++++++++++++++++++++++++ > libnfs4acl/nfs4_new_acl.c | 1 + > libnfs4acl/nfs4_setacl.c | 49 ++++++++++++++++++ > man/man1/nfs4_getfacl.1 | 14 ++++++ > man/man1/nfs4_setfacl.1 | 8 +++ > man/man5/nfs4_acl.5 | 10 ++++ > nfs4_getfacl/nfs4_getfacl.c | 73 ++++++++++++++++++++++++--- > nfs4_setfacl/nfs4_setfacl.c | 67 ++++++++++++++++++++++-- > 16 files changed, 359 insertions(+), 16 deletions(-) > create mode 100644 libnfs4acl/nfs4_getacl.c > create mode 100644 libnfs4acl/nfs4_setacl.c > > -- > 2.36.1
On Sat, 2022-05-14 at 21:59 -0400, J.Bruce Fields wrote: > On Sat, May 14, 2022 at 10:44:30AM -0400, trondmy@kernel.org wrote: > > From: Trond Myklebust <trond.myklebust@hammerspace.com> > > > > The following patch set matches the kernel patches to allow access > > to > > the NFSv4.1 'dacl' and 'sacl' attributes. The current patches are > > very > > basic, adding support for encoding/decoding the new attributes only > > when > > the user specifies the '--dacl' or '--sacl' flags on the command > > line. > > Seems like a reasonable thing to do. > > I'd rather not be responsible for nfs4-acl-tools any longer, though. > > --b. I suspected that might be the case, but since you haven't made any announcements about anybody else taking over, I figured I'd start by sending these to you. So who should take over the nfs4-acl-tools maintainer role? Is that something Red Hat might be interested in doing, or should I volunteer to do it while we wait for somebody to get so fed up that they decide to step in?
On 5/14/22 11:23 PM, Trond Myklebust wrote: > On Sat, 2022-05-14 at 21:59 -0400, J.Bruce Fields wrote: >> On Sat, May 14, 2022 at 10:44:30AM -0400, trondmy@kernel.org wrote: >>> From: Trond Myklebust <trond.myklebust@hammerspace.com> >>> >>> The following patch set matches the kernel patches to allow access >>> to >>> the NFSv4.1 'dacl' and 'sacl' attributes. The current patches are >>> very >>> basic, adding support for encoding/decoding the new attributes only >>> when >>> the user specifies the '--dacl' or '--sacl' flags on the command >>> line. >> >> Seems like a reasonable thing to do. >> >> I'd rather not be responsible for nfs4-acl-tools any longer, though. >> >> --b. > > I suspected that might be the case, but since you haven't made any > announcements about anybody else taking over, I figured I'd start by > sending these to you. > > So who should take over the nfs4-acl-tools maintainer role? Is that > something Red Hat might be interested in doing, or should I volunteer > to do it while we wait for somebody to get so fed up that they decide > to step in? > Yeah... it probably something we should take over.... I'll add these to my todo list... Where does the upstream repo live today? steved.
On Thu, May 19, 2022 at 09:47:41AM -0400, Steve Dickson wrote: > > > On 5/14/22 11:23 PM, Trond Myklebust wrote: > >On Sat, 2022-05-14 at 21:59 -0400, J.Bruce Fields wrote: > >>On Sat, May 14, 2022 at 10:44:30AM -0400, trondmy@kernel.org wrote: > >>>From: Trond Myklebust <trond.myklebust@hammerspace.com> > >>> > >>>The following patch set matches the kernel patches to allow access > >>>to > >>>the NFSv4.1 'dacl' and 'sacl' attributes. The current patches are > >>>very > >>>basic, adding support for encoding/decoding the new attributes only > >>>when > >>>the user specifies the '--dacl' or '--sacl' flags on the command > >>>line. > >> > >>Seems like a reasonable thing to do. > >> > >>I'd rather not be responsible for nfs4-acl-tools any longer, though. > >> > >>--b. > > > >I suspected that might be the case, but since you haven't made any > >announcements about anybody else taking over, I figured I'd start by > >sending these to you. > > > >So who should take over the nfs4-acl-tools maintainer role? Is that > >something Red Hat might be interested in doing, or should I volunteer > >to do it while we wait for somebody to get so fed up that they decide > >to step in? > > > Yeah... it probably something we should take over.... > > I'll add these to my todo list... Where does the upstream repo > live today? The Fedora rpm package points to my repo on linux-nfs. So you can just clone that and update the spec files to point at your repo. --b.
On 5/19/22 9:53 AM, bfields@fieldses.org wrote: > On Thu, May 19, 2022 at 09:47:41AM -0400, Steve Dickson wrote: >> >> >> On 5/14/22 11:23 PM, Trond Myklebust wrote: >>> On Sat, 2022-05-14 at 21:59 -0400, J.Bruce Fields wrote: >>>> On Sat, May 14, 2022 at 10:44:30AM -0400, trondmy@kernel.org wrote: >>>>> From: Trond Myklebust <trond.myklebust@hammerspace.com> >>>>> >>>>> The following patch set matches the kernel patches to allow access >>>>> to >>>>> the NFSv4.1 'dacl' and 'sacl' attributes. The current patches are >>>>> very >>>>> basic, adding support for encoding/decoding the new attributes only >>>>> when >>>>> the user specifies the '--dacl' or '--sacl' flags on the command >>>>> line. >>>> >>>> Seems like a reasonable thing to do. >>>> >>>> I'd rather not be responsible for nfs4-acl-tools any longer, though. >>>> >>>> --b. >>> >>> I suspected that might be the case, but since you haven't made any >>> announcements about anybody else taking over, I figured I'd start by >>> sending these to you. >>> >>> So who should take over the nfs4-acl-tools maintainer role? Is that >>> something Red Hat might be interested in doing, or should I volunteer >>> to do it while we wait for somebody to get so fed up that they decide >>> to step in? >>> >> Yeah... it probably something we should take over.... >> >> I'll add these to my todo list... Where does the upstream repo >> live today? There is now a new nfs4-acl-tools repo [1] that I will start using for this patch set. You might want to disable the old repo. Also the links on the main page of linux-nfs.org [2] will need to point to [1]. I guess I don't have an account on that box, so I can not make that change. steved. [1] git://git.linux-nfs.org/~steved/nfs4-acl-tools.git [2] http://linux-nfs.org/wiki/index.php/Main_Page
On Thu, May 19, 2022 at 02:52:25PM -0400, Steve Dickson wrote: > Also the links on the main page of linux-nfs.org [2] > will need to point to [1]. I guess I don't have an > account on that box, so I can not make that change. https://wiki.linux-nfs.org/wiki/index.php/Special:RequestAccount --b.
On 5/14/22 10:44 AM, trondmy@kernel.org wrote: > From: Trond Myklebust <trond.myklebust@hammerspace.com> > > The following patch set matches the kernel patches to allow access to > the NFSv4.1 'dacl' and 'sacl' attributes. The current patches are very > basic, adding support for encoding/decoding the new attributes only when > the user specifies the '--dacl' or '--sacl' flags on the command line. > > Trond Myklebust (6): > libnfs4acl: Add helpers to set the dacl and sacl > libnfs4acl: Add support for the NFS4.1 ACE_INHERITED_ACE flag > The NFSv41 DACL and SACL prepend an extra field to the acl > nfs4_getacl: Add support for the --dacl and --sacl options > nfs4_setacl: Add support for the --dacl and --sacl options > Edit manpages to document the new --dacl, --sacl and inheritance > features > > include/libacl_nfs4.h | 18 +++++++ > include/nfs4.h | 6 +++ > libnfs4acl/Makefile | 2 + > libnfs4acl/acl_nfs4_copy_acl.c | 2 + > libnfs4acl/acl_nfs4_xattr_load.c | 14 +++++- > libnfs4acl/acl_nfs4_xattr_pack.c | 22 ++++++-- > libnfs4acl/nfs4_ace_from_string.c | 3 ++ > libnfs4acl/nfs4_get_ace_flags.c | 2 + > libnfs4acl/nfs4_getacl.c | 84 +++++++++++++++++++++++++++++++ > libnfs4acl/nfs4_new_acl.c | 1 + > libnfs4acl/nfs4_setacl.c | 49 ++++++++++++++++++ > man/man1/nfs4_getfacl.1 | 14 ++++++ > man/man1/nfs4_setfacl.1 | 8 +++ > man/man5/nfs4_acl.5 | 10 ++++ > nfs4_getfacl/nfs4_getfacl.c | 73 ++++++++++++++++++++++++--- > nfs4_setfacl/nfs4_setfacl.c | 67 ++++++++++++++++++++++-- > 16 files changed, 359 insertions(+), 16 deletions(-) > create mode 100644 libnfs4acl/nfs4_getacl.c > create mode 100644 libnfs4acl/nfs4_setacl.c > My apologies this took so long.... Committed (tag: nfs4-acl-tools-0.4.1-rc) steved.
Thanks!--b. On Tue, Jun 21, 2022 at 09:43:44AM -0400, Steve Dickson wrote: > > > On 5/14/22 10:44 AM, trondmy@kernel.org wrote: > >From: Trond Myklebust <trond.myklebust@hammerspace.com> > > > >The following patch set matches the kernel patches to allow access to > >the NFSv4.1 'dacl' and 'sacl' attributes. The current patches are very > >basic, adding support for encoding/decoding the new attributes only when > >the user specifies the '--dacl' or '--sacl' flags on the command line. > > > >Trond Myklebust (6): > > libnfs4acl: Add helpers to set the dacl and sacl > > libnfs4acl: Add support for the NFS4.1 ACE_INHERITED_ACE flag > > The NFSv41 DACL and SACL prepend an extra field to the acl > > nfs4_getacl: Add support for the --dacl and --sacl options > > nfs4_setacl: Add support for the --dacl and --sacl options > > Edit manpages to document the new --dacl, --sacl and inheritance > > features > > > > include/libacl_nfs4.h | 18 +++++++ > > include/nfs4.h | 6 +++ > > libnfs4acl/Makefile | 2 + > > libnfs4acl/acl_nfs4_copy_acl.c | 2 + > > libnfs4acl/acl_nfs4_xattr_load.c | 14 +++++- > > libnfs4acl/acl_nfs4_xattr_pack.c | 22 ++++++-- > > libnfs4acl/nfs4_ace_from_string.c | 3 ++ > > libnfs4acl/nfs4_get_ace_flags.c | 2 + > > libnfs4acl/nfs4_getacl.c | 84 +++++++++++++++++++++++++++++++ > > libnfs4acl/nfs4_new_acl.c | 1 + > > libnfs4acl/nfs4_setacl.c | 49 ++++++++++++++++++ > > man/man1/nfs4_getfacl.1 | 14 ++++++ > > man/man1/nfs4_setfacl.1 | 8 +++ > > man/man5/nfs4_acl.5 | 10 ++++ > > nfs4_getfacl/nfs4_getfacl.c | 73 ++++++++++++++++++++++++--- > > nfs4_setfacl/nfs4_setfacl.c | 67 ++++++++++++++++++++++-- > > 16 files changed, 359 insertions(+), 16 deletions(-) > > create mode 100644 libnfs4acl/nfs4_getacl.c > > create mode 100644 libnfs4acl/nfs4_setacl.c > > > My apologies this took so long.... > > Committed (tag: nfs4-acl-tools-0.4.1-rc) > > steved.
From: Trond Myklebust <trond.myklebust@hammerspace.com> The following patch set matches the kernel patches to allow access to the NFSv4.1 'dacl' and 'sacl' attributes. The current patches are very basic, adding support for encoding/decoding the new attributes only when the user specifies the '--dacl' or '--sacl' flags on the command line. Trond Myklebust (6): libnfs4acl: Add helpers to set the dacl and sacl libnfs4acl: Add support for the NFS4.1 ACE_INHERITED_ACE flag The NFSv41 DACL and SACL prepend an extra field to the acl nfs4_getacl: Add support for the --dacl and --sacl options nfs4_setacl: Add support for the --dacl and --sacl options Edit manpages to document the new --dacl, --sacl and inheritance features include/libacl_nfs4.h | 18 +++++++ include/nfs4.h | 6 +++ libnfs4acl/Makefile | 2 + libnfs4acl/acl_nfs4_copy_acl.c | 2 + libnfs4acl/acl_nfs4_xattr_load.c | 14 +++++- libnfs4acl/acl_nfs4_xattr_pack.c | 22 ++++++-- libnfs4acl/nfs4_ace_from_string.c | 3 ++ libnfs4acl/nfs4_get_ace_flags.c | 2 + libnfs4acl/nfs4_getacl.c | 84 +++++++++++++++++++++++++++++++ libnfs4acl/nfs4_new_acl.c | 1 + libnfs4acl/nfs4_setacl.c | 49 ++++++++++++++++++ man/man1/nfs4_getfacl.1 | 14 ++++++ man/man1/nfs4_setfacl.1 | 8 +++ man/man5/nfs4_acl.5 | 10 ++++ nfs4_getfacl/nfs4_getfacl.c | 73 ++++++++++++++++++++++++--- nfs4_setfacl/nfs4_setfacl.c | 67 ++++++++++++++++++++++-- 16 files changed, 359 insertions(+), 16 deletions(-) create mode 100644 libnfs4acl/nfs4_getacl.c create mode 100644 libnfs4acl/nfs4_setacl.c