diff mbox series

scsi: qla2xxx: check correct variable in qla24xx_async_gffid()

Message ID YqwYikYF4Ye6hpqy@kili (mailing list archive)
State Changes Requested
Headers show
Series scsi: qla2xxx: check correct variable in qla24xx_async_gffid() | expand

Commit Message

Dan Carpenter June 17, 2022, 6 a.m. UTC 
There is a copy and paste bug here.  It should check ".rsp" instead of
".req".

Fixes: 9c40c36e75ff ("scsi: qla2xxx: edif: Reduce Initiator-Initiator thrashing")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/scsi/qla2xxx/qla_gs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin K. Petersen June 22, 2022, 1:28 a.m. UTC | #1 
Dan,

> There is a copy and paste bug here.  It should check ".rsp" instead of
> ".req".

> -	if (!sp->u.iocb_cmd.u.ctarg.req) {
> +	if (!sp->u.iocb_cmd.u.ctarg.rsp) {
>  		ql_log(ql_log_warn, vha, 0xd041,
>  		       "%s: Failed to allocate ct_sns request.\n",
>  		       __func__);

I wonder if the log message should be adjusted to say "ct_sns response"
or something to that effect?
diff mbox series

Patch

diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
index 350d7c22ac79..cd0c3c703786 100644
--- a/drivers/scsi/qla2xxx/qla_gs.c
+++ b/drivers/scsi/qla2xxx/qla_gs.c
@@ -3389,7 +3389,7 @@  int qla24xx_async_gffid(scsi_qla_host_t *vha, fc_port_t *fcport, bool wait)
 				sp->u.iocb_cmd.u.ctarg.rsp_allocated_size,
 				&sp->u.iocb_cmd.u.ctarg.rsp_dma,
 	    GFP_KERNEL);
-	if (!sp->u.iocb_cmd.u.ctarg.req) {
+	if (!sp->u.iocb_cmd.u.ctarg.rsp) {
 		ql_log(ql_log_warn, vha, 0xd041,
 		       "%s: Failed to allocate ct_sns request.\n",
 		       __func__);