| Message ID | 20220622090713.24370-1-jiaming@nfschina.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | MIPS: Fix 2 typos | expand |
Hello! On 6/22/22 12:07 PM, Zhang Jiaming wrote: > Change 'modifed' to 'modified'. > Change 'relys' to 'relays'. I think it should be 'relies', not 'relays'. > Signed-off-by: Zhang Jiaming <jiaming@nfschina.com> > --- > arch/mips/cavium-octeon/executive/cvmx-helper-board.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c > index 1daa0c6b6f4e..82c51f015ea3 100644 > --- a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c > +++ b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c > @@ -282,9 +282,9 @@ union cvmx_helper_link_info __cvmx_helper_board_link_get(int ipd_port) > * support and should return the number of actual ports on the > * board. > * > - * This function must be modifed for every new Octeon board. > + * This function must be modified for every new Octeon board. > * Internally it uses switch statements based on the cvmx_sysinfo > - * data to determine board types and revisions. It relys on the > + * data to determine board types and revisions. It relays on the > * fact that every Octeon board receives a unique board type > * enumeration from the bootloader. > * MBR, Sergey
On 6/22/22 02:07, Zhang Jiaming wrote: > Change 'modifed' to 'modified'. > Change 'relys' to 'relays'. > > Signed-off-by: Zhang Jiaming <jiaming@nfschina.com> > --- > arch/mips/cavium-octeon/executive/cvmx-helper-board.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c > index 1daa0c6b6f4e..82c51f015ea3 100644 > --- a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c > +++ b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c > @@ -282,9 +282,9 @@ union cvmx_helper_link_info __cvmx_helper_board_link_get(int ipd_port) > * support and should return the number of actual ports on the > * board. > * > - * This function must be modifed for every new Octeon board. > + * This function must be modified for every new Octeon board. > * Internally it uses switch statements based on the cvmx_sysinfo > - * data to determine board types and revisions. It relys on the relies But it would be better to restrict this barrage (or swarm) of patches to Kconfig help text problems and/or strings that are printed to users. > + * data to determine board types and revisions. It relays on the > * fact that every Octeon board receives a unique board type > * enumeration from the bootloader. > *
On Wed, 2022-06-22 at 07:28 -0700, Randy Dunlap wrote: > On 6/22/22 02:07, Zhang Jiaming wrote: > > Change 'modifed' to 'modified'. > > Change 'relys' to 'relays'. [] > > diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c [] > > @@ -282,9 +282,9 @@ union cvmx_helper_link_info __cvmx_helper_board_link_get(int ipd_port) > > * support and should return the number of actual ports on the > > * board. > > * > > - * This function must be modifed for every new Octeon board. > > + * This function must be modified for every new Octeon board. > > * Internally it uses switch statements based on the cvmx_sysinfo > > - * data to determine board types and revisions. It relys on the > > relies > > But it would be better to restrict this barrage (or swarm) of patches > to Kconfig help text problems and/or strings that are printed to users. I believe fixing typos isn't a particular problem and is overall rather a good thing. Though backporting these patches would be silly.
On 6/22/22 07:46, Joe Perches wrote: > On Wed, 2022-06-22 at 07:28 -0700, Randy Dunlap wrote: >> On 6/22/22 02:07, Zhang Jiaming wrote: >>> Change 'modifed' to 'modified'. >>> Change 'relys' to 'relays'. > [] >>> diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c > [] >>> @@ -282,9 +282,9 @@ union cvmx_helper_link_info __cvmx_helper_board_link_get(int ipd_port) >>> * support and should return the number of actual ports on the >>> * board. >>> * >>> - * This function must be modifed for every new Octeon board. >>> + * This function must be modified for every new Octeon board. >>> * Internally it uses switch statements based on the cvmx_sysinfo >>> - * data to determine board types and revisions. It relys on the >> >> relies >> >> But it would be better to restrict this barrage (or swarm) of patches >> to Kconfig help text problems and/or strings that are printed to users. > > I believe fixing typos isn't a particular problem and is > overall rather a good thing. OK, I can agree with that. > Though backporting these patches would be silly. Ack.
diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c index 1daa0c6b6f4e..82c51f015ea3 100644 --- a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c +++ b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c @@ -282,9 +282,9 @@ union cvmx_helper_link_info __cvmx_helper_board_link_get(int ipd_port) * support and should return the number of actual ports on the * board. * - * This function must be modifed for every new Octeon board. + * This function must be modified for every new Octeon board. * Internally it uses switch statements based on the cvmx_sysinfo - * data to determine board types and revisions. It relys on the + * data to determine board types and revisions. It relays on the * fact that every Octeon board receives a unique board type * enumeration from the bootloader. *
Change 'modifed' to 'modified'. Change 'relys' to 'relays'. Signed-off-by: Zhang Jiaming <jiaming@nfschina.com> --- arch/mips/cavium-octeon/executive/cvmx-helper-board.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)