[04/36] iio: adc: imx7d_adc: Switch to DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr()

Commit Message

Jonathan Cameron June 21, 2022, 8:26 p.m. UTC

From: Jonathan Cameron <[e-mail]>

In this case we only gain the ability to have the compiler drop the
struct dev_pm_ops because the callbacks are called from paths other
than suspend and resume.  In general the purpose of this new macro
is to allow automated removal of the callbacks as well, but that doesn't
apply here.

Signed-off-by: Jonathan Cameron <[e-mail]>
Cc: Haibo Chen <[e-mail]>
---
 drivers/iio/adc/imx7d_adc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Bough Chen June 22, 2022, 9:31 a.m. UTC | #1

> -----Original Message-----
> From: Jonathan Cameron <[e-mail]>
> Sent: 2022年6月22日 4:27
> To: [e-mail]; Paul Cercueil <[e-mail]>
> Cc: Alexandre Belloni <[e-mail]>; Brian Masney
> <[e-mail]>; David Heidelberg <[e-mail]>; Cai Huoqing
> <[e-mail]>; Christian Eggers <[e-mail]>; Enric Balletbo i
> Serra <[e-mail]>; Eugen Hristev
> <[e-mail]>; Gwendal Grignou <[e-mail]>;
> Bough Chen <[e-mail]>; Hui Liu <[e-mail]>; Joe
> Sandom <[e-mail]>; Ismail H . Kose <[e-mail]>;
> Lars-Peter Clausen <[e-mail]>; Linus Walleij <[e-mail]>;
> Ludovic Desroches <[e-mail]>; Nicolas Ferre
> <[e-mail]>; Marcus Folkesson
> <[e-mail]>; Martin Blumenstingl
> <[e-mail]>; Mathieu Othacehe
> <[e-mail]>; Michal Simek <[e-mail]>; Miquel
> Raynal <[e-mail]>; Nuno Sá <[e-mail]>;
> Parthiban Nallathambi <[e-mail]>; Philippe Reynes <[e-mail]>;
> Philippe Schenker <[e-mail]>; Rishi Gupta
> <[e-mail]>; Roan van Dijk <[e-mail]>; Stephen Boyd
> <[e-mail]>; Tomasz Duszynski <[e-mail]>; Zhiyong
> Tao <[e-mail]>; Jonathan Cameron
> <[e-mail]>
> Subject: [PATCH 04/36] iio: adc: imx7d_adc: Switch to
> DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr()
> 
> From: Jonathan Cameron <[e-mail]>
> 
> In this case we only gain the ability to have the compiler drop the struct
> dev_pm_ops because the callbacks are called from paths other than suspend
> and resume.  In general the purpose of this new macro is to allow automated
> removal of the callbacks as well, but that doesn't apply here.
> 
> Signed-off-by: Jonathan Cameron <[e-mail]>
> Cc: Haibo Chen <[e-mail]>

Reviewed-by: Haibo Chen <[e-mail]>

> ---
>  drivers/iio/adc/imx7d_adc.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/imx7d_adc.c b/drivers/iio/adc/imx7d_adc.c index
> 119217af2bde..86caff1d006b 100644
> --- a/drivers/iio/adc/imx7d_adc.c
> +++ b/drivers/iio/adc/imx7d_adc.c
> @@ -540,14 +540,15 @@ static int imx7d_adc_probe(struct platform_device
> *pdev)
>  	return 0;
>  }
> 
> -static SIMPLE_DEV_PM_OPS(imx7d_adc_pm_ops, imx7d_adc_disable,
> imx7d_adc_enable);
> +static DEFINE_SIMPLE_DEV_PM_OPS(imx7d_adc_pm_ops,
> imx7d_adc_disable,
> +				imx7d_adc_enable);
> 
>  static struct platform_driver imx7d_adc_driver = {
>  	.probe		= imx7d_adc_probe,
>  	.driver		= {
>  		.name	= "imx7d_adc",
>  		.of_match_table = imx7d_adc_match,
> -		.pm	= &imx7d_adc_pm_ops,
> +		.pm	= pm_sleep_ptr(&imx7d_adc_pm_ops),
>  	},
>  };
> 
> --
> 2.36.1

Patch

diff --git a/drivers/iio/adc/imx7d_adc.c b/drivers/iio/adc/imx7d_adc.c
index 119217af2bde..86caff1d006b 100644
--- a/drivers/iio/adc/imx7d_adc.c
+++ b/drivers/iio/adc/imx7d_adc.c
@@ -540,14 +540,15 @@  static int imx7d_adc_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static SIMPLE_DEV_PM_OPS(imx7d_adc_pm_ops, imx7d_adc_disable, imx7d_adc_enable);
+static DEFINE_SIMPLE_DEV_PM_OPS(imx7d_adc_pm_ops, imx7d_adc_disable,
+				imx7d_adc_enable);
 
 static struct platform_driver imx7d_adc_driver = {
 	.probe		= imx7d_adc_probe,
 	.driver		= {
 		.name	= "imx7d_adc",
 		.of_match_table = imx7d_adc_match,
-		.pm	= &imx7d_adc_pm_ops,
+		.pm	= pm_sleep_ptr(&imx7d_adc_pm_ops),
 	},
 };