| Message ID | 20220427114638.1638-5-nas.chung@chipsnmedia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: media: wave5: add wave5 codec driver | expand |
On 27/04/2022 13:46, Nas Chung wrote: > Add a TODO file listing all that is need for destaging. > > Signed-off-by: Robert Beckett <bob.beckett@collabora.com> > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> > Signed-off-by: Nas Chung <nas.chung@chipsnmedia.com> > --- > drivers/staging/media/wave5/TODO | 34 ++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > create mode 100644 drivers/staging/media/wave5/TODO > > diff --git a/drivers/staging/media/wave5/TODO b/drivers/staging/media/wave5/TODO > new file mode 100644 > index 000000000000..070a1171b211 > --- /dev/null > +++ b/drivers/staging/media/wave5/TODO > @@ -0,0 +1,34 @@ > +* Mutli-stream Test > + > +* Loop Test > + > +* Handle interrupts better > + > + Currently the interrupt handling uses an unusual design employing a kfifo to > + transfer irq status to irq thread. This was done as a work around for dropped > + interrupts seen with IRQF_ONESHOT based handling. > + > + This needs further investigation and fixing properly, with the aid of > + C&M and StarFive engineers. > + > +* appropreate error handling: appropreate -> appropriate > +allocation failure, mutex acquire failure etc. > + > +* remove all unused struct fields > + > +* change struct fields to 'bool' type or bitfield when appropreate Ditto > +Likely good candidates are fields named '*_enable' , '*_on' > + > +* handle vdi_allocate_dma_memory failure , each function has to clean after itself > + > +* make sure that 'u32', 's32' etc. are only used when reading/writing hw > +and change s32 to u32 when s32 is not required > + > +* power management handling - add (runtime_)suspen/resume cb where the clock is enabled > + > +* fix checkpatch issues (mostly fixes , only left to fix MACRO_ARG_REUSE, LONG_LINE) > + > +* revise logic of wave5_vpu_(dec/enc)_register_framebuffer > + > +* check if the normal kernel endianness/__swab32 routines are sufficient. (instead of the ones > + implemented in the driver The cover letter says: "The wave5 driver will be updated to support various EXT_CTRL encoder interface." Should that be added to the TODO file as well? Note that I am not entirely sure which EXT CTRL encoder bits you refer to in the cover letter, that sentence was a bit vague. Regards, Hans
diff --git a/drivers/staging/media/wave5/TODO b/drivers/staging/media/wave5/TODO new file mode 100644 index 000000000000..070a1171b211 --- /dev/null +++ b/drivers/staging/media/wave5/TODO @@ -0,0 +1,34 @@ +* Mutli-stream Test + +* Loop Test + +* Handle interrupts better + + Currently the interrupt handling uses an unusual design employing a kfifo to + transfer irq status to irq thread. This was done as a work around for dropped + interrupts seen with IRQF_ONESHOT based handling. + + This needs further investigation and fixing properly, with the aid of + C&M and StarFive engineers. + +* appropreate error handling: +allocation failure, mutex acquire failure etc. + +* remove all unused struct fields + +* change struct fields to 'bool' type or bitfield when appropreate +Likely good candidates are fields named '*_enable' , '*_on' + +* handle vdi_allocate_dma_memory failure , each function has to clean after itself + +* make sure that 'u32', 's32' etc. are only used when reading/writing hw +and change s32 to u32 when s32 is not required + +* power management handling - add (runtime_)suspen/resume cb where the clock is enabled + +* fix checkpatch issues (mostly fixes , only left to fix MACRO_ARG_REUSE, LONG_LINE) + +* revise logic of wave5_vpu_(dec/enc)_register_framebuffer + +* check if the normal kernel endianness/__swab32 routines are sufficient. (instead of the ones + implemented in the driver