| Message ID | 20220622235116.1562570-1-prestwoj@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | test-runner: fix result/monitor options | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| prestwoj/iwd-alpine-ci-fetch | success | Fetch PR |
| prestwoj/iwd-ci-gitlint | success | GitLint |
| prestwoj/iwd-ci-fetch | success | Fetch PR |
| prestwoj/iwd-ci-makedistcheck | success | Make Distcheck |
| prestwoj/iwd-ci-incremental_build | success | Incremental build not run PASS |
| prestwoj/iwd-alpine-ci-makedistcheck | success | Make Distcheck |
| prestwoj/iwd-alpine-ci-incremental_build | success | Incremental build not run PASS |
| prestwoj/iwd-alpine-ci-build | success | Build - Configure |
| prestwoj/iwd-ci-build | success | Build - Configure |
| prestwoj/iwd-alpine-ci-makecheckvalgrind | success | Make Check w/Valgrind |
| prestwoj/iwd-alpine-ci-makecheck | success | Make Check |
| prestwoj/iwd-ci-makecheckvalgrind | success | Make Check w/Valgrind |
| prestwoj/iwd-ci-clang | success | clang PASS |
| prestwoj/iwd-ci-makecheck | success | Make Check |
| prestwoj/iwd-ci-testrunner | fail | test-runner - FAIL: |
Hi James, On 6/22/22 18:51, James Prestwood wrote: > An earlier commit fixed several options but ended up breaking others. The > result_parent/monitor_parent options are hidden from the user and only meant > to be passed to the kernel but they relied on the fact that the underscore > was present, not a dash. This updates the argument to use a dash: > > --result-parent > --monitor-parent > > Fixes: 00e41eb0ff ("test-runner: Fix parsing for some arguments") > --- > tools/runner.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Applied, thanks. Regards, -Denis
diff --git a/tools/runner.py b/tools/runner.py index b018a0ad..d39b560f 100644 --- a/tools/runner.py +++ b/tools/runner.py @@ -117,8 +117,8 @@ class RunnerCoreArgParse(ArgumentParser): type=str, help='Use physical adapters for tests (passthrough)') self.add_argument('--testhome', help=SUPPRESS) - self.add_argument('--monitor_parent', help=SUPPRESS) - self.add_argument('--result_parent', help=SUPPRESS) + self.add_argument('--monitor-parent', help=SUPPRESS) + self.add_argument('--result-parent', help=SUPPRESS) # Prevent --autotest/--unittest from being used together auto_unit_group = self.add_mutually_exclusive_group()
An earlier commit fixed several options but ended up breaking others. The result_parent/monitor_parent options are hidden from the user and only meant to be passed to the kernel but they relied on the fact that the underscore was present, not a dash. This updates the argument to use a dash: --result-parent --monitor-parent Fixes: 00e41eb0ff ("test-runner: Fix parsing for some arguments") --- tools/runner.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)