| Message ID | 20220622135002.8263-1-shenjian15@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9676feccacdb0571791c88b23e3b7ac4e7c9c457 |
| Delegated to: | BPF |
| Headers | show |
| Series | [net] test_bpf: fix incorrect netdev features | expand |
Jian Shen wrote: > The prototype of .features is netdev_features_t, it should use > NETIF_F_LLTX and NETIF_F_HW_VLAN_STAG_TX, not NETIF_F_LLTX_BIT > and NETIF_F_HW_VLAN_STAG_TX_BIT. > > Fixes: cf204a718357 ("test_bpf: Introduce 'gso_linear_no_head_frag' skb_segment test") > > Signed-off-by: Jian Shen <shenjian15@huawei.com> > --- Acked-by: John Fastabend <john.fastabend@gmail.com>
Hello: This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <ast@kernel.org>: On Wed, 22 Jun 2022 21:50:02 +0800 you wrote: > The prototype of .features is netdev_features_t, it should use > NETIF_F_LLTX and NETIF_F_HW_VLAN_STAG_TX, not NETIF_F_LLTX_BIT > and NETIF_F_HW_VLAN_STAG_TX_BIT. > > Fixes: cf204a718357 ("test_bpf: Introduce 'gso_linear_no_head_frag' skb_segment test") > > Signed-off-by: Jian Shen <shenjian15@huawei.com> > > [...] Here is the summary with links: - [net] test_bpf: fix incorrect netdev features https://git.kernel.org/bpf/bpf-next/c/9676feccacdb You are awesome, thank you!
diff --git a/lib/test_bpf.c b/lib/test_bpf.c index 2a7836e115b4..5820704165a6 100644 --- a/lib/test_bpf.c +++ b/lib/test_bpf.c @@ -14733,9 +14733,9 @@ static struct skb_segment_test skb_segment_tests[] __initconst = { .build_skb = build_test_skb_linear_no_head_frag, .features = NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_HW_VLAN_CTAG_TX | NETIF_F_GSO | - NETIF_F_LLTX_BIT | NETIF_F_GRO | + NETIF_F_LLTX | NETIF_F_GRO | NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM | - NETIF_F_HW_VLAN_STAG_TX_BIT + NETIF_F_HW_VLAN_STAG_TX } };
The prototype of .features is netdev_features_t, it should use NETIF_F_LLTX and NETIF_F_HW_VLAN_STAG_TX, not NETIF_F_LLTX_BIT and NETIF_F_HW_VLAN_STAG_TX_BIT. Fixes: cf204a718357 ("test_bpf: Introduce 'gso_linear_no_head_frag' skb_segment test") Signed-off-by: Jian Shen <shenjian15@huawei.com> --- lib/test_bpf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)