| Message ID | 165601455171.4042645.3350844271068713515.stgit@dwillia2-xfh (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f50974eee5c4a5de1e4f1a3d873099f170df25f8 |
| Headers | show |
| Series | memregion: Fix memregion_free() fallback definition | expand |
On Thu, Jun 23, 2022 at 01:02:31PM -0700, Dan Williams wrote: > In the CONFIG_MEMREGION=n case, memregion_free() is meant to be a static > inline. 0day reports: > > In file included from drivers/cxl/core/port.c:4: > include/linux/memregion.h:19:6: warning: no previous prototype for > function 'memregion_free' [-Wmissing-prototypes] > > Mark memregion_free() static. > > Fixes: 33dd70752cd7 ("lib: Uplevel the pmem "region" ida to a global allocator") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Dan Williams <dan.j.williams@intel.com> Reviewed-by: Alison Schofield <alison.schofield@intel.com> > --- > include/linux/memregion.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/memregion.h b/include/linux/memregion.h > index e11595256cac..c04c4fd2e209 100644 > --- a/include/linux/memregion.h > +++ b/include/linux/memregion.h > @@ -16,7 +16,7 @@ static inline int memregion_alloc(gfp_t gfp) > { > return -ENOMEM; > } > -void memregion_free(int id) > +static inline void memregion_free(int id) > { > } > #endif > >
diff --git a/include/linux/memregion.h b/include/linux/memregion.h index e11595256cac..c04c4fd2e209 100644 --- a/include/linux/memregion.h +++ b/include/linux/memregion.h @@ -16,7 +16,7 @@ static inline int memregion_alloc(gfp_t gfp) { return -ENOMEM; } -void memregion_free(int id) +static inline void memregion_free(int id) { } #endif
In the CONFIG_MEMREGION=n case, memregion_free() is meant to be a static inline. 0day reports: In file included from drivers/cxl/core/port.c:4: include/linux/memregion.h:19:6: warning: no previous prototype for function 'memregion_free' [-Wmissing-prototypes] Mark memregion_free() static. Fixes: 33dd70752cd7 ("lib: Uplevel the pmem "region" ida to a global allocator") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- include/linux/memregion.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)