| Message ID | 20220624141622.7149-3-Sergey.Semin@baikalelectronics.ru (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name | expand |
On 24/06/2022 16:16, Serge Semin wrote: > In accordance with the Generic EHCI/OHCI bindings the corresponding node > name is suppose to comply with the Generic USB HCD DT schema, which > requires the USB nodes to have the name acceptable by the regexp: > "^usb(@.*)?" . Make sure the "generic-ehci" and "generic-ohci"-compatible > nodes are correctly named. > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > Acked-by: Vladimir Zapolskiy <vz@mleia.com> > Acked-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > arch/arm/boot/dts/lpc18xx.dtsi | 4 ++-- You should split the patchset per architecture, because maybe that's why no one picks it up? Let me pick up ARM bits through my cleanup series. If anyone objects, please let me know. Best regards, Krzysztof
On Fri, 24 Jun 2022 17:16:18 +0300, Serge Semin wrote: > In accordance with the Generic EHCI/OHCI bindings the corresponding node > name is suppose to comply with the Generic USB HCD DT schema, which > requires the USB nodes to have the name acceptable by the regexp: > "^usb(@.*)?" . Make sure the "generic-ehci" and "generic-ohci"-compatible > nodes are correctly named. > > > [...] Applied, thanks! [2/5] arm: dts: lpc18xx: Harmonize EHCI/OHCI DT nodes name https://git.kernel.org/krzk/linux/c/986fd5fe55cb369c34a1dc65b1469aac536a6d50 Best regards,
On Fri, Jun 24, 2022 at 07:14:44PM +0200, Krzysztof Kozlowski wrote: > On 24/06/2022 16:16, Serge Semin wrote: > > In accordance with the Generic EHCI/OHCI bindings the corresponding node > > name is suppose to comply with the Generic USB HCD DT schema, which > > requires the USB nodes to have the name acceptable by the regexp: > > "^usb(@.*)?" . Make sure the "generic-ehci" and "generic-ohci"-compatible > > nodes are correctly named. > > > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > Acked-by: Vladimir Zapolskiy <vz@mleia.com> > > Acked-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > arch/arm/boot/dts/lpc18xx.dtsi | 4 ++-- > > You should split the patchset per architecture, because maybe that's why > no one picks it up? Each patch is sent out to the corresponding mailing list and the maintainers. I don't think splitting the patchset into the subsets will be more efficient especially seeing the initial patchset consisted of 30 patches of which only five left. I was very busy last year with another activities so what was left of this patchset was stalling on my local repo all that time. I have been very surprised to realise that the submitted part still hasn't been merged in for all that time. So I've got back to resubmitting the series. * Though the Qualcom dts have been fixed by you lately. > > Let me pick up ARM bits through my cleanup series. If anyone objects, > please let me know. Ok. Thanks. -Sergey > > Best regards, > Krzysztof
diff --git a/arch/arm/boot/dts/lpc18xx.dtsi b/arch/arm/boot/dts/lpc18xx.dtsi index 10b8249b8ab6..82ffd7b0ad8a 100644 --- a/arch/arm/boot/dts/lpc18xx.dtsi +++ b/arch/arm/boot/dts/lpc18xx.dtsi @@ -121,7 +121,7 @@ mmcsd: mmcsd@40004000 { status = "disabled"; }; - usb0: ehci@40006100 { + usb0: usb@40006100 { compatible = "nxp,lpc1850-ehci", "generic-ehci"; reg = <0x40006100 0x100>; interrupts = <8>; @@ -133,7 +133,7 @@ usb0: ehci@40006100 { status = "disabled"; }; - usb1: ehci@40007100 { + usb1: usb@40007100 { compatible = "nxp,lpc1850-ehci", "generic-ehci"; reg = <0x40007100 0x100>; interrupts = <9>;