| Message ID | 20220627114731.356462-2-niklas.cassel@wdc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/nvme: add support for TP4084 | expand |
On Mon, Jun 27, 2022 at 01:47:28PM +0200, Niklas Cassel via wrote: > CRMS.CRWMS bit shall be set to 1 on controllers compliant with versions > later than NVMe 1.4. > > The first version later than NVMe 1.4 is NVMe 2.0 > > Let's claim compliance with NVMe 2.0 such that a follow up patch can > set the CRMS.CRWMS bit. > > This is needed since CC.CRIME is only writable when both CRMS.CRIMS > and CRMS.CRWMS is set. You can also always support newer features without claiming compliance for the new version. I'd suggest to go through the mandatory changes list first before upgrading the compliance. (And one day it would be neat if someone tried to run the official but commercial compliance tests on qemu a well..)
On Jun 27 10:59, Christoph Hellwig wrote: > On Mon, Jun 27, 2022 at 01:47:28PM +0200, Niklas Cassel via wrote: > > CRMS.CRWMS bit shall be set to 1 on controllers compliant with versions > > later than NVMe 1.4. > > > > The first version later than NVMe 1.4 is NVMe 2.0 > > > > Let's claim compliance with NVMe 2.0 such that a follow up patch can > > set the CRMS.CRWMS bit. > > > > This is needed since CC.CRIME is only writable when both CRMS.CRIMS > > and CRMS.CRWMS is set. > > You can also always support newer features without claiming > compliance for the new version. I'd suggest to go through the > mandatory changes list first before upgrading the compliance. Agreed. > (And one day it would be neat if someone tried to run the official > but commercial compliance tests on qemu a well..) Ouch!
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index f8ec4a7be3..8ca824ea14 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -204,7 +204,7 @@ #define NVME_MAX_IOQPAIRS 0xffff #define NVME_DB_SIZE 4 -#define NVME_SPEC_VER 0x00010400 +#define NVME_SPEC_VER 0x00020000 #define NVME_CMB_BIR 2 #define NVME_PMR_BIR 4 #define NVME_TEMPERATURE 0x143
CRMS.CRWMS bit shall be set to 1 on controllers compliant with versions later than NVMe 1.4. The first version later than NVMe 1.4 is NVMe 2.0 Let's claim compliance with NVMe 2.0 such that a follow up patch can set the CRMS.CRWMS bit. This is needed since CC.CRIME is only writable when both CRMS.CRIMS and CRMS.CRWMS is set. Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com> --- hw/nvme/ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)