| Message ID | 20220627181449.3537-1-markpearson@lenovo.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [v2] platform/x86: thinkpad_acpi: do not use PSC mode on Intel platforms | expand |
Hi, On 6/27/22 20:14, Mark Pearson wrote: > PSC platform profile mode is only supported on Linux for AMD platforms. > > Some older Intel platforms (e.g T490) are advertising it's capability > as Windows uses it - but on Linux we should only be using MMC profile > for Intel systems. > > Add a check to prevent it being enabled incorrectly. > > Signed-off-by: Mark Pearson <markpearson@lenovo.com>> --- > Changes in v2: rebased on for-next stream Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > > drivers/platform/x86/thinkpad_acpi.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > index 17d503e65a54..09047ca14b43 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -10565,6 +10565,11 @@ static int tpacpi_dytc_profile_init(struct ibm_init_struct *iibm) > dytc_mmc_get_available = true; > } > } else if (dytc_capabilities & BIT(DYTC_FC_PSC)) { /* PSC MODE */ > + /* Support for this only works on AMD platforms */ > + if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD) { > + dbg_printk(TPACPI_DBG_INIT, "PSC not support on Intel platforms\n"); > + return -ENODEV; > + } > pr_debug("PSC is supported\n"); > } else { > dbg_printk(TPACPI_DBG_INIT, "No DYTC support available\n");
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 17d503e65a54..09047ca14b43 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -10565,6 +10565,11 @@ static int tpacpi_dytc_profile_init(struct ibm_init_struct *iibm) dytc_mmc_get_available = true; } } else if (dytc_capabilities & BIT(DYTC_FC_PSC)) { /* PSC MODE */ + /* Support for this only works on AMD platforms */ + if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD) { + dbg_printk(TPACPI_DBG_INIT, "PSC not support on Intel platforms\n"); + return -ENODEV; + } pr_debug("PSC is supported\n"); } else { dbg_printk(TPACPI_DBG_INIT, "No DYTC support available\n");
PSC platform profile mode is only supported on Linux for AMD platforms. Some older Intel platforms (e.g T490) are advertising it's capability as Windows uses it - but on Linux we should only be using MMC profile for Intel systems. Add a check to prevent it being enabled incorrectly. Signed-off-by: Mark Pearson <markpearson@lenovo.com> --- Changes in v2: rebased on for-next stream drivers/platform/x86/thinkpad_acpi.c | 5 +++++ 1 file changed, 5 insertions(+)