| Message ID | 20220629121441.6552-3-ansuelsmth@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Krait Documentation conversion | expand |
On Wed, 29 Jun 2022 14:14:38 +0200, Christian Marangi wrote: > Convert kpss-acc driver Documentation to yaml. > The original Documentation was wrong all along. Fix it while we are > converting it. > The example was wrong as kpss-acc-v2 should only expose the regs but we > don't have any driver that expose additional clocks. The kpss-acc driver > is only specific to v1. For this exact reason, limit all the additional > bindings (clocks, clock-names, clock-output-names and #clock-cells) to > v1 and also flag that these bindings should NOT be used for v2. > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > --- > .../bindings/arm/msm/qcom,kpss-acc.txt | 49 ---------- > .../bindings/arm/msm/qcom,kpss-acc.yaml | 93 +++++++++++++++++++ > 2 files changed, 93 insertions(+), 49 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.txt > create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/ clock-controller@2088000: '#clock-cells' is a required property arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb arch/arm/boot/dts/qcom-ipq8064-ap148.dtb arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb arch/arm/boot/dts/qcom-msm8960-cdp.dtb clock-controller@2088000: 'clock-names' is a required property arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb arch/arm/boot/dts/qcom-ipq8064-ap148.dtb arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb arch/arm/boot/dts/qcom-msm8960-cdp.dtb clock-controller@2088000: 'clock-output-names' is a required property arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb arch/arm/boot/dts/qcom-ipq8064-ap148.dtb arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb arch/arm/boot/dts/qcom-msm8960-cdp.dtb clock-controller@2088000: 'clocks' is a required property arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb arch/arm/boot/dts/qcom-ipq8064-ap148.dtb arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb arch/arm/boot/dts/qcom-msm8960-cdp.dtb clock-controller@2098000: '#clock-cells' is a required property arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb arch/arm/boot/dts/qcom-ipq8064-ap148.dtb arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb arch/arm/boot/dts/qcom-msm8960-cdp.dtb clock-controller@2098000: 'clock-names' is a required property arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb arch/arm/boot/dts/qcom-ipq8064-ap148.dtb arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb arch/arm/boot/dts/qcom-msm8960-cdp.dtb clock-controller@2098000: 'clock-output-names' is a required property arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb arch/arm/boot/dts/qcom-ipq8064-ap148.dtb arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb arch/arm/boot/dts/qcom-msm8960-cdp.dtb clock-controller@2098000: 'clocks' is a required property arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb arch/arm/boot/dts/qcom-ipq8064-ap148.dtb arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb arch/arm/boot/dts/qcom-msm8960-cdp.dtb clock-controller@20a8000: '#clock-cells' is a required property arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb clock-controller@20a8000: 'clock-names' is a required property arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb clock-controller@20a8000: 'clock-output-names' is a required property arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb clock-controller@20a8000: 'clocks' is a required property arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb clock-controller@20b8000: '#clock-cells' is a required property arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb clock-controller@20b8000: 'clock-names' is a required property arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb clock-controller@20b8000: 'clock-output-names' is a required property arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb clock-controller@20b8000: 'clocks' is a required property arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
On Wed, Jun 29, 2022 at 04:36:59PM -0600, Rob Herring wrote: > On Wed, 29 Jun 2022 14:14:38 +0200, Christian Marangi wrote: > > Convert kpss-acc driver Documentation to yaml. > > The original Documentation was wrong all along. Fix it while we are > > converting it. > > The example was wrong as kpss-acc-v2 should only expose the regs but we > > don't have any driver that expose additional clocks. The kpss-acc driver > > is only specific to v1. For this exact reason, limit all the additional > > bindings (clocks, clock-names, clock-output-names and #clock-cells) to > > v1 and also flag that these bindings should NOT be used for v2. > > > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > > --- > > .../bindings/arm/msm/qcom,kpss-acc.txt | 49 ---------- > > .../bindings/arm/msm/qcom,kpss-acc.yaml | 93 +++++++++++++++++++ > > 2 files changed, 93 insertions(+), 49 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.txt > > create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/ > > > clock-controller@2088000: '#clock-cells' is a required property > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb > arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb > arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb > arch/arm/boot/dts/qcom-ipq8064-ap148.dtb > arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb > arch/arm/boot/dts/qcom-msm8960-cdp.dtb > > clock-controller@2088000: 'clock-names' is a required property > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb > arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb > arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb > arch/arm/boot/dts/qcom-ipq8064-ap148.dtb > arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb > arch/arm/boot/dts/qcom-msm8960-cdp.dtb > > clock-controller@2088000: 'clock-output-names' is a required property > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb > arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb > arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb > arch/arm/boot/dts/qcom-ipq8064-ap148.dtb > arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb > arch/arm/boot/dts/qcom-msm8960-cdp.dtb > > clock-controller@2088000: 'clocks' is a required property > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb > arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb > arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb > arch/arm/boot/dts/qcom-ipq8064-ap148.dtb > arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb > arch/arm/boot/dts/qcom-msm8960-cdp.dtb > > clock-controller@2098000: '#clock-cells' is a required property > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb > arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb > arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb > arch/arm/boot/dts/qcom-ipq8064-ap148.dtb > arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb > arch/arm/boot/dts/qcom-msm8960-cdp.dtb > > clock-controller@2098000: 'clock-names' is a required property > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb > arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb > arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb > arch/arm/boot/dts/qcom-ipq8064-ap148.dtb > arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb > arch/arm/boot/dts/qcom-msm8960-cdp.dtb > > clock-controller@2098000: 'clock-output-names' is a required property > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb > arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb > arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb > arch/arm/boot/dts/qcom-ipq8064-ap148.dtb > arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb > arch/arm/boot/dts/qcom-msm8960-cdp.dtb > > clock-controller@2098000: 'clocks' is a required property > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb > arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb > arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb > arch/arm/boot/dts/qcom-ipq8064-ap148.dtb > arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb > arch/arm/boot/dts/qcom-msm8960-cdp.dtb > > clock-controller@20a8000: '#clock-cells' is a required property > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb > arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb > arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb > > clock-controller@20a8000: 'clock-names' is a required property > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb > arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb > arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb > > clock-controller@20a8000: 'clock-output-names' is a required property > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb > arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb > arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb > > clock-controller@20a8000: 'clocks' is a required property > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb > arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb > arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb > > clock-controller@20b8000: '#clock-cells' is a required property > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb > arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb > arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb > > clock-controller@20b8000: 'clock-names' is a required property > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb > arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb > arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb > > clock-controller@20b8000: 'clock-output-names' is a required property > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb > arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb > arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb > > clock-controller@20b8000: 'clocks' is a required property > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb > arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb > arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb > (fixed in the last 2 commit of this series)
On Wed, Jun 29, 2022 at 02:14:38PM +0200, Christian Marangi wrote: > Convert kpss-acc driver Documentation to yaml. > The original Documentation was wrong all along. Fix it while we are > converting it. > The example was wrong as kpss-acc-v2 should only expose the regs but we > don't have any driver that expose additional clocks. The kpss-acc driver > is only specific to v1. For this exact reason, limit all the additional > bindings (clocks, clock-names, clock-output-names and #clock-cells) to > v1 and also flag that these bindings should NOT be used for v2. > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > --- > .../bindings/arm/msm/qcom,kpss-acc.txt | 49 ---------- > .../bindings/arm/msm/qcom,kpss-acc.yaml | 93 +++++++++++++++++++ > 2 files changed, 93 insertions(+), 49 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.txt > create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml > > diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.txt b/Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.txt > deleted file mode 100644 > index 7f696362a4a1..000000000000 > --- a/Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.txt > +++ /dev/null > @@ -1,49 +0,0 @@ > -Krait Processor Sub-system (KPSS) Application Clock Controller (ACC) > - > -The KPSS ACC provides clock, power domain, and reset control to a Krait CPU. > -There is one ACC register region per CPU within the KPSS remapped region as > -well as an alias register region that remaps accesses to the ACC associated > -with the CPU accessing the region. > - > -PROPERTIES > - > -- compatible: > - Usage: required > - Value type: <string> > - Definition: should be one of: > - "qcom,kpss-acc-v1" > - "qcom,kpss-acc-v2" > - > -- reg: > - Usage: required > - Value type: <prop-encoded-array> > - Definition: the first element specifies the base address and size of > - the register region. An optional second element specifies > - the base address and size of the alias register region. > - > -- clocks: > - Usage: required > - Value type: <prop-encoded-array> > - Definition: reference to the pll parents. > - > -- clock-names: > - Usage: required > - Value type: <stringlist> > - Definition: must be "pll8_vote", "pxo". > - > -- clock-output-names: > - Usage: optional > - Value type: <string> > - Definition: Name of the output clock. Typically acpuX_aux where X is a > - CPU number starting at 0. > - > -Example: > - > - clock-controller@2088000 { > - compatible = "qcom,kpss-acc-v2"; > - reg = <0x02088000 0x1000>, > - <0x02008000 0x1000>; > - clocks = <&gcc PLL8_VOTE>, <&gcc PXO_SRC>; > - clock-names = "pll8_vote", "pxo"; > - clock-output-names = "acpu0_aux"; > - }; > diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml b/Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml > new file mode 100644 > index 000000000000..5e16121d9f0d > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml > @@ -0,0 +1,93 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/msm/qcom,kpss-acc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Krait Processor Sub-system (KPSS) Application Clock Controller (ACC) > + > +maintainers: > + - Christian Marangi <ansuelsmth@gmail.com> > + > +description: | > + The KPSS ACC provides clock, power domain, and reset control to a Krait CPU. > + There is one ACC register region per CPU within the KPSS remapped region as > + well as an alias register region that remaps accesses to the ACC associated > + with the CPU accessing the region. > + > +properties: > + compatible: > + enum: > + - qcom,kpss-acc-v1 > + - qcom,kpss-acc-v2 > + > + reg: > + items: > + - description: Base address and size of the register region > + - description: Optional base address and size of the alias register region Optional? Need 'minItems: 1' then. > + > + clocks: > + items: > + - description: phandle to pll8_vote > + - description: phandle to pxo_board Not necessarily just a phandle... Needs a better description in terms of the function of the clock within the KPSS ACC block, not the source. > + > + clock-names: > + items: > + - const: pll8_vote > + - const: pxo > + > + clock-output-names: > + description: Name of the aux clock. Krait can have at most 4 cpu. s/cpu/CPUs/ > + enum: > + - acpu0_aux > + - acpu1_aux > + - acpu2_aux > + - acpu3_aux > + > + '#clock-cells': > + const: 0 > + > +required: > + - compatible > + - reg > + > +if: > + properties: > + compatible: > + contains: > + const: qcom,kpss-acc-v1 > +then: > + required: > + - clocks > + - clock-names > + - clock-output-names > + - '#clock-cells' > +else: > + properties: > + clocks: false > + clock-names: false > + clock-output-names: false > + '#clock-cells': false > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/qcom,gcc-ipq806x.h> > + > + clock-controller@2088000 { > + compatible = "qcom,kpss-acc-v1"; > + reg = <0x02088000 0x1000>, <0x02008000 0x1000>; > + clocks = <&gcc PLL8_VOTE>, <&pxo_board>; > + clock-names = "pll8_vote", "pxo"; > + clock-output-names = "acpu0_aux"; > + #clock-cells = <0>; > + }; > + > + - | > + clock-controller@f9088000 { > + compatible = "qcom,kpss-acc-v2"; > + reg = <0xf9088000 0x1000>, > + <0xf9008000 0x1000>; > + }; > +... > -- > 2.36.1 > >
diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.txt b/Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.txt deleted file mode 100644 index 7f696362a4a1..000000000000 --- a/Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.txt +++ /dev/null @@ -1,49 +0,0 @@ -Krait Processor Sub-system (KPSS) Application Clock Controller (ACC) - -The KPSS ACC provides clock, power domain, and reset control to a Krait CPU. -There is one ACC register region per CPU within the KPSS remapped region as -well as an alias register region that remaps accesses to the ACC associated -with the CPU accessing the region. - -PROPERTIES - -- compatible: - Usage: required - Value type: <string> - Definition: should be one of: - "qcom,kpss-acc-v1" - "qcom,kpss-acc-v2" - -- reg: - Usage: required - Value type: <prop-encoded-array> - Definition: the first element specifies the base address and size of - the register region. An optional second element specifies - the base address and size of the alias register region. - -- clocks: - Usage: required - Value type: <prop-encoded-array> - Definition: reference to the pll parents. - -- clock-names: - Usage: required - Value type: <stringlist> - Definition: must be "pll8_vote", "pxo". - -- clock-output-names: - Usage: optional - Value type: <string> - Definition: Name of the output clock. Typically acpuX_aux where X is a - CPU number starting at 0. - -Example: - - clock-controller@2088000 { - compatible = "qcom,kpss-acc-v2"; - reg = <0x02088000 0x1000>, - <0x02008000 0x1000>; - clocks = <&gcc PLL8_VOTE>, <&gcc PXO_SRC>; - clock-names = "pll8_vote", "pxo"; - clock-output-names = "acpu0_aux"; - }; diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml b/Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml new file mode 100644 index 000000000000..5e16121d9f0d --- /dev/null +++ b/Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml @@ -0,0 +1,93 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/msm/qcom,kpss-acc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Krait Processor Sub-system (KPSS) Application Clock Controller (ACC) + +maintainers: + - Christian Marangi <ansuelsmth@gmail.com> + +description: | + The KPSS ACC provides clock, power domain, and reset control to a Krait CPU. + There is one ACC register region per CPU within the KPSS remapped region as + well as an alias register region that remaps accesses to the ACC associated + with the CPU accessing the region. + +properties: + compatible: + enum: + - qcom,kpss-acc-v1 + - qcom,kpss-acc-v2 + + reg: + items: + - description: Base address and size of the register region + - description: Optional base address and size of the alias register region + + clocks: + items: + - description: phandle to pll8_vote + - description: phandle to pxo_board + + clock-names: + items: + - const: pll8_vote + - const: pxo + + clock-output-names: + description: Name of the aux clock. Krait can have at most 4 cpu. + enum: + - acpu0_aux + - acpu1_aux + - acpu2_aux + - acpu3_aux + + '#clock-cells': + const: 0 + +required: + - compatible + - reg + +if: + properties: + compatible: + contains: + const: qcom,kpss-acc-v1 +then: + required: + - clocks + - clock-names + - clock-output-names + - '#clock-cells' +else: + properties: + clocks: false + clock-names: false + clock-output-names: false + '#clock-cells': false + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/qcom,gcc-ipq806x.h> + + clock-controller@2088000 { + compatible = "qcom,kpss-acc-v1"; + reg = <0x02088000 0x1000>, <0x02008000 0x1000>; + clocks = <&gcc PLL8_VOTE>, <&pxo_board>; + clock-names = "pll8_vote", "pxo"; + clock-output-names = "acpu0_aux"; + #clock-cells = <0>; + }; + + - | + clock-controller@f9088000 { + compatible = "qcom,kpss-acc-v2"; + reg = <0xf9088000 0x1000>, + <0xf9008000 0x1000>; + }; +...
Convert kpss-acc driver Documentation to yaml. The original Documentation was wrong all along. Fix it while we are converting it. The example was wrong as kpss-acc-v2 should only expose the regs but we don't have any driver that expose additional clocks. The kpss-acc driver is only specific to v1. For this exact reason, limit all the additional bindings (clocks, clock-names, clock-output-names and #clock-cells) to v1 and also flag that these bindings should NOT be used for v2. Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> --- .../bindings/arm/msm/qcom,kpss-acc.txt | 49 ---------- .../bindings/arm/msm/qcom,kpss-acc.yaml | 93 +++++++++++++++++++ 2 files changed, 93 insertions(+), 49 deletions(-) delete mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.txt create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml