| Message ID | 8d7029cdf7b2ce0d1c43e6f91b3b9fdadece08ee.1656554759.git.chanho61.park@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | support USI for Exynos Auto v9 SoC | expand |
Hi Chanho, On Thu, 30 Jun 2022 at 05:19, Chanho Park <chanho61.park@samsung.com> wrote: > > Add samsung,exynosautov9-uart dedicated compatible for representing > usi of Exynos Auto v9 SoC. > > Signed-off-by: Chanho Park <chanho61.park@samsung.com> > --- > .../devicetree/bindings/soc/samsung/exynos-usi.yaml | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml > index fde886a8cf43..6e806e950a36 100644 > --- a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml > +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml > @@ -22,8 +22,12 @@ properties: > pattern: "^usi@[0-9a-f]+$" > > compatible: > - enum: > - - samsung,exynos850-usi # for USIv2 (Exynos850, ExynosAutoV9) > + oneOf: > + - items: > + - const: samsung,exynosautov9-usi > + - const: samsung,exynos850-usi > + - enum: > + - samsung,exynos850-usi # for USIv2 (Exynos850, ExynosAutoV9) > Why "samsung,exynos850-usi" is duplicated? Maybe it would be correct to leave only "items" and remove the "enum"? > reg: true > > -- > 2.36.1 >
On 30/06/2022 07:59, Sam Protsenko wrote: > Hi Chanho, > > On Thu, 30 Jun 2022 at 05:19, Chanho Park <chanho61.park@samsung.com> wrote: >> >> Add samsung,exynosautov9-uart dedicated compatible for representing >> usi of Exynos Auto v9 SoC. >> >> Signed-off-by: Chanho Park <chanho61.park@samsung.com> >> --- >> .../devicetree/bindings/soc/samsung/exynos-usi.yaml | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml >> index fde886a8cf43..6e806e950a36 100644 >> --- a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml >> +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml >> @@ -22,8 +22,12 @@ properties: >> pattern: "^usi@[0-9a-f]+$" >> >> compatible: >> - enum: >> - - samsung,exynos850-usi # for USIv2 (Exynos850, ExynosAutoV9) >> + oneOf: >> + - items: >> + - const: samsung,exynosautov9-usi >> + - const: samsung,exynos850-usi >> + - enum: >> + - samsung,exynos850-usi # for USIv2 (Exynos850, ExynosAutoV9) >> > > Why "samsung,exynos850-usi" is duplicated? Maybe it would be correct > to leave only "items" and remove the "enum"? It has to be like this. Either you use exynos850-usi directly (on Exynos850) or as a fallback (on Autov9). Best regards, Krzysztof
On 30/06/2022 04:16, Chanho Park wrote: > Add samsung,exynosautov9-uart dedicated compatible for representing > usi of Exynos Auto v9 SoC. > > Signed-off-by: Chanho Park <chanho61.park@samsung.com> > --- > .../devicetree/bindings/soc/samsung/exynos-usi.yaml | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml > index fde886a8cf43..6e806e950a36 100644 > --- a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml > +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml > @@ -22,8 +22,12 @@ properties: > pattern: "^usi@[0-9a-f]+$" > > compatible: > - enum: > - - samsung,exynos850-usi # for USIv2 (Exynos850, ExynosAutoV9) > + oneOf: > + - items: > + - const: samsung,exynosautov9-usi > + - const: samsung,exynos850-usi > + - enum: > + - samsung,exynos850-usi # for USIv2 (Exynos850, ExynosAutoV9) But now the comment is not appropriate. I can remove it while applying. > > reg: true > Best regards, Krzysztof
On Thu, 30 Jun 2022 at 10:11, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 30/06/2022 07:59, Sam Protsenko wrote: > > Hi Chanho, > > > > On Thu, 30 Jun 2022 at 05:19, Chanho Park <chanho61.park@samsung.com> wrote: > >> > >> Add samsung,exynosautov9-uart dedicated compatible for representing > >> usi of Exynos Auto v9 SoC. > >> > >> Signed-off-by: Chanho Park <chanho61.park@samsung.com> > >> --- > >> .../devicetree/bindings/soc/samsung/exynos-usi.yaml | 8 ++++++-- > >> 1 file changed, 6 insertions(+), 2 deletions(-) > >> > >> diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml > >> index fde886a8cf43..6e806e950a36 100644 > >> --- a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml > >> +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml > >> @@ -22,8 +22,12 @@ properties: > >> pattern: "^usi@[0-9a-f]+$" > >> > >> compatible: > >> - enum: > >> - - samsung,exynos850-usi # for USIv2 (Exynos850, ExynosAutoV9) > >> + oneOf: > >> + - items: > >> + - const: samsung,exynosautov9-usi > >> + - const: samsung,exynos850-usi > >> + - enum: > >> + - samsung,exynos850-usi # for USIv2 (Exynos850, ExynosAutoV9) > >> > > > > Why "samsung,exynos850-usi" is duplicated? Maybe it would be correct > > to leave only "items" and remove the "enum"? > > It has to be like this. Either you use exynos850-usi directly (on > Exynos850) or as a fallback (on Autov9). > Thanks for the explanation, I never thought about that case before, though noticed that pattern in bindings long ago. > Best regards, > Krzysztof
On Thu, 30 Jun 2022 at 05:19, Chanho Park <chanho61.park@samsung.com> wrote: > > Add samsung,exynosautov9-uart dedicated compatible for representing > usi of Exynos Auto v9 SoC. > > Signed-off-by: Chanho Park <chanho61.park@samsung.com> > --- Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> with a note for incorrect comment (I guess Krzysztof agreed to remove that while applying the patch). Thanks! > .../devicetree/bindings/soc/samsung/exynos-usi.yaml | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml > index fde886a8cf43..6e806e950a36 100644 > --- a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml > +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml > @@ -22,8 +22,12 @@ properties: > pattern: "^usi@[0-9a-f]+$" > > compatible: > - enum: > - - samsung,exynos850-usi # for USIv2 (Exynos850, ExynosAutoV9) > + oneOf: > + - items: > + - const: samsung,exynosautov9-usi > + - const: samsung,exynos850-usi > + - enum: > + - samsung,exynos850-usi # for USIv2 (Exynos850, ExynosAutoV9) > > reg: true > > -- > 2.36.1 >
diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml index fde886a8cf43..6e806e950a36 100644 --- a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml @@ -22,8 +22,12 @@ properties: pattern: "^usi@[0-9a-f]+$" compatible: - enum: - - samsung,exynos850-usi # for USIv2 (Exynos850, ExynosAutoV9) + oneOf: + - items: + - const: samsung,exynosautov9-usi + - const: samsung,exynos850-usi + - enum: + - samsung,exynos850-usi # for USIv2 (Exynos850, ExynosAutoV9) reg: true
Add samsung,exynosautov9-uart dedicated compatible for representing usi of Exynos Auto v9 SoC. Signed-off-by: Chanho Park <chanho61.park@samsung.com> --- .../devicetree/bindings/soc/samsung/exynos-usi.yaml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)